all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo Prikler <leo.prikler@student.tugraz.at>
To: Ellis Kenyo <me@elken.dev>, 46215@debbugs.gnu.org
Subject: [bug#46215] [PATCH] Add yadm
Date: Sun, 31 Jan 2021 18:38:02 +0100	[thread overview]
Message-ID: <84ab5054792abeb5e9b85d21229cd7182204d817.camel@student.tugraz.at> (raw)
In-Reply-To: <20210131164721.8792-1-me@elken.dev>

Hello Ellis,

Am Sonntag, den 31.01.2021, 16:47 +0000 schrieb Ellis Kenyo:
> ---
>  gnu/packages/package-management.scm | 32
> +++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
Your commit is missing a ChangeLog in its message.

> [...]
> +    (build-system gnu-build-system)
> +    (arguments
> +     '(#:tests? #f
Document why (i.e. "no check target").

> +       #:make-flags (list (string-append "PREFIX=" (assoc-ref
> %outputs "out")))
> +       #:phases
> +       (modify-phases %standard-phases
> +         (delete 'bootstrap)
> +         (delete 'configure)
> +         (delete 'build))))
yadm has a few things you need to patch.  For one, its shebang is
/bin/sh despite requiring bash.  Also it contains a large number of
_PROGRAM variables, which would be need to be replaced by their actual
store path (use the which procedure for that).

> +    (description "When you live in a command line, configurations
> are a deeply
> +personal thing. They are often crafted over years of experience,
> battles lost,
> +lessons learned, advice followed, and ingenuity rewarded. When you
> are away
> +from your own configurations, you are an orphaned refugee in
> unfamiliar and
> +hostile surroundings. You feel clumsy and out of sorts. You are
> filled with a
> +sense of longing to be back in a place you know. A place you built.
> A place
> +where all the short-cuts have been worn bare by your own travels. A
> place you
> +proudly call… $HOME.")
Nice advertisement, but not really a description.  yadm.1 has a better
one, but keep to the formatting in Guix (particularly double spaces
after sentence end).

> +    (license license:gpl3)))
Should be gpl3+.

Regards,
Leo





  reply	other threads:[~2021-01-31 17:39 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-31 16:47 [bug#46215] [PATCH] Add yadm guix-patches--- via
2021-01-31 17:38 ` Leo Prikler [this message]
2021-01-31 20:16   ` guix-patches--- via
2021-01-31 20:36     ` Leo Prikler
2021-02-01  3:44       ` guix-patches--- via
2021-02-01  8:13         ` Leo Prikler
2021-02-01 10:06           ` guix-patches--- via
2021-02-01 11:44             ` Leo Prikler
2021-02-06 10:05               ` Ellis Kenyő via Guix-patches via
2021-02-06 10:48                 ` Leo Prikler
2021-02-06 10:58                   ` Ellis Kenyő via Guix-patches via
2021-02-06 11:22                     ` Leo Prikler
2021-02-06 11:26                       ` Ellis Kenyő via Guix-patches via
2021-02-06 11:46                       ` Tobias Geerinckx-Rice via Guix-patches via
2021-02-06 12:41                         ` Leo Prikler
2021-02-06 11:30                     ` Tobias Geerinckx-Rice via Guix-patches via
2021-02-06 11:43                       ` Ellis Kenyő via Guix-patches via
2021-02-06 11:58                       ` Leo Prikler
2021-02-06 12:03                         ` Tobias Geerinckx-Rice via Guix-patches via
2022-09-09  0:01 ` [bug#46215] [PATCH] gnu: " kiasoc5 via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84ab5054792abeb5e9b85d21229cd7182204d817.camel@student.tugraz.at \
    --to=leo.prikler@student.tugraz.at \
    --cc=46215@debbugs.gnu.org \
    --cc=me@elken.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.