[bug#57688] [PATCH v4] gnu: Add wiggle.

[Maxime Devos <maximedevos@telenet.be>]

[-- Attachment #1.1.1: Type: text/plain, Size: 1186 bytes --]



On 09-09-2022 06:14, jgart wrote:
> +      (arguments
> +        (list #:make-flags
> +              #~(list "-I. -O3"
> +                      (string-append "CC=" #$(cc-for-target))
> +                      "INSTALL=\"install\""
> +                      "STRIP=-s"
> +                      (string-append "BINDIR=" #$output "/bin")
> +                      (string-append "MANDIR=" #$output "/share/man")
> +                      (string-append "CC=" #$(cc-for-target))
> +                      (string-append "PREFIX=" #$output))
> +               #:phases
> +               '(modify-phases %standard-phases

Nitpick: using G-exp for #:make-flags but not #:phases is inconsistent, 
though that's something a committer could adjust without any trouble.

> +                  (delete 'configure)
> +                  (replace 'check
> +                    (lambda* (#:key inputs ouputs tests? #:allow-other-keys)
> +                      (when tests?
> +                        (invoke "./dotest")))))))

That's what I had in mind, thanks.  For completeness, ideally someone 
would check the sources for malware, but otherwise LGTM.

Greetings,
Maxime.

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]