From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Bavier <ericbavier@openmailbox.org>
Subject: Re: [PATCH] gnu: ghc-split: Update dependencies.
Date: Thu, 22 Oct 2015 12:06:53 -0500
Message-ID: <8430abf596c070122bb0f2c462641a27@openmailbox.org>
References: <1445483479-19104-1-git-send-email-ericbavier@openmailbox.org>
	<1445503671-30014-1-git-send-email-ericbavier@openmailbox.org>
	<1445503671-30014-23-git-send-email-ericbavier@openmailbox.org>
	<87lhauq3p5.fsf@denknerd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53674)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1ZpJKW-0006zJ-4i
	for guix-devel@gnu.org; Thu, 22 Oct 2015 13:07:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1ZpJKR-0001gB-IG
	for guix-devel@gnu.org; Thu, 22 Oct 2015 13:07:08 -0400
Received: from smtp9.openmailbox.org ([62.4.1.43]:44349)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1ZpJKR-0001fw-Bw
	for guix-devel@gnu.org; Thu, 22 Oct 2015 13:07:03 -0400
In-Reply-To: <87lhauq3p5.fsf@denknerd.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Paul van der Walt <paul@denknerd.org>
Cc: guix-devel@gnu.org

On 2015-10-22 11:16, Paul van der Walt wrote:
> On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>>> +    (arguments
>>> +     `(#:phases
>>> +       (modify-phases %standard-phases
>>> +         (add-before
>>> +          'configure 'update-cabal
>>> +          ;; the cabal file on hackage is updated, but the tar.gz=20
>>> does not
>>> +          ;; include it.
>>> +          (lambda* _
>>> +            (copy-file (assoc-ref %build-inputs=20
>>> "ghc-split-cabal-update")
>>> +                       "split.cabal"))))))
>>>      (inputs
>>> -     `(("ghc-quickcheck" ,ghc-quickcheck)))
>>> +     `(("ghc-quickcheck" ,ghc-quickcheck)
>>> +       ("ghc-split-cabal-update"
>>> +        ,(origin
>>> +           (method url-fetch)
>>> +           (uri (string-append
>>> +                 "https://hackage.haskell.org/package/split-"
>>> +                 version "/revision/1.cabal"))
>>> +           (sha256
>>> +            (base32
>>> +            =20
>>> "1i1h5v1zqvganhzy1wdd9r648yjpir078n0g8051njg82h2f964h"))))))
>>>      (home-page "http://hackage.haskell.org/package/split")
>>>      (synopsis
>>>       "Combinator library for splitting lists")
>>=20
>> Similarly to the xmonad cabal patch, perhaps this could be addressed=20
>> with
>>=20
>>   #:configure-flags '("--allow-newer=3Dbase")
>=20
> Nope, that option doesn't exist, i've checked.
>=20
>> with an appropriate comment.  Otherwise using an origin snippet.
>=20
> I've made it into a (substitute* "split.cabal" ..) which simply updates
> the version number of base ("base <4.8" =E2=86=92 "base <4.9"), in acco=
rdance
> with the change on Hackage.  A comment is provided.

OK

> The patches responding to your latest batch of comments have been=20
> pushed
> to the wip-haskell-=E2=80=A6 branch.

Great! I'll take one last look, then I think we can merge.  WDYT?

--=20
`~Eric