* [bug#32872] [PATCH] gnu: LibreOffice: Fix GtkFileChooserDialog.
@ 2018-09-29 12:56 Leo Famulari
2018-09-29 22:05 ` Ludovic Courtès
0 siblings, 1 reply; 6+ messages in thread
From: Leo Famulari @ 2018-09-29 12:56 UTC (permalink / raw)
To: 32872
Without this, LibreOffice crashes on a foreign distro when the "file
open" dialog is launched. I think there *must* be a better solution but
until we identify it, we should fix the crash. I'm Currently building
this to test it.
* gnu/packages/libreoffice.scm (libreoffice)[arguments]: Add 'wrap-program'
phase.
---
gnu/packages/libreoffice.scm | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/libreoffice.scm b/gnu/packages/libreoffice.scm
index 35d49b021..198d4a625 100644
--- a/gnu/packages/libreoffice.scm
+++ b/gnu/packages/libreoffice.scm
@@ -1087,7 +1087,18 @@ converting QuarkXPress file format. It supports versions 3.1 to 4.1.")
(mkdir-p (string-append out "/share/icons/hicolor"))
(copy-recursively "sysui/desktop/icons/hicolor"
(string-append out "/share/icons/hicolor")))
- #t)))
+ #t))
+ (add-after 'bin-and-desktop-install 'wrap-programs
+ (lambda* (#:key inputs outputs #:allow-other-keys)
+ (let* ((out (assoc-ref outputs "out"))
+ (bin (string-append out "/bin")))
+ (for-each (lambda (file)
+ (wrap-program file
+ `("GSETTINGS_SCHEMA_DIR" =
+ (,(string-append (assoc-ref inputs "gtk+")
+ "/share/glib-2.0/schemas"))))
+ (find-files bin)))
+ #t))))
#:configure-flags
(list
"--enable-release-build"
--
2.19.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* bug#30642: [bug#32872] [PATCH] gnu: LibreOffice: Fix GtkFileChooserDialog.
2018-09-29 12:56 [bug#32872] [PATCH] gnu: LibreOffice: Fix GtkFileChooserDialog Leo Famulari
@ 2018-09-29 22:05 ` Ludovic Courtès
0 siblings, 0 replies; 6+ messages in thread
From: Ludovic Courtès @ 2018-09-29 22:05 UTC (permalink / raw)
To: Leo Famulari; +Cc: 32872, 30642
Hi!
Leo Famulari <leo@famulari.name> skribis:
> Without this, LibreOffice crashes on a foreign distro when the "file
> open" dialog is launched. I think there *must* be a better solution but
> until we identify it, we should fix the crash. I'm Currently building
> this to test it.
>
> * gnu/packages/libreoffice.scm (libreoffice)[arguments]: Add 'wrap-program'
> phase.
You could mention <https://bugs.gnu.org/30642> in the log.
One option discussed at the time was to use ‘glib-or-gtk-build-system’,
which should have an effect similar to the patch you posted. Perhaps we
should just do that?
> + (add-after 'bin-and-desktop-install 'wrap-programs
> + (lambda* (#:key inputs outputs #:allow-other-keys)
> + (let* ((out (assoc-ref outputs "out"))
Nitpick: the lambda’s body is too indented. :-)
Thank you!
Ludo’.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#32872] [PATCH] gnu: LibreOffice: Fix GtkFileChooserDialog.
@ 2018-09-29 22:05 ` Ludovic Courtès
0 siblings, 0 replies; 6+ messages in thread
From: Ludovic Courtès @ 2018-09-29 22:05 UTC (permalink / raw)
To: Leo Famulari; +Cc: 32872, 30642
Hi!
Leo Famulari <leo@famulari.name> skribis:
> Without this, LibreOffice crashes on a foreign distro when the "file
> open" dialog is launched. I think there *must* be a better solution but
> until we identify it, we should fix the crash. I'm Currently building
> this to test it.
>
> * gnu/packages/libreoffice.scm (libreoffice)[arguments]: Add 'wrap-program'
> phase.
You could mention <https://bugs.gnu.org/30642> in the log.
One option discussed at the time was to use ‘glib-or-gtk-build-system’,
which should have an effect similar to the patch you posted. Perhaps we
should just do that?
> + (add-after 'bin-and-desktop-install 'wrap-programs
> + (lambda* (#:key inputs outputs #:allow-other-keys)
> + (let* ((out (assoc-ref outputs "out"))
Nitpick: the lambda’s body is too indented. :-)
Thank you!
Ludo’.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#30642: [bug#32872] [PATCH] gnu: LibreOffice: Fix GtkFileChooserDialog.
2018-09-29 22:05 ` Ludovic Courtès
@ 2018-09-30 11:42 ` Leo Famulari
-1 siblings, 0 replies; 6+ messages in thread
From: Leo Famulari @ 2018-09-30 11:42 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 32872, 30642
[-- Attachment #1: Type: text/plain, Size: 715 bytes --]
On Sun, Sep 30, 2018 at 12:05:56AM +0200, Ludovic Courtès wrote:
> You could mention <https://bugs.gnu.org/30642> in the log.
Right, thanks.
> One option discussed at the time was to use ‘glib-or-gtk-build-system’,
> which should have an effect similar to the patch you posted. Perhaps we
> should just do that?
I tried this, and the build crashed in the
bin-and-desktop-install-phase. I'm currently rebuilding with
--keep-failed to learn more, but it takes several hours on my fastest
computer. Could I try building it on Bayfront to speed up the iteration
time?
> Nitpick: the lambda’s body is too indented. :-)
It turned out to be completely malformed, but I've fixed it locally.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#32872] [PATCH] gnu: LibreOffice: Fix GtkFileChooserDialog.
@ 2018-09-30 11:42 ` Leo Famulari
0 siblings, 0 replies; 6+ messages in thread
From: Leo Famulari @ 2018-09-30 11:42 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 32872, 30642
[-- Attachment #1: Type: text/plain, Size: 715 bytes --]
On Sun, Sep 30, 2018 at 12:05:56AM +0200, Ludovic Courtès wrote:
> You could mention <https://bugs.gnu.org/30642> in the log.
Right, thanks.
> One option discussed at the time was to use ‘glib-or-gtk-build-system’,
> which should have an effect similar to the patch you posted. Perhaps we
> should just do that?
I tried this, and the build crashed in the
bin-and-desktop-install-phase. I'm currently rebuilding with
--keep-failed to learn more, but it takes several hours on my fastest
computer. Could I try building it on Bayfront to speed up the iteration
time?
> Nitpick: the lambda’s body is too indented. :-)
It turned out to be completely malformed, but I've fixed it locally.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#30642: [bug#32872] [PATCH] gnu: LibreOffice: Fix GtkFileChooserDialog.
2018-09-30 11:42 ` Leo Famulari
(?)
@ 2018-12-04 21:29 ` Ludovic Courtès
-1 siblings, 0 replies; 6+ messages in thread
From: Ludovic Courtès @ 2018-12-04 21:29 UTC (permalink / raw)
To: Leo Famulari; +Cc: 32872-done, 30642-done
Leo Famulari <leo@famulari.name> skribis:
> On Sun, Sep 30, 2018 at 12:05:56AM +0200, Ludovic Courtès wrote:
>> You could mention <https://bugs.gnu.org/30642> in the log.
>
> Right, thanks.
This fix was pushed in 994bccd9443032141accede0e403cbfb62f6c63e,
closing!
Ludo’.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-12-04 21:31 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-29 12:56 [bug#32872] [PATCH] gnu: LibreOffice: Fix GtkFileChooserDialog Leo Famulari
2018-09-29 22:05 ` bug#30642: " Ludovic Courtès
2018-09-29 22:05 ` Ludovic Courtès
2018-09-30 11:42 ` bug#30642: " Leo Famulari
2018-09-30 11:42 ` Leo Famulari
2018-12-04 21:29 ` bug#30642: " Ludovic Courtès
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.