From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id aHK6M+GpjGbLNgAAe85BDQ:P1 (envelope-from ) for ; Tue, 09 Jul 2024 03:09:22 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id aHK6M+GpjGbLNgAAe85BDQ (envelope-from ) for ; Tue, 09 Jul 2024 05:09:21 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=dan.games header.s=fm3 header.b=PELOWpn7; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b="P q/SweG"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1720494561; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=GXBYqf49+gGwKbQ8KEb4CDRJH2poi7sRNpSyc3OEcOY=; b=Cbo+4POLtMqyOYXjzC5MM6ZU7BVV7jM9+xUpewJqgjraWnDRQtnIE3UH8Q7T9ad7NwXPX+ IomDvFrQnYDydT4isSYAqN6jureY8JzRZMxn20xdhaMD43+WruVD/l+/AfV3uAc3QXbm48 7K5ycZzroYHzFHeYOidyHSqPQ5X70mscZga6XD/1uKjs5bZiw3CE+cfjXXUSHW9qw9Zo8f GqHB9Plijt0gPJskxz1/XBrObxkZn6tZLCH2OJrbRWockEbLz8cfyC+7yVIxaLJdpvCJV4 ObQSDailQeD7n+i7ejBCUwb+68mhzA2vWoN7/ETyur9bPrUgfwg+aYWXv0kCWA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1720494561; a=rsa-sha256; cv=none; b=s57imbOOfyZ5adN7yryF32P3AVl97WKF7S/23bKmvKwh6mzrUn+6vAVBoqSYWm7Ij8VpW5 G62PnE3s1iZ30Ho5BZ7MxOL9HJEVZzG5O6K7ddCG1W36X78A+AcpYiO11a5WRTt2vpNw// xbvlOK0nSVVRQmIY8Il5NQUA5rOCaAab64c0sHXooCiP/1YtfibuXhQo2YxUvRIp4OB/lp nNTBGFLNaxm92sr5p2j+L0r5lLSy4mp5maxffm9n3LuPUxRagFQxtg4sZb4lNN+0/dYcKX zKUMroMEPOzxme8d6q2BksMOJFxUzNe2wIeQeaCBTwZ4FIUglfvT8NEkU5LOJw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=dan.games header.s=fm3 header.b=PELOWpn7; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b="P q/SweG"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E3B86DF5F for ; Tue, 09 Jul 2024 05:09:20 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sR1Dv-0007YL-9N; Mon, 08 Jul 2024 23:08:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sR1Dt-0007Y3-9X for guix-patches@gnu.org; Mon, 08 Jul 2024 23:08:57 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sR1Dt-00083B-26 for guix-patches@gnu.org; Mon, 08 Jul 2024 23:08:57 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sR1Dy-0003dj-0b for guix-patches@gnu.org; Mon, 08 Jul 2024 23:09:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71897] [PATCH 3/5] gnu: Add cppgir-for-telegram-desktop. Resent-From: dan Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 09 Jul 2024 03:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71897 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: Liliana Marie Prikler , 71897@debbugs.gnu.org Received: via spool by 71897-submit@debbugs.gnu.org id=B71897.172049449913940 (code B ref 71897); Tue, 09 Jul 2024 03:09:01 +0000 Received: (at 71897) by debbugs.gnu.org; 9 Jul 2024 03:08:19 +0000 Received: from localhost ([127.0.0.1]:51832 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sR1DG-0003cm-TV for submit@debbugs.gnu.org; Mon, 08 Jul 2024 23:08:19 -0400 Received: from fout2-smtp.messagingengine.com ([103.168.172.145]:47275) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sR1DD-0003cV-Mk for 71897@debbugs.gnu.org; Mon, 08 Jul 2024 23:08:17 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfout.nyi.internal (Postfix) with ESMTP id D9BE21381913; Mon, 8 Jul 2024 23:08:04 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 08 Jul 2024 23:08:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dan.games; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1720494484; x=1720580884; bh=GXBYqf49+gGwKbQ8KEb4CDRJH2poi7sRNpSyc3OEcOY=; b= PELOWpn7EIxrZlEBodIOP+asVoytNwDXZ6Dj4SF3t593wDj5YspnpI/a/RpvcCN4 +KFy/CeUPK5y7cdmSupPgP4k+8kwkCpJEC3dTJSEPEXQuQbRRgqTeCi90jkL4YNa emCc1VqmWED/k82dGGZYYxCMZdR619oNFMXH4QttFywf98Z8hyKqeecFC8Iicf0P +mDpNfmL58+SrerDfKpjYrRa2B+TY2wwiaeMOTbIM+8JPPS1WzO1vPcj+zJCNTW2 qOEJG4USL+cTz8RJS4O4x/Yzau1JKOWJnFr9QxNoAAWV5s79MMxeuRhySeaRqkA2 fxl4bRocpkcJrrNUIWkKdw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1720494484; x= 1720580884; bh=GXBYqf49+gGwKbQ8KEb4CDRJH2poi7sRNpSyc3OEcOY=; b=P q/SweGZCPZ94ZQIak9tNlDsMt4VGCF/C43yl9oQPpEAL8r2RWLgw6E/3Djh5gD2l Ing/2NfEgklNSdiQpCcOmw+OgQnOxUCEYF69dwRfi9/zJ17LZFBx5rbMfI8DbZOL VmLf3TESWYUYO5jFUYAKU4qqjavGEPCPlgomnmI2yCu644Wn83yC9mRdA8r7c5XS 440Wodl7qJHpdF831zSFOCsKJHl8efZPafz6GjihSvDKwowWdUU3MWN7uKf5F1pB Onht+zW060wY8ypGLyHnClhtKRqIgJfmzm4PWWk2npv9qLcnvHZqfDUhGb+yEScN 2ahftkcmJ4zf2vBr6VwvA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdekgdeiiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfevfhfhjggtgfesthejredttddvjeenucfhrhhomhepuggrnhcu oehisegurghnrdhgrghmvghsqeenucggtffrrghtthgvrhhnpefgudeffeeiuddvtddule eludevleehkeeuhedvfffgffdthfejffegtdduhfegkeenucffohhmrghinhepghhithhl rggsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepihesuggrnhdrghgrmhgvsh X-ME-Proxy: Feedback-ID: i3b5946ed:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 8 Jul 2024 23:07:56 -0400 (EDT) Message-ID: <82e92de9-50ed-4f7b-91d7-253c41da5965@dan.games> Date: Tue, 9 Jul 2024 11:07:54 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird References: <3743fa793bf867b8112b2883815b573f955c12ce.1720364199.git.i@dan.games> <17a452e63821067a5a3b27a6e4114404e242f290.1720364199.git.i@dan.games> <87h6czxpx7.fsf@gmail.com> Content-Language: en-US From: dan In-Reply-To: <87h6czxpx7.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -2.48 X-Spam-Score: -2.48 X-Migadu-Queue-Id: E3B86DF5F X-Migadu-Scanner: mx11.migadu.com X-TUID: X/Kj/OlJ1KwN On 7/9/2024 10:25 AM, Maxim Cournoyer wrote: > Hi Dan, > > dan writes: > >> * gnu/packages/telegram.scm (cppgir-for-telegram-desktop): New variable. >> >> Change-Id: I4bb37f9ebc6cfd711ad83f29cd95bc72c0d3bf45 >> --- >> gnu/packages/telegram.scm | 29 +++++++++++++++++++++++++++++ >> 1 file changed, 29 insertions(+) >> >> diff --git a/gnu/packages/telegram.scm b/gnu/packages/telegram.scm >> index 358374a5bb..26ab27293f 100644 >> --- a/gnu/packages/telegram.scm >> +++ b/gnu/packages/telegram.scm >> @@ -400,6 +400,35 @@ (define cld3-for-telegram-desktop >> (base32 >> "0ayrrhfdwrf4260h9fsirkhhfrcvc3qqnh6h9wj3ixij2lq0wwqb")))) >> >> +(define cppgir-for-telegram-desktop >> + (let ((commit "9c4f5820d94d62ab451501f016bfea97156518f4") >> + (revision "0")) >> + (package >> + (name "cppgir-for-telegram-desktop") >> + (version (git-version "2.0" revision commit)) >> + (source >> + (origin >> + (method git-fetch) >> + (uri >> + (git-reference >> + (url "https://gitlab.com/mnauw/cppgir") >> + (commit commit))) >> + (file-name (git-file-name name version)) >> + (sha256 >> + (base32 "1fa9nf4yljfarihaqj5kd98yysrky7q316mh6l5b1rq39ga15k9b")))) >> + (build-system cmake-build-system) >> + (arguments >> + (list >> + #:configure-flags >> + #~(list "-DINTERNAL_EXPECTED=OFF"))) >> + (inputs (list boost fmt expected-lite)) >> + (home-page "https://gitlab.com/mnauw/cppgir") >> + (synopsis "GObject introspection C++ binding wrapper generator") >> + (description "cppgir processes .gir files derived from GObject >> +introspection annotations into a set of C++ files defining suitable >> +namespaces, classes and other types that together form a C++ binding.") >> + (license license:expat)))) > > That'd be reasonable as a new package if it was very tightly developed > with telegram, but it doesn't seem to be the case. I'd prefer having it > in (gnu packages glib). > > What is the "compilation error" you had mentioned when using version > 2.0? Does the cppgir release fails to compile itself, or is it > telegram that then doesn't build using that one? Sorry about not directly replying the previous message. It's the latter, telegram-desktop fails to compile with cppgir@2.0. > > If the later, I'd define, in (gnu packages glib) > > --8<---------------cut here---------------start------------->8--- > (define-public cppgir > [...] > "original package at version 2.0") > > (define-public cppgir-for-telegram-desktop > (package > (inherit cppgir) > (source ... (using latest or telegram-specific (?) commit)))) > --8<---------------cut here---------------end--------------->8--- For the lower package definition, I put it in (gnu packages glib) or (gnu packages telegram)? I think it should be the latter one? > > Sorry for the back and forth, we're narrowing down on the perfect > submission; keep it up. Don't forget to use -v5 for your next patches > submission :-), and ensure 'guix lint' is happy with all the packages. > > Thank you for your efforts! Keep it up. > Sorry about forgetting to add revision number to the patch series. Although we have mumi right now, there are still a bit of manual works to be done before sending patches. I constantly forget some of them. -- dan