From mboxrd@z Thu Jan 1 00:00:00 1970 From: rennes@openmailbox.org Subject: Re: [PATCH 4/6] gnu: gnome-documents Date: Wed, 20 Apr 2016 08:26:47 -0500 Message-ID: <82d9bd5597b908cf9b7d23831f977e63@openmailbox.org> References: <77ce1f6925efaed801f9918af4a8834d@openmailbox.org> <87poudghfs.fsf@gnu.org> <20160418184457.GA27770@jasmine> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39641) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ass9q-0000hQ-MM for guix-devel@gnu.org; Wed, 20 Apr 2016 09:27:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ass9m-0005J8-L9 for guix-devel@gnu.org; Wed, 20 Apr 2016 09:27:06 -0400 Received: from smtp7.openmailbox.org ([62.4.1.41]:60888) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ass9m-0005Gf-Cc for guix-devel@gnu.org; Wed, 20 Apr 2016 09:27:02 -0400 In-Reply-To: <20160418184457.GA27770@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org On 2016-04-18 13:44, Leo Famulari wrote: > On Thu, Apr 14, 2016 at 10:35:00AM -0500, rennes@openmailbox.org wrote: >> On 2016-03-29 14:25, ludo@gnu.org wrote: >> >rennes@openmailbox.org skribis: >> > >> >>+ `(#:configure-flags >> >>+ '("--with-ca-certificates=/etc/ssl/certs/ca-certificates.crt") >> > >> >AFAICS glib-networking uses GnuTLS, for which we already had such a >> >setting (except that it can read all the .crt files from /etc/ssl/certs, >> >not just one bundle.) >> >> I did more tests and remove this part. >> >> >>+ (modify-phases %standard-phases >> >>+ (add-before 'check 'use-empty-ssl-cert-file >> >>+ (lambda _ >> >>+ ; Search for ca-certificates.crt files >> >>+ ; during the check phase. >> >>+ (setenv "SSL_CERT_FILE" "/dev/null") >> > >> >Does this really have an effect? This is the environment variable used >> >by OpenSSL, but not GnuTLS. >> >> indeed, it works. >> >> Question, to which package module I can add the patch? > > I've moved it into web.scm, in the attached revision on your patch. I > can apply it if you think it looks good. What do you think? > > I also reorganized the native-inputs a little bit, to put all the > "check" dependencies together. > > By the way, thanks for working on this patch series, and SORRY for the > slow review! Hi, I think it's okay. Thanks