From mboxrd@z Thu Jan  1 00:00:00 1970
From: julien lepiller <julien@lepiller.eu>
Subject: Re: 07/08: gnu: Add ocaml-ssl.
Date: Tue, 24 Jan 2017 10:31:49 +0100
Message-ID: <820ebaa9b8356d26ff0086b270248617@lepiller.eu>
References: <20170116213516.17292.49031@vcs.savannah.gnu.org>
	<20170116213517.59CD0220115@vcs.savannah.gnu.org>
	<20170123213118.GB735@jasmine>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38524)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <julien@lepiller.eu>) id 1cVxSN-00086Z-DK
	for guix-devel@gnu.org; Tue, 24 Jan 2017 04:32:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <julien@lepiller.eu>) id 1cVxSI-0006se-Cg
	for guix-devel@gnu.org; Tue, 24 Jan 2017 04:32:03 -0500
Received: from dau94-h03-89-91-205-84.dsl.sta.abo.bbox.fr
	([89.91.205.84]:53290 helo=skaro.lepiller.eu)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <julien@lepiller.eu>) id 1cVxSH-0006sT-VR
	for guix-devel@gnu.org; Tue, 24 Jan 2017 04:31:58 -0500
Received: from localhost (localhost [127.0.0.1])
	by skaro.lepiller.eu (Postfix) with ESMTP id 6CEC680FE9
	for <guix-devel@gnu.org>; Tue, 24 Jan 2017 10:31:53 +0100 (CET)
Received: from skaro.lepiller.eu ([127.0.0.1])
	by localhost (lepiller.eu [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id hYgRBWVPLuht for <guix-devel@gnu.org>;
	Tue, 24 Jan 2017 10:31:49 +0100 (CET)
Received: from webmail.lepiller.eu (localhost [127.0.0.1])
	by skaro.lepiller.eu (Postfix) with ESMTPA id 669167FA76
	for <guix-devel@gnu.org>; Tue, 24 Jan 2017 10:31:49 +0100 (CET)
In-Reply-To: <20170123213118.GB735@jasmine>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: guix-devel@gnu.org

Le 2017-01-23 22:31, Leo Famulari a =C3=A9crit=C2=A0:
> On Mon, Jan 16, 2017 at 09:35:17PM +0000, julien lepiller wrote:
>> roptat pushed a commit to branch master
>> in repository guix.
>>=20
>> commit 37f17e2a1e797d3d1ea12da5afd69526e0abfd3e
>> Author: Julien Lepiller <julien@lepiller.eu>
>> Date:   Fri Dec 30 11:53:24 2016 +0100
>>=20
>>     gnu: Add ocaml-ssl.
>>=20
>>     * gnu/packages/ocaml.scm (ocaml-ssl): New variable.
>=20
>> +                       (substitute* "src/OCamlMakefile"
>> +                         (("/bin/sh") (which "bash")))
>> +                       (substitute* "configure"
>> +                         (("/bin/sh") (which "bash"))))))))
>=20
> Hi Julien!
>=20
> I noticed that a handful of your new OCaml packages replace invocations
> of 'sh' with 'bash'. These shells actually have different behavior even
> though they are both provided by the Bash package (see INVOCATION in
> bash(1)).
>=20
> Can you change these substitutions to use (which "sh") instead?

I didn't think it would cause any issue, but sure I will.