bug#52267: Acknowledgement (disk image installer for rock64 fails)

[Maxime Devos <maximedevos@telenet.be>]

I forgot to add debbugs in CC, resending ...

Maxime Devos schreef op do 09-12-2021 om 07:41 [+0100]:
> Florian Hoertlehner schreef op do 09-12-2021 om 00:04 [+0100]:
> > 
> > installer build on core-updates-frozen build with cross-
> > compilaition
> > fails with:
> > -builder for `/gnu/store/49ir2x9wypyrv9p1gvd54pzj4frap2jg-
> > dosfstools-
> > 4.2.drv' failed with exit code 1
> 
> Seems like there are two bugs in the dosfstools package definition
> currently preventing cross-compilation:
> 
> This line  ...
> > #:make-flags (list (string-append "PREFIX=" %output) "CC=gcc")))
> 
> ... needs to be replaced by ...
> 
> > #:make-flags ,#~(list (string-append "PREFIX=" #$output) (string-
> > append "CC=" ,(cc-for-target)))
> 
> in the package definition of dosfstools.
> 
> To test, you can try
> 
> ./guix-cuf/bin/guix system disk-image --target=aarch64-linux-gnu -e
> '(begin (set! (@ (gnu packages disk) dosfstools) ((@ (guix packages)
> package) (inherit (@ (gnu packages disk) dosfstools)) (arguments
> `(#:make-flags ,#~(list (string-append "PREFIX=" #$output) (string-
> append "CC=" ,(cc-for-target))) #:configure-flags (list "--enable-
> compat-symlinks"))))) (@ (gnu system install) rock64-installation-
> os))'
> 
> or apply the change to a local git checkout of guix (see ‘17.1
> Building from Git’ in the manual’) and test from there.
> 
> After the aarch64-linux-gnu cross-compiler has finished building,
> I'll test that change.
> 
> Greetings,
> Maxime