From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:54438) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTSJk-0000Ra-2O for guix-patches@gnu.org; Tue, 28 Apr 2020 11:38:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jTSJi-0002xN-P4 for guix-patches@gnu.org; Tue, 28 Apr 2020 11:38:39 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57784) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jTRty-0005xe-Bm for guix-patches@gnu.org; Tue, 28 Apr 2020 11:12:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jTRty-0003gF-6D for guix-patches@gnu.org; Tue, 28 Apr 2020 11:12:02 -0400 Subject: [bug#40537] [PATCH] gnu: Add bchoppr. Resent-Message-ID: Message-ID: <81ab17c59752d69849e8ef41491ba3ad7bbb57d7.camel@zrythm.org> From: Alexandros Theodotou Date: Tue, 28 Apr 2020 16:11:11 +0100 In-Reply-To: <878six7upd.fsf@cbaines.net> References: <878six7upd.fsf@cbaines.net> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-pHLzc9lSe4veENEHeIjP" MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Christopher Baines Cc: 40537@debbugs.gnu.org --=-pHLzc9lSe4veENEHeIjP Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Chris, I think these should inherit from bsequencer since these are plugins by the same author and it's reasonable that they follow the same build procedure. We already to do this for other similar situations and it also makes maintenance easier and DRY. Perhaps moving them below bsequencer would be a better solution? > The second thing is that I'd try to avoid adding package definitions > at > the end of files, just because it can lead to more merge conflicts. I'll keep this in mind for future patches. Thanks, Alex On Tue, 2020-04-14 at 20:06 +0100, Christopher Baines wrote: > Alexandros Theodotou writes: >=20 > > These patches add 3 new LV2 plugins by the same author as > > bsequencer: > > bchoppr > > bshapr > > bjumblr >=20 > I've got a couple of comments. It looks to me like it would be > clearer > to not have the packages inherit from bsequencer. Some copying in the > package definitions is fine if there are similarities between > packages. >=20 > The second thing is that I'd try to avoid adding package definitions > at > the end of files, just because it can lead to more merge conflicts. >=20 > Would you be able to send some updated patches? >=20 > Thanks, >=20 > Chris --=-pHLzc9lSe4veENEHeIjP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEESBMjhK0999huJUuDAi6uQjE9cPMFAl6oR48ACgkQAi6uQjE9 cPOlbgf/fXk5DHelcp8fmFUEw6ttMYGPp9Xz22NoPhnuId8mBKnkOCu7IZvMc0of tSIdxKitqtALKy9mdDwuA3d+TGv9Fcz1FJG9N+wOckzUdyZgdwjJAMUhgzTwaeMW /Yam8C0UHdA4X47Xx7oYbiPBFWLcxRIU7dN9JApFdtMVXZMiiTaFE/U6Q40UZS5W aOrOqMAnE5dEE7XDImT1qGd7lnt3UB1zAtm1W84urJnSriJaB/K1zEwVaZvOeqWn 8rgS1JLzGccx7y97lnadFlhplUi43ljqzPHFwfNBG8VKYR0Izub5E0m9J+skJ8pl F3YTCFMEdulFowuDhw5dnv3l/y5SwA== =/ylv -----END PGP SIGNATURE----- --=-pHLzc9lSe4veENEHeIjP--