From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id cMS6M4htj2QYyAAASxT56A (envelope-from ) for ; Sun, 18 Jun 2023 22:48:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id GN+xM4htj2TjmwAA9RJhRA (envelope-from ) for ; Sun, 18 Jun 2023 22:48:08 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9B9DD3E382 for ; Sun, 18 Jun 2023 22:48:08 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qAzJc-0004UL-NK; Sun, 18 Jun 2023 16:48:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAzJa-0004UD-U3 for guix-patches@gnu.org; Sun, 18 Jun 2023 16:48:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qAzJa-0000z7-LQ for guix-patches@gnu.org; Sun, 18 Jun 2023 16:48:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qAzJa-0007Fn-Es for guix-patches@gnu.org; Sun, 18 Jun 2023 16:48:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64137] [PATCH 0/2] Build catch2@3 with CMake and update to 3.3.2 Resent-From: David Elsing Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 18 Jun 2023 20:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64137 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler , 64137@debbugs.gnu.org Received: via spool by 64137-submit@debbugs.gnu.org id=B64137.168712123827673 (code B ref 64137); Sun, 18 Jun 2023 20:48:02 +0000 Received: (at 64137) by debbugs.gnu.org; 18 Jun 2023 20:47:18 +0000 Received: from localhost ([127.0.0.1]:55022 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAzIs-0007CG-1A for submit@debbugs.gnu.org; Sun, 18 Jun 2023 16:47:18 -0400 Received: from mout02.posteo.de ([185.67.36.66]:55793) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAzIq-0007C2-5J for 64137@debbugs.gnu.org; Sun, 18 Jun 2023 16:47:16 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 3AB8F240101 for <64137@debbugs.gnu.org>; Sun, 18 Jun 2023 22:47:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1687121230; bh=69Q9QxUZO8UWXn+nbSkomN7jcOCWUVj76jJERBcESCo=; h=From:To:Subject:Date:Message-ID:MIME-Version:From; b=qqBMZlM1wWmRW8ofNRHT0gX2QJHygvSjZTpiTGg5aOxvy3CDW3NHoIP3MSUfZiv+c 5ODbnxvKGB5hQVSOy+rOeWPDCA1NMTxpJI07lcYPWAp35Fi7QFGeGLVSNzsq9sVV4H K63TB0BLwCNKawYG8s00kiblRaD7wG77vY2jLCMhNHW+OEuiDP5ZR0EZz4HZRrn+HP 2nN1aDED0+pUnNaY2bPAkqDNnkxILSXI5bLEINVniV1kX0uQItNhYDgR3+nPwyluFV jAaq6LffCkK5ctrr0IioHcaf+jX1dGMEoTue5JCcVwwD7F+xx1iYDlq1sBct5xeUEA Xs8ZjT3Gms8lA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QklM15ntHz6txF; Sun, 18 Jun 2023 22:47:09 +0200 (CEST) From: David Elsing In-Reply-To: <6d6d3fcc6d73630e1580e21784f76b968f66ec74.camel@gmail.com> References: <6d6d3fcc6d73630e1580e21784f76b968f66ec74.camel@gmail.com> Date: Sun, 18 Jun 2023 20:47:09 +0000 Message-ID: <7yh6r4ebw2.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1687121288; a=rsa-sha256; cv=none; b=Yba0stBcRecAqCrD/CS/RCUQjL7MJla/g+6Z5NJZ0FR2GO2mO90oT3sF6/J3ZA3lW22Qxv 0mHSCXpY9wBEwEDn//qItXboYmdcmWx0/fR4P5JOJZnpXOGpH3FrFMgTgAiUKRTGJGhQ0V yzeaQ7hj9egpVNE6Em+Arl+AFLn4dqYdzhaaKy7wmPR56kJQne2UoaatMyPhL+Ym8t+oWQ qCJTUOQn5Yc+Gs2ZBXmdMZB3c3kMqMvsaZgMKaL12aXU+ap9gVKYxwgr7Mk6LrryQvtjAx j8TVXuD3j2iqDR3kbC1gcA5PUzaTUI2SjOhSysADYZl3WfrOPWIgLfyEceLRlA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=qqBMZlM1; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1687121288; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=HAB9SyMqYIr7hdCEtDpon8iXYO2mTxLWzw4wuVzYqvs=; b=gYoalMjqCWAIuYh8mw9fgzTV6YtF0gOjztTV2i5zJ8USNtZzOLyk01ZYrsIvMMGWJXwhl8 kkdDtndmCr+V5tN17NaUyqh2KCNM72EFRzZasG0Ysq2Jd4eJlnwxML6WE819LEs7LqmVe+ CB1z42ujB26OR8QNB+NiWYl+9Gk5b9+BOA51DxU3sYs2C7rbQAXk6497wE5cTYNsJWxXqt WgRbGA2AWcc5JkfmjrA1Z77GR0XMGYx44XiObNRkjycxxEy0m6bwDahXLe26C4rkVNcSZO ZJ9eOkPehGf88FuR1eaVbkPiqnaX+fhwT9ya5NXV6h0Xx3RXlVT8La/nqOibow== Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=qqBMZlM1; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -3.45 X-Spam-Score: -3.45 X-Migadu-Queue-Id: 9B9DD3E382 X-TUID: xrvMN7nA9vPp Liliana Marie Prikler writes: > If you actually get clingo to build, that'd be one thing, but there > shouldn't be any issue getting our catch2 to work in CMake-based > projects to begin with. After all, we do provide a catch2-config that > simply invokes pkg-config. I'd hazard a guess that whatever project > you're trying to build pokes at internals it's not really supposed to > see. I see, what is missing are the "extras" like catch_discover_tests, but it seems they can just be copied to lib/cmake/Catch2. > > As for the upgrade to 3.3.2, I'd take that in solitude if clingo still > builds with it. If not, you'd have to make it an extra version. To build clingo with 3.3.2, the find_package(Catch2 3.1 ...) command just needed to be adjusted, but I went ahead and unbundled the remaining dependencies as well. Should this be a separate issue? For catch2, it seems simpler to me to build it with CMake, as I don't see the use case for the static library (as a second output). If you prefer, I can change it back to Meson though and just copy the files from the extras directory as well (provided it works).