From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56422)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dUf6F-00023F-T5
	for guix-patches@gnu.org; Mon, 10 Jul 2017 16:16:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dUf6A-0008Rk-R4
	for guix-patches@gnu.org; Mon, 10 Jul 2017 16:16:07 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:58596)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dUf6A-0008RM-IJ
	for guix-patches@gnu.org; Mon, 10 Jul 2017 16:16:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dUf6A-00039T-AG
	for guix-patches@gnu.org; Mon, 10 Jul 2017 16:16:02 -0400
Subject: [bug#27643] [PATCH] gnu: Add simplescreenrecorder.
Resent-Message-ID: <handler.27643.B27643.149971773212074@debbugs.gnu.org>
Message-Id: <7f621441.ADkAACOBA2gAAAAAAAAAAAPSojkAAAACwQwAAAAAAAW9WABZY-Bh@mailjet.com>
MIME-Version: 1.0
From: Arun Isaac <arunisaac@systemreboot.net>
Date: Tue, 11 Jul 2017 01:45:19 +0530
In-reply-to: <87o9sse07d.fsf@gmail.com>
References: <87o9sse07d.fsf@gmail.com>
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Alex Vong <alexvong1995@gmail.com>
Cc: 27643@debbugs.gnu.org


Thanks for the patch!

> +    (inputs `(("pkg-config" ,pkg-config)

pkg-config should be a native input.

> +              ("qt" ,qt-4) ; README.md: using Qt 5 causes some stability=
 issues
> +              ("ffmpeg" ,ffmpeg)
> +              ("alsa-lib" ,alsa-lib)
> +              ("pulseaudio" ,pulseaudio)
> +              ("jack" ,jack-1)
> +              ("glu" ,glu)
> +              ("libx11" ,libx11)
> +              ("libxfixes" ,libxfixes)
> +              ("libxext" ,libxext)

The package builds successfully without libx11, libxfixes and libxext
included as inputs. Are you sure they are needed? Could you check again?

> +              ("libxi" ,libxi)))

Also, could you sort all the inputs in alphabetical order, just for the
aesthetic appeal? :-)

> +    ;; Using HTTPS causes part of the page displayed improperly.
> +    (home-page "http://www.maartenbaert.be/simplescreenrecorder/")

We'll go with the HTTP URL for now. But, do report this issue upstream
as well.
=