From: Brendan Tildesley <brendan.tildesley@openmailbox.org>
To: guix-devel@gnu.org
Subject: Re: [PATCH 2/2] gnu: python: Add i3-quickswitch.
Date: Mon, 19 Sep 2016 20:20:26 +1000 [thread overview]
Message-ID: <7f06586d-9d76-77de-c366-3ff7feabf313@openmailbox.org> (raw)
In-Reply-To: <20160916054637.GB14289@jasmine>
Leo Famulari 於 2016-09-16 15:46 寫道:
> On Wed, Sep 14, 2016 at 11:17:24AM +0200, Ivan Vilata i Balaguer wrote:
>> Subject: [PATCH 2/2] gnu: python: Add i3-quickswitch.
>>
>> * gnu/packages/python.scm (i3-quickswitch): New variable.
> Cool, this works :)
>
>> +(define-public i3-quickswitch
>> + (package
>> + (name "i3-quickswitch")
> Again, I think that we should stay closer to the upstream name, in this
> case "quickswitch-for-i3".
I'm not a fan of "quickswitch-for-i3" and "python-i3-py". Perhaps a
better solution is to ensure "i3-py" in the description or synopsis so
that `guix package -s' finds it. As for quickswitch, isn't the upstream
name also simply "quickswitch-i3"?
>> + (build-system python-build-system)
> Also again, it would be nice to include README.rst.
next prev parent reply other threads:[~2016-09-19 10:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 9:12 [PATCH 0/2] Add quickswitch for i3 Ivan Vilata i Balaguer
2016-09-14 9:16 ` [PATCH 1/2] gnu: python: Add python-i3 Ivan Vilata i Balaguer
2016-09-14 10:17 ` Brendan Tildesley
2016-09-14 10:58 ` Ivan Vilata i Balaguer
2016-09-16 5:43 ` Leo Famulari
2016-09-14 9:17 ` [PATCH 2/2] gnu: python: Add i3-quickswitch Ivan Vilata i Balaguer
2016-09-14 10:25 ` Brendan Tildesley
2016-09-16 5:46 ` Leo Famulari
2016-09-19 9:24 ` Ivan Vilata i Balaguer
2016-09-19 9:28 ` Ivan Vilata i Balaguer
2016-09-19 21:39 ` Leo Famulari
2016-09-19 10:10 ` Hartmut Goebel
2016-09-19 21:39 ` Leo Famulari
2016-09-20 7:30 ` Ivan Vilata i Balaguer
2016-09-19 10:20 ` Brendan Tildesley [this message]
2016-09-19 21:42 ` Leo Famulari
2016-09-22 7:52 ` Hartmut Goebel
2016-09-16 5:52 ` [PATCH 0/2] Add quickswitch for i3 Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f06586d-9d76-77de-c366-3ff7feabf313@openmailbox.org \
--to=brendan.tildesley@openmailbox.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.