From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id MGJYH9UEM2KPTgEAgWs5BA (envelope-from ) for ; Thu, 17 Mar 2022 10:52:21 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 4N0gHNUEM2JXQwEAauVa8A (envelope-from ) for ; Thu, 17 Mar 2022 10:52:21 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 964ED3483 for ; Thu, 17 Mar 2022 10:52:13 +0100 (CET) Received: from localhost ([::1]:48400 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nUmnk-000065-No for larch@yhetil.org; Thu, 17 Mar 2022 05:52:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41898) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nUmnb-0008U9-1S for guix-patches@gnu.org; Thu, 17 Mar 2022 05:52:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:59196) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nUmna-0001cp-Os for guix-patches@gnu.org; Thu, 17 Mar 2022 05:52:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nUmna-0004Oj-EZ for guix-patches@gnu.org; Thu, 17 Mar 2022 05:52:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54396] [PATCH v2] [WIP] gnu: python-notmuch2: Fix build. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 17 Mar 2022 09:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54396 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tanguy LE CARROUR Cc: 54396@debbugs.gnu.org Received: via spool by 54396-submit@debbugs.gnu.org id=B54396.164751070916884 (code B ref 54396); Thu, 17 Mar 2022 09:52:02 +0000 Received: (at 54396) by debbugs.gnu.org; 17 Mar 2022 09:51:49 +0000 Received: from localhost ([127.0.0.1]:53093 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nUmnN-0004OG-DW for submit@debbugs.gnu.org; Thu, 17 Mar 2022 05:51:49 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:41446) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nUmnK-0004O3-Uf for 54396@debbugs.gnu.org; Thu, 17 Mar 2022 05:51:47 -0400 Received: from lprikler-laptop.ist.intra (gw.ist.tugraz.at [129.27.202.101]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4KK2V63LDwz3wZB; Thu, 17 Mar 2022 10:51:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1647510702; bh=Nfwx+b72TA1zt28jg9S0NmTLbTQn6IoA5M8Zkn1pIC8=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=ToCgK4u1UOp9xepE0VHbCDbV2ynrjL4XtjgQPqXyk+zWGM/syh+6c1E0QB/FYmFii IkApsThMDnIGxASwx+HQvHYscoEzialknrtg8IwYU2KiAlr3Uugrd8lH+8ulVY9m5+ gMDpP83JLorMAyLu75hnTi5gz/H9XFnuVsNfW0zc= Message-ID: <7ef5790e1f6c92df4cb03687502e45634af4cb59.camel@ist.tugraz.at> From: Liliana Marie Prikler Date: Thu, 17 Mar 2022 10:51:41 +0100 In-Reply-To: <164751023805.11899.12185326929295576108@localhost> References: <20220316111624.26189-1-tanguy@bioneland.org> <6b3d3874c3953688431be77f08989ef709780443.camel@ist.tugraz.at> <164743841502.31835.14352244026552742248@localhost> <164744931122.17491.16594765317356733408@localhost> <4235d01b2b9f335451e4715ea90fbe92d8ce7f91.camel@ist.tugraz.at> <164751023805.11899.12185326929295576108@localhost> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: waObeELIUl4ypBWmcn/8wQ X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1647510733; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Nfwx+b72TA1zt28jg9S0NmTLbTQn6IoA5M8Zkn1pIC8=; b=r5R2aLnGMrPvEihRHQEII7qCYkWEm3Yd2aiHoU4ZXUHiSvjX3gNVq4+Cff7bAHr8527L5T B8/b2MB5di7eJtlo/2tjqclfE2Z/+ovaVqmztDsRhIjGW7pKIp3UHrfcGcif4xJBaEa6oD W8m+qT6m8d3rC9Aaqgbq14k/+m7xuLA0pEQFwp8weNTqn38tYUcs4gTw0KA6asY0vNJJzS kfy6nyntcBn4IqRrx5tOoZj7weW0wnhFgw/Jdo1S1aA6y2u5pFyZfjuyZ/mF6ESIvpUDzK reE78/4ehWLi4X8p+Ab9QXCaE9i+AZ8h1BPizR9WJXDn8CzKd+NDSsP40+L0wA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1647510733; a=rsa-sha256; cv=none; b=SGumArPPyIbY0DlkJXnOpsim7wy9mi2W7lyWTsjnToXkGTp2lV0R3wvfofNJ2DilC/YIhJ kx/NovIWKJjzLXNB2Ys3EslLoTY8Kn2Bm0ugNlhCp0XIqr0bmqsElUZMxskc8e+UcQegji xcqNs5O/rBJ5oM0wGoY16ZAhnvlQvFJ4T2hgqdcupOaBTtwabed4Ypg2tTrVOwmkbWy+l2 O6r+srRS1zfBaAPQZSIIg5YeARK1WK1cW47SbBa/cgvfO1CXDrrbYPbQgLAtpZC8SZDt61 vDKf4ymWi7F+/PT/9fzqP1ZZRkrG6+ZsyTdaUnHr1k6XRoODUgmjqd8Kafq7nw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=ToCgK4u1; dmarc=fail reason="SPF not aligned (relaxed)" header.from=tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 4.94 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=ToCgK4u1; dmarc=fail reason="SPF not aligned (relaxed)" header.from=tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 964ED3483 X-Spam-Score: 4.94 X-Migadu-Scanner: scn0.migadu.com X-TUID: XXRZ/GGJhSyq Am Donnerstag, dem 17.03.2022 um 10:43 +0100 schrieb Tanguy LE CARROUR: > Hi Liliana, > > Quoting Liliana Marie Prikler (2022-03-17 07:59:48) > > Am Mittwoch, dem 16.03.2022 um 17:48 +0100 schrieb Tanguy LE > > CARROUR: > > > > That is actually a mistake on my part, search-input-file should > > > > search inputs for "include/notmuch.h" and likewise > > > > "lib/libnotmuch.so".  > > > > The dirname is important here, since both constants want > > > > directories. > > > > Alternatively, forgoing those constants might be a good idea, > > > > but is not worth investing too much time in. > > > > > > So, I'm leaving those as they are for now. > > I think you misunderstood me.  It is absolutely necessary that you > > instantiate these variables correctly.  It is not necessary to > > substitute* their uses. > > You right, I **totally** misunderstood you! Sorry! > I didn't pay attention to the fact that I left the actual file names > in, instead of using the folder names. > Hope I've gotten it right this time and that you are not getting > tired of reviewing my patch! :-) You'd do well using search-input-file as I've suggested for a while now ;) > > > > > > > > > substitute* is not nice when dealing with multi-line expressions.  > > I think you could replace NOTMUCH_VERSION_FILE with '/dev/null' and > > "VERSION = .*" with (string-append "VERSION = " #$version). > > Oh, looks like gexp magic to me, right? I'm not (yet) comfortable > with it! So I came up with another version. Seems to work as I've > built, installed and used it! I think we need to convert this package to the newstyle anyway, so it's not something you have to do, but it'd be appreciated if you first translated the existing package to use gexps and then applied your modifications on top. That being said, using this-package is IIRC fine for such purposes. Regarding NOTMUCH_VERSION_FILE, I don't think we should put an "implemented" value into a file that (as far as I can see) ends up being installed. So here you have to substitute* the use in setup.py instead. Cheers