[bug#27671] [PATCH] gnu: Add bmon.

[bug#27671] [PATCH] gnu: Add bmon.

[Arun Isaac]

* gnu/packages/networking.scm (bmon): New variable.
---
 gnu/packages/networking.scm | 30 +++++++++++++++++++++++++++++-
 1 file changed, 29 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index d4b9a3d12..c6a47f924 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -9,7 +9,7 @@
 ;;; Copyright © 2016 Nicolas Goaziou <mail@nicolasgoaziou.fr>
 ;;; Copyright © 2016 Eric Bavier <bavier@member.fsf.org>
 ;;; Copyright © 2016, 2017 ng0 <ng0@libertad.pw>
-;;; Copyright © 2016 Arun Isaac <arunisaac@systemreboot.net>
+;;; Copyright © 2016, 2017 Arun Isaac <arunisaac@systemreboot.net>
 ;;; Copyright © 2016 Benz Schenk <benz.schenk@uzh.ch>
 ;;; Copyright © 2016, 2017 Pjotr Prins <pjotr.guix@thebird.nl>
 ;;; Copyright © 2017 Mathieu Othacehe <m.othacehe@gmail.com>
@@ -70,6 +70,7 @@
   #:use-module (gnu packages textutils)
   #:use-module (gnu packages tls)
   #:use-module (gnu packages valgrind)
+  #:use-module (gnu packages wm)
   #:use-module (gnu packages xml)
   #:use-module (ice-9 match))
 
@@ -1387,3 +1388,30 @@ newer and only works on Ethernet network interfaces.")
     ;; AGPL 3 with exception for linking with OpenSSL. See the 'LICENSE' file in
     ;; the source distribution for more information.
     (license license:agpl3)))
+
+(define-public bmon
+  (package
+    (name "bmon")
+    (version "4.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/tgraf/bmon/releases/download/v4.0/bmon-"
+                           version ".tar.gz"))
+       (sha256
+        (base32
+         "0ylzriv4pwh76344abzl1w219x188gshbycbna35gsyfp09c7z82"))))
+    (build-system gnu-build-system)
+    (inputs
+     `(("libconfuse" ,libconfuse)
+       ("libnl" ,libnl)
+       ("ncurses" ,ncurses)))
+    (native-inputs `(("pkg-config" ,pkg-config)))
+    (synopsis "Bandwidth monitor")
+    (description "bmon is a monitoring and debugging tool to capture
+networking related statistics and prepare them visually in a human friendly
+way.  It features various output methods including an interactive curses user
+interface and a programmable text output for scripting.")
+    (home-page "https://github.com/tgraf/bmon")
+    (license (list license:bsd-2
+                   license:expat))))
-- 
2.12.2

[bug#27671] [PATCH] gnu: Add bmon.

[Tobias Geerinckx-Rice]

[-- Attachment #1.1: Type: text/plain, Size: 1518 bytes --]

Arun,

Thanks! Just a few comments:

On 12/07/17 17:43, Arun Isaac wrote:
> +(define-public bmon
> +  (package
> +    (name "bmon")
> +    (version "4.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://github.com/tgraf/bmon/releases/download/v4.0/bmon-"

Use ‘version’ instead of "4.0" here, as well.

> +                           version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "0ylzriv4pwh76344abzl1w219x188gshbycbna35gsyfp09c7z82"))))
> +    (build-system gnu-build-system)
> +    (inputs
> +     `(("libconfuse" ,libconfuse)
> +       ("libnl" ,libnl)
> +       ("ncurses" ,ncurses)))
> +    (native-inputs `(("pkg-config" ,pkg-config)))

I'd write this as two lines for consistency and aesthetics.

> +    (synopsis "Bandwidth monitor")
> +    (description "bmon is a monitoring and debugging tool to capture
> +networking related statistics and prepare them visually in a human friendly

‘networking-related’, ‘human-friendly’.

> +way.  It features various output methods including an interactive curses user
> +interface and a programmable text output for scripting.")
> +    (home-page "https://github.com/tgraf/bmon")
> +    (license (list license:bsd-2
> +                   license:expat))))

Hm. Do you know which files are BSD-licenced? Quite a few have an
expat-style header, but only ‘README.md’ mentions BSD (while saying
nothing of use).

Kind regards,

T G-R


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 504 bytes --]

[bug#27671] [PATCH] gnu: Add bmon.

[Arun Isaac]

Tobias Geerinckx-Rice writes:

>> +     (origin
>> +       (method url-fetch)
>> +       (uri (string-append "https://github.com/tgraf/bmon/releases/download/v4.0/bmon-"
>
> Use ‘version’ instead of "4.0" here, as well.

Noted.

>> +    (native-inputs `(("pkg-config" ,pkg-config)))
>
> I'd write this as two lines for consistency and aesthetics.

Noted.

>> +    (description "bmon is a monitoring and debugging tool to capture
>> +networking related statistics and prepare them visually in a human friendly
>
> ‘networking-related’, ‘human-friendly’.

Noted.

>> +    (license (list license:bsd-2
>> +                   license:expat))))
>
> Hm. Do you know which files are BSD-licenced? Quite a few have an
> expat-style header, but only ‘README.md’ mentions BSD (while saying
> nothing of use).

You are right. All files have expat license headers. I have contacted
the author seeking clarification.

https://github.com/tgraf/bmon/issues/59

Let's wait and see if the author replies in a few days.

[bug#27671] [PATCH] gnu: Add bmon.

[Arun Isaac]

>>> +    (license (list license:bsd-2
>>> +                   license:expat))))
>>
>> Hm. Do you know which files are BSD-licenced? Quite a few have an
>> expat-style header, but only ‘README.md’ mentions BSD (while saying
>> nothing of use).
>
> You are right. All files have expat license headers. I have contacted
> the author seeking clarification.
>
> https://github.com/tgraf/bmon/issues/59
>
> Let's wait and see if the author replies in a few days.

No response from upstream yet. How shall we proceed?

[bug#27671] [PATCH] gnu: Add bmon.

[Tobias Geerinckx-Rice]

[-- Attachment #1.1: Type: text/plain, Size: 1003 bytes --]

Arun,

On 20/07/17 17:00, Arun Isaac wrote:
>>>> +    (license (list license:bsd-2
>>>> +                   license:expat))))
>>>
>>> Hm. Do you know which files are BSD-licenced? Quite a few have an
>>> expat-style header, but only ‘README.md’ mentions BSD (while saying
>>> nothing of use).
>>
>> You are right. All files have expat license headers. I have contacted
>> the author seeking clarification.
>>
>> https://github.com/tgraf/bmon/issues/59
>>
>> Let's wait and see if the author replies in a few days.
> 
> No response from upstream yet. How shall we proceed?

Thanks for keeping track of this!

While it's always good to be certain (even authors sometimes get
confused about their own intentions), it's not like we risk omitting a
licence or misrepresenting the author's intent in this case.

I'd say this is fine to push with the above licence list + a short
explanation + link to your issue report. We can always amend it later.

Kind regards,

T G-R


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 504 bytes --]

bug#27671: [PATCH] gnu: Add bmon.

[Arun Isaac]

Pushed!