From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id oKGGMjqSvWFklgAAgWs5BA (envelope-from ) for ; Sat, 18 Dec 2021 08:48:10 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id qBVGLjqSvWE4LwAAB5/wlQ (envelope-from ) for ; Sat, 18 Dec 2021 07:48:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6C3D41B75C for ; Sat, 18 Dec 2021 08:48:10 +0100 (CET) Received: from localhost ([::1]:56082 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1myURt-0001Jw-Gm for larch@yhetil.org; Sat, 18 Dec 2021 02:48:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33074) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1myURm-0001Jk-DK for guix-patches@gnu.org; Sat, 18 Dec 2021 02:48:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:57893) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1myURm-0004jc-01 for guix-patches@gnu.org; Sat, 18 Dec 2021 02:48:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1myURl-0000fV-V9 for guix-patches@gnu.org; Sat, 18 Dec 2021 02:48:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#52238] [PATCH] gnu: Add MEGA SDK Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 18 Dec 2021 07:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52238 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jaft , "52238@debbugs.gnu.org" <52238@debbugs.gnu.org> Received: via spool by 52238-submit@debbugs.gnu.org id=B52238.16398136732523 (code B ref 52238); Sat, 18 Dec 2021 07:48:01 +0000 Received: (at 52238) by debbugs.gnu.org; 18 Dec 2021 07:47:53 +0000 Received: from localhost ([127.0.0.1]:41206 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myURd-0000ea-0X for submit@debbugs.gnu.org; Sat, 18 Dec 2021 02:47:53 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:46862) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myURb-0000ds-P1 for 52238@debbugs.gnu.org; Sat, 18 Dec 2021 02:47:52 -0500 Received: by mail-wr1-f66.google.com with SMTP id i22so8247730wrb.13 for <52238@debbugs.gnu.org>; Fri, 17 Dec 2021 23:47:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:date:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=gKSrQFRQlYmQxl0wXNyHWEty6ZabjnthBbAV/z3n41w=; b=XWFfIaeTboP7J0/joH4qXSO0mIGVFVZ2HtzWKRYhH1okjPkD8yavfqg8YmVienW6+h wY+Fq8onUM3xgnSvXtVLMp+I4RrSOzpQggBoN5opYdcroxhTzETHZgFmfWgYn183V4NP 0LgizSW/sau4FC03XQ+TI90uBUfOEskB/G8a0tgblmwc2COwqSwgHsDMz2iLzWom88Ik xm1Kv+/ONcUVCaUd2H4aY+lqIq+60O7pLxDgoeBrsK98VcAOrc6m67m+2Ugm9yg+WGpp PGliIMUz0B17iMrRAMxTaTdauIwpzMwo5Zg0PoiGf1QE3TbM2cFkS8ZiLh2DJhG+xPRk weDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=gKSrQFRQlYmQxl0wXNyHWEty6ZabjnthBbAV/z3n41w=; b=BXFlVzJHYLZvEUu0ZOBj6nJoZHpzDgpWwJOHVoHmTa0j9zOXZR7NndzghD3meig3Ex ABdZlhOZEd3lNM5+RJWWcFg7XcU7xMggsgyCcYw1lhjJUYmLW0ldTTtez/YE143T4rl+ KIg9V2FDFDjNrx6N/S29HAF76dCOBFqgw/FRcclAgfVyOZeolghTw/GHxA/usRXRjuCn CE5DVHjqiBmsA2ARe6HODIYOJBSZbQrYKG78u79UIP5g/g408V3vCFpQOMz7Zec7Ujp0 QAeaQS7nRyUsc7lMI/wFTHpVKJAl1wWtolaLnn6Y+kB1ZDqbmYZhAy2pcRNKgBnczB/Z GSaQ== X-Gm-Message-State: AOAM531MW8oKWis2CpAB8SPSiUaPMrulBBhKTFRptc8eW43ovWz2muVO bzIl3y6cZtAXCBbUZP/a90M= X-Google-Smtp-Source: ABdhPJwbCORZxGOv/n+qur+fokKgXEg9EbFRF6h83PDGYv8PuqQbpJa4ORu/rpwxPB7vkM6rwds8iQ== X-Received: by 2002:a5d:50c2:: with SMTP id f2mr3639982wrt.459.1639813665870; Fri, 17 Dec 2021 23:47:45 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id r62sm9072141wmr.35.2021.12.17.23.47.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Dec 2021 23:47:45 -0800 (PST) Message-ID: <7ccce938f59f1c712e13a30601591a516d466338.camel@gmail.com> From: Liliana Marie Prikler Date: Sat, 18 Dec 2021 08:47:44 +0100 In-Reply-To: References: <1136809883.7440498.1638426746315.ref@mail.yahoo.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1639813690; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=gKSrQFRQlYmQxl0wXNyHWEty6ZabjnthBbAV/z3n41w=; b=JEV//DD4EZZqn2oN785O3TC1byzGm3cABQ97e72pVOfGWx0GCjeXgOg4sIJJSA/uO+bffp 2W8LmrVDuxOz0ULLddXNnOpBAYiiJpLSbBQ6YYxROhws3GMSbji8+qQNyRbUiELx+dCcQE J7PEiftAQqR6UjhB4oqXfvzrFIH5X2NVTsCFtTQEMxBzPJaILOyyXx1v92NrDII6TtYrry FyZK9r/IVmXVIn5WqyIRKF+4DKCIAHSC+cRYAOY+T/+YtCqNpgtMl73UY37Nm+Bs8wzpsR 3UumTc1eGNgiDT8ZfIzBa933JOYXlj6l7bL5TLD4KcAXZEjs4LkZKF4LyDnmEg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1639813690; a=rsa-sha256; cv=none; b=d04AEQjpobCgqhVac2Jcmzrq+YJIvdwL6Ukhm1llM0BodGvMo4zbZJBrI/wR+QrqCebmE7 IYBqndwAgyqIh4joMvy4FZxfAScJHxqXIylo96BKZF6FrS9/tXfcWxGjBRITiac7OGpIo9 w5iHgR5UBPrhA2lqldvDFgiZITPK0m8+k2iQQUUH+GDbrQlEXjAdPzrpGUAXcyqsXqdRIl PWlot6oN6kdZNWN7Z26f6FWuCiuCIw7CbpvbhgqJ7P5PzqM6LZalRjuDw6DHi5NNIXBpqN 6+XPdLzsMjDaR1KnrromX7Z7bUEKxwCYs17n3F4n+997C2hd4kTPApPz46Eptw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=XWFfIaeT; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.20 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=XWFfIaeT; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 6C3D41B75C X-Spam-Score: -3.20 X-Migadu-Scanner: scn0.migadu.com X-TUID: FpQSAoCOMoe3 Hi Jaft, Am Samstag, dem 18.12.2021 um 05:14 +0000 schrieb Jaft: > >  > +    ;; XXX: Disabling tests because they depend on libgtest.la > > from > >  > googletest, > >  > +    ;; which is not installed for unclear reasons. > >  > +    (arguments `(#:tests? #f)) > >  Unclear reasons including googletest not being present in the > > inputs? > >  You probably want to swap out the .la dependency for a .so > > dependency. > > Hmm; I thought it was for the same reasons that tests had been > disabled for megacmd but, taking another look at it, it seems I'm > misremembering from the last time I worked on this. > > It says it's failing because the MEGA_EMAIL and MEGA_PWD environment > variables aren't set; from what I can tell, it uses those to test > whether it can interact with a MEGA account appropriately. As that'd > require requests to the internet, I'd expect the tests to fail in the > end, still; is that a reasonable reason to disable them or should I > try some other course of action? If the entire suite requires internet access, then yeah, that's a good case for #:tests? #f. If it's just certain test cases/groups, then we'd rather go for disabling those. > >  >  (define-public megacmd > >  >    (package > >  >      (name "megacmd") > >  > @@ -222,8 +262,7 @@ (define-public megacmd > >  >          (method git-fetch) > >  >          (uri (git-reference > >  >                (url "https://github.com/meganz/MEGAcmd") > >  > -              (commit (string-append version "_Linux")) > >  > -              (recursive? #t))) > >  > +              (commit (string-append version "_Linux")))) > >  >          (sha256 > >  >          (base32 > >  >            > > "004j8m3xs6slx03g2g6wzr97myl2v3zc09wxnfar5c62a625pd53")) > >  > @@ -242,6 +281,7 @@ (define-public megacmd > >  >        ("curl" ,curl) > >  >        ("freeimage" ,freeimage) > >  >        ("gtest" ,googletest) > >  > +      ("mega-sdk" ,mega-sdk) > >  >        ("openssl" ,openssl) > >  >        ("pcre" ,pcre) > >  >        ("readline" ,readline) > >  Pardon me if I was unclear, but this would be done in a separate > >  commit.  But thanks anyway for confirming that it'd be easily > >  swappable. > > Gotcha; because I'm unsure, how should I do that? Should I just > attach two separate patches? Or should I open a separate ticket for > the megacmd update (with its own separate patch, of course)? You can send two patches as attachments, that's completely fine with me. The typical Guix approach would however be to set up git send- email and invoke it like  $ git send-email --to=BUGNUMBER@debugs.gnu.org [--cc=REVIEWER ...] \  [--in-reply-to=MSGID] [--reroll-count N] PATCH ... That's probably a lot to take in at once, but once you get the hang out of it, it's actually quite easy. You can also use `git format-patch` to prepare the emails with the arguments above and then send them by a separate command. In any case, they go to a singular BUGNUMBER, in this case 52238. Cheers