From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id MMgoOQm0BmQh9QAASxT56A (envelope-from ) for ; Tue, 07 Mar 2023 04:48:26 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id sEbRNwm0BmSCQgAAG6o9tA (envelope-from ) for ; Tue, 07 Mar 2023 04:48:25 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 989C423429 for ; Tue, 7 Mar 2023 04:48:25 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZOJ1-0000Yt-RF; Mon, 06 Mar 2023 22:48:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZOJ0-0000YR-Eb for guix-patches@gnu.org; Mon, 06 Mar 2023 22:48:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pZOJ0-0005fb-6b for guix-patches@gnu.org; Mon, 06 Mar 2023 22:48:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pZOJ0-0002J2-30 for guix-patches@gnu.org; Mon, 06 Mar 2023 22:48:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#61975] [PATCH] gnu: i3-wm: Add missing propagated inputs. Resent-From: SeerLite Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 07 Mar 2023 03:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61975 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= Cc: 61975@debbugs.gnu.org Received: via spool by 61975-submit@debbugs.gnu.org id=B61975.16781608728799 (code B ref 61975); Tue, 07 Mar 2023 03:48:02 +0000 Received: (at 61975) by debbugs.gnu.org; 7 Mar 2023 03:47:52 +0000 Received: from localhost ([127.0.0.1]:44180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZOIq-0002Hq-7R for submit@debbugs.gnu.org; Mon, 06 Mar 2023 22:47:52 -0500 Received: from knopi.disroot.org ([178.21.23.139]:58574) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZOIo-0002HY-Ib for 61975@debbugs.gnu.org; Mon, 06 Mar 2023 22:47:51 -0500 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id E50C941441; Tue, 7 Mar 2023 04:47:49 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id m7NNSjwfOZeU; Tue, 7 Mar 2023 04:47:48 +0100 (CET) Message-ID: <7c2cad9e-45fd-1998-d0cc-24dfad01a7cb@disroot.org> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1678160868; bh=O5Ji75pPcezNDrd3r2+iBTVEvN8xCAwEATthTJ+PYqc=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=Yv9j5novDEeLvIAt00J5P4244tr98tb4ryL+pDVqhWK1dSOEWrec65WiKt4kcPQLT 0rgmeQsoJrETnShAR1OT7m5gahTYlkPELiaBA51yEl86rdodh1UVBXKoPPWAynfQm2 I6j/soXeTLJjr+7Z0kYaNlW5Cbro9jepTAGE+4m7rLzCGZhmYH7fgvGqz69GXlojYr 9wp0GhYo1CrO7IQt1hwIijgUu0BVZWktD4wlAXBwOaomIHxeje99ioAoKiwuoEwojM b9W6mre6uvx/vDBcb6pKO547t0ftmpDnYei6X2HzKAi0p5ri9MLsiZocz+rGxIogIy LVehNvqnUnUgg== Date: Tue, 7 Mar 2023 03:47:24 +0000 MIME-Version: 1.0 Content-Language: en-US References: <20230305062848.13101-1-seerlite@disroot.org> <87sfeip9ic.fsf@envs.net> In-Reply-To: <87sfeip9ic.fsf@envs.net> Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: SeerLite X-ACL-Warn: , SeerLite via Guix-patches From: SeerLite via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1678160905; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=at6RxbShNnTbkm1THedyDR4vJXqrs5FPr25ds9vJj0g=; b=t70jyj3W0NLDbQjfvUcnqkXkvtP/aI4OlTlIP7VLNGdiXW47zzZZdUneKLGem25kRWKcgO IJKNr5KJV76qKAc9BCmQoQEUYYhdj5X6nE/8fGxfF1LdHYsKufYJ7b6e/NC6RLdFWYT8Az NNRvXdhdETjZNeq3vlVGiZZOfOz1yxDC2GcFTSn3FN8nlNoC8y7ZmhAyzMSpSkOsqaj8Nt mDvReitwJhaiWcNOH6nHTKDi2KMe2mN1zyUXarDHUn2jfyF5jkifToQEd6bVKEuYCD2mZq 7+LIrCqFtgkDwuBH8sOt0RyAH9RTAZj2OKOVoTeYlkJNwpcZm2xG17z3Zb6Meg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=Yv9j5nov; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1678160905; a=rsa-sha256; cv=none; b=rnKKLnSHW92BW+k2kuYtjsSW24fKjLjZXh+DTNwY3mjRZf6tntIw8r3sodQ/SyCEtfl3yI fKgvh/UHiz8UlqCxD+wBUQIsfk4kj6JVjdB14p6O4OFZvc4V5+QHaLFbzhIJPu4vTn5Mw8 QUdGoOh5eIOLu1qnpQPnsBacoZ9I528j3eTEcN1GXVqQW3itf526E0edoQPfC5Rzkx/TKj L+mZOqSsVIdJ9vW3bfsBDrF5e1hgLFrd2pKeJTf2Q8HIxU9ZeuuX8fZCzwqra96hTYkOeW szzd0OOoC8aUZ9UradWUFvT11iwseXbccf/oXnf7Ug1WWz4Q7HHiPLbKNFCNYw== Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=Yv9j5nov; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org X-Migadu-Spam-Score: -1.91 X-Spam-Score: -1.91 X-Migadu-Queue-Id: 989C423429 X-Migadu-Scanner: scn1.migadu.com X-TUID: 1NC9v/tqk1uf

Hi!

On 3/6/23 08:30, 宋文武 wrote:
SeerLite <seerlite@disroot.org> writes:


perl-anyevent-i3 is necessary to run i3-save-tree.

* gnu/packages/wm.scm (i3-wm)[propagated-inputs]: Add perl and perl-anyevent-i3.
---
 gnu/packages/wm.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index 5b8dbd5c70..8816f110bb 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -356,6 +356,8 @@ (define-public i3-wm
            startup-notification
            pango
            cairo))
+    (propagated-inputs
+     (list perl perl-anyevent-i3))

Hello, this can also be done by 'wrap-program' i3-save-tree with
PERL5LIB.  And a wrapper is considered better than propagated-input here
due to the latter will introduce perl and its libraries into user's
profile, which may not be what a typical i3 user want and will also
increase the chance of conflicts in profile.

Could you send an update patch to use 'wrap-program' for i3-save-tree?
Thank you!
Done! I also updated the package to the gexp style. I hope it was a good idea, I'm not sure if I did it right.

When I was doing as you said with wrap-program I noticed i3-save-tree complained about many more missing libraries, so I added those too. I don't understand why those don't report as missing with my v1 patch. I'm testing with guix shell --pure.
These libraries are definitely not coming from my profile when propagating. Was it maybe perl-anyevent-i3 propagating them?

Also, I'm not sure where to put the perl input. Should I remove it from native-inputs? Or would it be needed in both inputs and native-inputs? It's used both at build time and after installation by i3-save-tree.

Thank you for the comments!

SeerLite