From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id oDWsBS5AMWVBDQEA9RJhRA:P1 (envelope-from ) for ; Thu, 19 Oct 2023 16:41:50 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id oDWsBS5AMWVBDQEA9RJhRA (envelope-from ) for ; Thu, 19 Oct 2023 16:41:50 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A1A223C455 for ; Thu, 19 Oct 2023 16:41:49 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1697726510; a=rsa-sha256; cv=none; b=cYH2Xly9xqPWYHRL1dbPNm9N/IHbTbSCwIG1ACAUENGGVXNqD8Z5faoAr9PumXrALk3bFX gRoW3sam0e7Qk5zHXlMcUoxM6G+LFLlCEDIF7pNmBbJhdXTYg8hqNiiTvN2/QJwZ/ZJQ1R loKwKKp/MI/Jt8/4QuIc9twxk8VePMTmghnztGvs7T1Tem4ICQr5DiNCwdusWEWDoFaWMI pkIcSqTCEB+NU+ydVuq3LSw5RlhhIm8lPPWpG5b79zqAq7gLxtzdsA7WHK5kpYwb3yXw4c FnbTr5gD1SUwhbaTkAqyvav4+j3TyuceVBj44jI5ZaGh9X5V0/5pnkmwX23VaA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1697726510; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=pAgfMKyGFjB9uYvZYEHuoWcjNmOvW0DbHagev8/DDwk=; b=Tu8ItuCPA9dyn4+xktw52Idjxocqdb8S1csSUDExcvmHnj2+T2q+s8K/wUBw7iKbFmYgyj X17vJ9MEIFOEYeMDaZnnjaPMsC51t7h8WWR05rvub5BCfTTebVln5TmK4HiIJR85OZ9SmX c/pVNVhkA4szVDI5JCtIYIoj1B043/QBeCix4a8GQeyW8znkewLMp6JD+OgjHa3ziiUJGa PQQ86GTwWB7B17KJGCj18QO9M113UelkX3Llj/nA1IQecs8Cj5b5/YNQ+DXdnxzQoEHMcg uhhRPmN1apHKToqV6SOP6ttW2/HoUpc1bKp+YS2xUONkdfMuiTaLYbo4T2LGIA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qtUDS-0006gs-5j; Thu, 19 Oct 2023 10:41:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtUDQ-0006ch-83 for guix-patches@gnu.org; Thu, 19 Oct 2023 10:41:36 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qtUDP-00020Z-Q2 for guix-patches@gnu.org; Thu, 19 Oct 2023 10:41:35 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qtUDq-00019z-DP for guix-patches@gnu.org; Thu, 19 Oct 2023 10:42:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63877] [PATCH v2] gnu: services: web: Allow specifying extra php-fpm environment variables. Resent-From: Bruno Victal Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 19 Oct 2023 14:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63877 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: moreinfo patch To: Timo Wilken Cc: 63877@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 63877-submit@debbugs.gnu.org id=B63877.16977265204450 (code B ref 63877); Thu, 19 Oct 2023 14:42:02 +0000 Received: (at 63877) by debbugs.gnu.org; 19 Oct 2023 14:42:00 +0000 Received: from localhost ([127.0.0.1]:37409 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtUDo-00019i-2s for submit@debbugs.gnu.org; Thu, 19 Oct 2023 10:42:00 -0400 Received: from smtpm1.myservices.hosting ([185.26.105.232]:38314) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtUDl-00019Y-Pz for 63877@debbugs.gnu.org; Thu, 19 Oct 2023 10:41:59 -0400 Received: from mail1.netim.hosting (unknown [185.26.106.173]) by smtpm1.myservices.hosting (Postfix) with ESMTP id B00FE2023A; Thu, 19 Oct 2023 16:41:28 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id E438980099; Thu, 19 Oct 2023 16:32:40 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-2.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Fzffnv2mtbct; Thu, 19 Oct 2023 16:32:40 +0200 (CEST) Received: from [192.168.1.116] (unknown [10.192.1.83]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id 2883E80098; Thu, 19 Oct 2023 16:32:40 +0200 (CEST) Message-ID: <7be3201e-af9b-4ad0-81d6-44ab316d2162@makinata.eu> Date: Thu, 19 Oct 2023 15:32:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird References: Content-Language: en-US From: Bruno Victal In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx1.migadu.com X-Migadu-Spam-Score: -6.15 X-Spam-Score: -6.15 X-Migadu-Queue-Id: A1A223C455 X-TUID: BYaVn0RD/zuy Hi Timo, On 2023-10-15 21:54, Timo Wilken wrote: > Hi Bruno, (hi Ludo'), thank you for your detailed feedback and sorry for not > responding earlier! > > On Mon Jun 5, 2023 at 5:44 AM CEST, Bruno Victal wrote: >> Ungexp-ing lists can be rather tricky [...] >> >> You need to quote the list [...] > > I was thinking of something closer to the example I added to doc/guix.texi in > my patch. The gexp would not be a list directly, but instead be some code that > would produce a list when evaluated, e.g.: > > --8<---------------cut here---------------start------------->8--- > #~(list (string-append "SSL_CERT_DIR=" #$nss-certs "/etc/ssl/certs")))) > --8<---------------cut here---------------end--------------->8--- > > That would let you refer to store paths in variable values, instead of being > limited to literal strings. Right, I can see that it is indeed useful to accept a G-Exp instead. > As far as I know, the following throws an error, and `file-append' instead of > `string-append' wouldn't work because of the `"SSL_CERT_DIR="' prefix, right? > > --8<---------------cut here---------------start------------->8--- > #~(#$(string-append "SSL_CERT_DIR=" nss-certs "/etc/ssl/certs")))) > --8<---------------cut here---------------end--------------->8--- This ungexp doesn't work because it's “too wide”, in fact the bug in [1] was caused by a very similar snippet. Furthermore this would still run into the ungexp pitfall of being interpreted as a procedure call since you now have: --8<---------------cut here---------------start------------->8--- … #:environment-variables (append ("SSL_CERT_DIR=…" …) (default-environment-variables)) … --8<---------------cut here---------------end--------------->8--- You could try using a list gexps/strings like this: --8<---------------cut here---------------start------------->8--- (list #~(string-append "SSL_CERT_DIR=" #$nss-certs "/etc/ssl/certs") "FOO=bar" (string-append "BAR=" 999)) --8<---------------cut here---------------end--------------->8--- Although your G-Exp idea might be better as it obviates the need to do things like '#$ (by using #~(list …) or #~'("foo" …)). [1]: -- Furthermore, I consider that nonfree software must be eradicated. Cheers, Bruno.