From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 8F7/M61eVWQXVAAASxT56A (envelope-from ) for ; Fri, 05 May 2023 21:53:17 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id uKvRM61eVWRC6wAA9RJhRA (envelope-from ) for ; Fri, 05 May 2023 21:53:17 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 60CF1161FD for ; Fri, 5 May 2023 21:53:17 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pv1UG-00073F-Tz; Fri, 05 May 2023 15:53:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pv1UE-000731-My for bug-guix@gnu.org; Fri, 05 May 2023 15:53:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pv1UD-0003hy-Nn for bug-guix@gnu.org; Fri, 05 May 2023 15:53:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pv1UD-0005dt-Jx for bug-guix@gnu.org; Fri, 05 May 2023 15:53:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#63082: [PATCH v3 05/16] services: mpd: Obsolete the 'group' field. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 05 May 2023 19:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63082 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Maxim Cournoyer , 63082@debbugs.gnu.org Received: via spool by 63082-submit@debbugs.gnu.org id=B63082.168331632821622 (code B ref 63082); Fri, 05 May 2023 19:53:01 +0000 Received: (at 63082) by debbugs.gnu.org; 5 May 2023 19:52:08 +0000 Received: from localhost ([127.0.0.1]:57588 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pv1TM-0005cg-DE for submit@debbugs.gnu.org; Fri, 05 May 2023 15:52:08 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:52670) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pv1TK-0005cB-Dm for 63082@debbugs.gnu.org; Fri, 05 May 2023 15:52:07 -0400 Received: by mail-ed1-f67.google.com with SMTP id 4fb4d7f45d1cf-50bc456cc39so3325065a12.1 for <63082@debbugs.gnu.org>; Fri, 05 May 2023 12:52:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683316321; x=1685908321; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=ejJ/MnOXy4Ww/ZGjPQ17fDGHQE3t27RE4BESUqJO+ws=; b=sHNxnHuOl0FEqKs1wGtb7rqRN9IP78RjLwYHEB8uWUWNuuKuY8zlUREN8zV653nIbv ESY5/NVtfKrASH3fJzkcfd8hT4CWuWJ1W83SCQb2pqpmmtVgBFj7q1RnnCw31gLUkyfi 2iaOT9HqyuY6wRn5k9rDI6tmo3Tu1db9ybCHlKLxqXuGwCFvY7PM+MJHCjKL38VmjAmY PIYApsWrd/WjvZZ0RyXZW9kOeqRBy619FbD4VwRhyjyXA26/ClkhSGeMjawDMlmQqbvU 39MdHtxCfb44gkYibevTUQjPKDjg/VZyUW1CdqB+tnvUznLKD9ia0WKxXM2s8kkNSrgL lyaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683316321; x=1685908321; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ejJ/MnOXy4Ww/ZGjPQ17fDGHQE3t27RE4BESUqJO+ws=; b=aPKWYD/iYaMU43LDWw6IRbTnwIhpjnaXJ6YOxih82nq7XQiuX30d7ivHId79wUpicP EmYJaIcIic3+5C7ntdNQ4jxk4OCYQUWkXMGE4vf+TeOr+Vm+lkfoPgXrZ79JqjRf2CKF I7cMXt+x+Pt4I5pwktKuF60oigs96yb83QDh/f2hYo2MyRGjMweY/bC3EHO1+8XrR5UI uC98wm992DLrYu4aZy8FkZ1oP23sRL/a1DhBiii9cBTntuccY4BxF3/f0zlU/jzmXHXF u+O4dCEjGpCfXYjWfYLdgkameApBXQ3DtAPkexZp3SC37X/3qoLf1mjS8cr3NAL5k/jv R5yA== X-Gm-Message-State: AC+VfDzxvcimfFZPQgeySNEXPvuJ7zwt/o/Q6e0Dlwh2DRvqRdMkirUY XDf0sKfVBSIAoRS07jFBrSs= X-Google-Smtp-Source: ACHHUZ7wNF6fwtoEVbD5kTbyvA0TRtiZjOJRbFrvKqPOUuE8kcIYHCoKGIejYXZMAd3hfQF0ow2xnQ== X-Received: by 2002:a17:907:3e83:b0:957:1268:e611 with SMTP id hs3-20020a1709073e8300b009571268e611mr2741029ejc.1.1683316320447; Fri, 05 May 2023 12:52:00 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id gj36-20020a170907742400b00965b5540ad7sm1337535ejc.17.2023.05.05.12.51.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 May 2023 12:52:00 -0700 (PDT) Message-ID: <7ba0cf980bf4ad3766c6c0ae30b069ed2891128e.camel@gmail.com> From: Liliana Marie Prikler Date: Fri, 05 May 2023 21:51:59 +0200 In-Reply-To: <40db40a2bbfe5e0586d8b8c9694607bc0d66e340.1683299529.git.maxim.cournoyer@gmail.com> References: <40db40a2bbfe5e0586d8b8c9694607bc0d66e340.1683299529.git.maxim.cournoyer@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Seal: i=1; s=key1; d=yhetil.org; t=1683316397; a=rsa-sha256; cv=none; b=psPBuOEKEJJDsssvT1odf2pFcShM70bzUxotpfjEcykrQdLejKzuJHEJEUGwKskbP8iOLa zbJS9w55jwZ5J2Pra3eiBzl9HzZHYmQmSSYHKbVEwjUMszleTzLXD8SJelEyufwLiBMmVw tQ7xOzxrZWKeL0wUKcaooq9PeTpDeumE797O9LKeJ0l0e5gEeRCaHjF37n9qEsMhjgwU+B v4oEn+4TuoeZJOzB2qxQRlphUOXVayES/dLrSFjtGHVhAIYAAMGs4+8PLpZZkGZ5utP82w xoCSgcSh82QvR0neuGbFNIpiMsjvhdFcdbc8s6re+Z/vR7o85kbazA0tO+WN/Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=sHNxnHuO; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1683316397; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ejJ/MnOXy4Ww/ZGjPQ17fDGHQE3t27RE4BESUqJO+ws=; b=lGeHcVHv+sG/Thji9lwovoB1XQRNp082gLjo6pH1qLbLaZuhv6lyyY2MMHncXMX9QST047 o0DIVU915zKfLlDjETSYVwgAniPpCTK3j5j5l8yC66OxwM2rGpK3C0mkuDZqvERK9XlC0d gAhHOztlXlf+peLZUFwqWcKJk62suOxZguP76mK2w9VMIYhhF1tTYfNU1rZ41WNgWYrQKm bOzIcOBoYQ1DSckaQsuuFYX878k2nnPUysPNLocUnGNluxorTW45puerwykCTsvVuh/7hE 6jJzl4HXzMMh8nTSCtQ0/Zn1IkSVWMz98cU6Cy55pUVCZyCoSmZa9A4hqRqo6w== X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=sHNxnHuO; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.80 X-Spam-Score: 5.80 X-Migadu-Queue-Id: 60CF1161FD X-TUID: HZYh3bYtkZGk Am Freitag, dem 05.05.2023 um 14:29 -0400 schrieb Maxim Cournoyer: > Prior to this change, there was a discrepancy where a user could have > disagreeing groups between the group and user fields (the user field > being a record, which includes its primary group as a > string).=C2=A0 This could have caused problems because the USER's group > was being used to set the file permissions, while the GROUP name was > serialized to MPD's configuration, and MPD would use it to set the > group of its running process.=C2=A0=C2=A0 Didn't we agree in v2 that we want to address this on the account- service level? Unless the rest of this series somehow depends on this patch, I'd rather delay it until we have a proper solution. > Synchronizing both is not practical, as it can easily lead to > slightly different objects conflicting, again causing > problems. It might not be practical to do so inside the service, but note how this has already become an effort in defensive programming. There are easier ways to not make this a problem on the configuration level, namely by specifying the same group for both user and group fields. As far as I see this is even the default state of being if the user is supplied as a string. Cheers