From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 6O09GULadWBbIAEAgWs5BA (envelope-from ) for ; Tue, 13 Apr 2021 19:52:02 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 8KcnE0LadWBDcAAA1q6Kng (envelope-from ) for ; Tue, 13 Apr 2021 17:52:02 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F0D5C1F3D4 for ; Tue, 13 Apr 2021 19:52:01 +0200 (CEST) Received: from localhost ([::1]:42136 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lWNCj-0005m4-2x for larch@yhetil.org; Tue, 13 Apr 2021 13:52:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38114) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWNCX-0005lm-Fl for guix-devel@gnu.org; Tue, 13 Apr 2021 13:51:49 -0400 Received: from andre.telenet-ops.be ([2a02:1800:120:4::f00:15]:45864) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lWNCR-0003NY-Ek for guix-devel@gnu.org; Tue, 13 Apr 2021 13:51:49 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by andre.telenet-ops.be with bizsmtp id sHrf2400B0mfAB401HrfA2; Tue, 13 Apr 2021 19:51:39 +0200 Message-ID: <79d3d2e5c1386b1e162f1ba8380562720131856d.camel@telenet.be> Subject: Re: [Outreachy] - Guix Data Service - Set a more informative page title From: Maxime Devos To: Canan Talayhan Date: Tue, 13 Apr 2021 19:51:32 +0200 In-Reply-To: References: Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-bbj9wSHaxbFMV8JE58qB" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1618336299; bh=lUf7XHrvkXEvHS9r6o/PYvHNfnCwq4gVk8v+0+kBqTQ=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=ECrbbUE2iyqN7bx7tr30xUuqBrG58kUA3kxUAbnyiXZhEmJpCELZQELXzf2IMnF+O wIbhVaZId1fwZe2MiqxBwsCa2C4hilCsinBLADfZUPFElyAlBQh0lTq+AdhjVBU9Pj 8lJxnJJ0x5CPJ9JCnEf/M3xC9pk7TVAE0dKvey6TG5CyburlI7DIkbOozh7t8RfsM3 niJ3NQjcxyVJrsmPX0nZBpGf2YtxH77/rZSukwn21hPpDWFTfH1mzOahiB5ylTv13c /1b/j6b3MfL5i36AH0QlRcSLX4ZlSufuW/jzoJTQAAa1m67YZcAdk1ia+S0GJe2dU+ 7Wp5ncN7QFHIg== Received-SPF: pass client-ip=2a02:1800:120:4::f00:15; envelope-from=maximedevos@telenet.be; helo=andre.telenet-ops.be X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1618336322; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=lUf7XHrvkXEvHS9r6o/PYvHNfnCwq4gVk8v+0+kBqTQ=; b=D5DonQtBhyw+V2q3nHj3VEDgtoG9JYTWYsvrwI8if94uwdKb4euykyUBJJseVjrCkucHUB aQwcQpceoXq3NjfIo0qqDSzWu81GtFz1qnlVCnsGKJhVvWm+r4XCrBPopPFPXrpNvo9I3/ HKgHEbkOdbJzkiP3iH9+Gd9AcCkQY1BKm8NRgMj0lXebhxG6rxhoCFTlxSvumSLu8hwq8w bP3/JjCGsIwyyr0zhdyBWI6x1D7rjgTvWMqyQbKRK1bjb+Ojc+VXM5StVwvR5xyZFZkeV/ 9hgtAYpCXd6uGBJSmN/SHXvY7GokTbP0gLc/HACRQdLXCjiqBSXnemLCn+BZJA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1618336322; a=rsa-sha256; cv=none; b=EgmsuWOWNT4RmoDAUrhGeXoXa06qdcnssw1niXWE3ttE6KZ3arrTRHygyKzhachnqLeKI0 2nv2G/H17LXW0YNVHrOrMW5Md005jCNdnTM/nUd7hpAIq/GLgjrAci13wZZ++LDzcHVNAf CAZa1byaqLnIbsjUDT6AysmcQOCHMPSghyfShNeSK7+FLc6LxwsfRfH/mkVma0QbFOl5Gs eXUrM8fKyl39NQ1jj43kOCtEzeBlfT46sd5kSOuuPvwrHl/OvpuYHqvIlKHOK0pGIyG3BK ykWjaRDM69zV+xjzLi9B/0QnAMILzF5NLw7g+IQNCCLfciiCM2L05WGG5t0tfA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=telenet.be header.s=r21 header.b=ECrbbUE2; dmarc=pass (policy=none) header.from=telenet.be; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -5.24 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=telenet.be header.s=r21 header.b=ECrbbUE2; dmarc=pass (policy=none) header.from=telenet.be; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: F0D5C1F3D4 X-Spam-Score: -5.24 X-Migadu-Scanner: scn0.migadu.com X-TUID: zG6tFDgX8Ids --=-bbj9wSHaxbFMV8JE58qB Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2021-04-13 at 18:56 +0300, Canan Talayhan wrote: > [...] > After sending the patch I've turned the patch like below.=20 > (title ,(if title > `,(string-append title " - Guix Data Service") > '("Guix Data Service"))) A little more simplification is possible: `,(string-append title ...) --> (string-append ...) The code `,A after macro-expansion simply becomes A, for every A. To test, you can run ,expand `,(string-append title " something") in a Guile REPL. Also, '("Guix Data Service"))) seems incorrect. The end result if title is #f would be (title ("Guix Data Service")), while I believe you wanted (title "Guix Data Service"). Correct code would be > (title ,(if title > `,(string-append title " - Guix Data Service") > "Guix Data Service")) or alternatively > (title ,(if title > `,(string-append title " - Guix Data Service") > '"Guix Data Service")) or > (title ,(if title > `,(string-append title " - Guix Data Service") > `"Guix Data Service")) I don't know how familiar you are with quasiquote (`), quote (') and unquote (,); it may be worthwhile to look this up in the Guile maual `,(string-append title " - Guix Data Service") I recommend sending e-mails as plain text. One benefit is that plain text doesn't mess up code indentation (at least on e-mail clients using fixed-width fonts for plain text, which seems standard). Greetings, Maxime. --=-bbj9wSHaxbFMV8JE58qB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYHXaJBccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7qZFAP9mJtwGRWW4MhbrpBbnGnOWaqUw SXHClR8E2S7InFixwAD+Iia9+65j2WfFDC5l7KF/s+D2t70c1WyPApyBs7FD6gA= =+A9T -----END PGP SIGNATURE----- --=-bbj9wSHaxbFMV8JE58qB--