all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Bruno Victal <mirai@makinata.eu>
To: 66935@debbugs.gnu.org
Cc: Bruno Victal <mirai@makinata.eu>
Subject: [bug#66935] [PATCH 1/4] services: dovecot: Use make-kill-destructor for action stop.
Date: Sat,  4 Nov 2023 19:05:58 +0000	[thread overview]
Message-ID: <795f0efdf6ad1716a9d3b98589a790855f88391d.1699124200.git.mirai@makinata.eu> (raw)
In-Reply-To: <cover.1699124200.git.mirai@makinata.eu>

* gnu/services/mail.scm (dovecot-shepherd-service): Prefer file-append over
string-append. Prefer shepherd mechanism for issuing stop action.

Change-Id: I6a23fbb70ee4e0a2ba5f8e933e85b97283736f5d
---
 gnu/services/mail.scm | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/gnu/services/mail.scm b/gnu/services/mail.scm
index 12dcc8e71d..b865a67630 100644
--- a/gnu/services/mail.scm
+++ b/gnu/services/mail.scm
@@ -1580,12 +1580,9 @@ (define (dovecot-shepherd-service config)
            (provision '(dovecot))
            (requirement '(pam networking))
            (start #~(make-forkexec-constructor
-                     (list (string-append #$dovecot "/sbin/dovecot")
+                     (list #$(file-append dovecot "/sbin/dovecot")
                            "-F")))
-           (stop #~(lambda _
-                     (invoke #$(file-append dovecot "/sbin/dovecot")
-                             "stop")
-                     #f))))))
+           (stop #~(make-kill-destructor))))))
 
 (define %dovecot-pam-services
   (list (unix-pam-service "dovecot")))
-- 
2.41.0





  reply	other threads:[~2023-11-04 19:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-04 19:03 [bug#66935] [PATCH 0/4] Dovecot service refactor Bruno Victal
2023-11-04 19:05 ` Bruno Victal [this message]
2023-11-04 19:05 ` [bug#66935] [PATCH 2/4] services: dovecot: Add 'reopen action Bruno Victal
2023-11-04 19:06 ` [bug#66935] [PATCH 3/4] services: dovecot: Refactor serialization process Bruno Victal
2023-11-04 19:06 ` [bug#66935] [PATCH 4/4] services: dovecot: Fix incorrect type for ssl? field Bruno Victal
2023-11-05 18:03   ` Herman Rimm via Guix-patches via
2023-11-06 14:52     ` Bruno Victal
2023-11-06 15:43       ` Clément Lassieur
2023-11-07 14:52         ` Bruno Victal
2023-11-06 21:36       ` Clément Lassieur
2023-11-07 15:04 ` [bug#66935] [PATCH v2 1/4] services: dovecot: Use make-kill-destructor for action stop Bruno Victal
2023-11-07 15:04 ` [bug#66935] [PATCH v2 2/4] services: dovecot: Add 'reopen action Bruno Victal
2023-11-07 15:04 ` [bug#66935] [PATCH v2 3/4] services: dovecot: Refactor serialization process Bruno Victal
2023-11-07 15:04 ` [bug#66935] [PATCH v2 4/4] services: dovecot: Fix ssl? description in inet-listener-configuration Bruno Victal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=795f0efdf6ad1716a9d3b98589a790855f88391d.1699124200.git.mirai@makinata.eu \
    --to=mirai@makinata.eu \
    --cc=66935@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.