From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Soo Subject: Re: Plan for fish shell in Guix. Date: Mon, 21 Jan 2019 16:30:50 -0800 Message-ID: <7931354B-E366-433E-B3CA-D6A0B8A90A71@asu.edu> References: <87imz0x1i3.fsf@gmail.com> <871s562yyc.fsf@disroot.org> Mime-Version: 1.0 (1.0) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([209.51.188.92]:57962) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gljxw-0000ll-PK for guix-devel@gnu.org; Mon, 21 Jan 2019 19:30:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gljxv-0006mb-U9 for guix-devel@gnu.org; Mon, 21 Jan 2019 19:30:56 -0500 Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]:38111) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gljxv-0006kz-92 for guix-devel@gnu.org; Mon, 21 Jan 2019 19:30:55 -0500 Received: by mail-pf1-x435.google.com with SMTP id q1so10857383pfi.5 for ; Mon, 21 Jan 2019 16:30:54 -0800 (PST) In-Reply-To: <871s562yyc.fsf@disroot.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Meiyo Peng Cc: guix-devel@gnu.org Hello, I just have one issue with the patch so far: I can=E2=80=99t seem to unset a= n abbreviation. An old configuration file seems to be =E2=80=9Csticking=E2=80= =9D around for lack of better term. Otherwise, good stuff! John > On Jan 21, 2019, at 12:32 AM, Meiyo Peng wrote: >=20 > Hello everyone, >=20 > Thank you for your patience. >=20 > I investigated the problem and chose to parse /etc/profile from fish > rather than generate separate configuration files for fish. I think > this will make the Guix project easier to maintain in the future. >=20 > I looked NixOS's solution. They choose this approach too, but their > patch is more complex. I implemented my patch in a minimalistic manner. >=20 > The patch has been sent to guix-patches@gnu.org: > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D34153 >=20 > I set fish as my login shell and every thing is working well. Please > try the patch and report bugs if you are interested. >=20 > Thanks. >=20 >=20 > -- > Meiyo Peng > https://www.pengmeiyu.com/ >=20