all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo Prikler <leo.prikler@student.tugraz.at>
To: jgart <jgart@dismail.de>, 46699@debbugs.gnu.org
Cc: rg@raghavgururajan.name, LibreMiami <packaging-guix@libremiami.org>
Subject: [bug#46699] [PATCH] gnu: mumble: Update to 1.3.4.
Date: Mon, 22 Feb 2021 20:28:37 +0100	[thread overview]
Message-ID: <78b3b851db5f4b2057ef8216697138744822fb2b.camel@student.tugraz.at> (raw)
In-Reply-To: <2cc84bcd0e2e150ceab659ad818bbb57@dismail.de>

Hi jgart,

Am Montag, den 22.02.2021, 19:09 +0000 schrieb jgart:
> Hi Leo,
> 
> > IIRC, the correct tag would be Co-authored-by.
> 
> I attached the updated patch with your suggestions.
> 
> > These lines appear to be noise, some of them definitely are.
> 
> Raghav thinks these might have been introduced by indent.el
> 
> How would you suggest to remove them?
You can select the lines you actually wish to commit through `git
commit -p` or use any other tool to do the trick (e.g. Magit or gitg). 
indent.el is a bit of a hammer.  If you don't actively edit code, that
has wrong indentation, it's wiser to just indent your portions with
Emacs.

> > Are perl and ruby really required? If so, what for?
> 
> They are for the 'patch-shebangs phase.
And why do you care about those shebangs?  Are any of those programs
patched by that phase run at any point during build?

Regards,
Leo





  reply	other threads:[~2021-02-22 19:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-22  0:59 [bug#46699] [PATCH] gnu: mumble: Update to 1.3.4 jgart via Guix-patches via
2021-02-22 16:18 ` Leo Prikler
2021-02-22 19:09 ` jgart via Guix-patches via
2021-02-22 19:28   ` Leo Prikler [this message]
2021-03-06 16:22 ` [bug#46699] [PATCH 1/2] " jgart via Guix-patches via
2021-03-06 16:35   ` Leo Prikler
2021-03-06 17:38     ` Leo Prikler
2021-03-07  4:22     ` jgart via Guix-patches via
2021-03-07  8:09       ` bug#46699: " Leo Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=78b3b851db5f4b2057ef8216697138744822fb2b.camel@student.tugraz.at \
    --to=leo.prikler@student.tugraz.at \
    --cc=46699@debbugs.gnu.org \
    --cc=jgart@dismail.de \
    --cc=packaging-guix@libremiami.org \
    --cc=rg@raghavgururajan.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.