From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id IKNVIhkaj2EnFAAAgWs5BA (envelope-from ) for ; Sat, 13 Nov 2021 02:51:21 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id +EJIHRkaj2G3WQAAB5/wlQ (envelope-from ) for ; Sat, 13 Nov 2021 01:51:21 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C7C7913981 for ; Sat, 13 Nov 2021 02:51:20 +0100 (CET) Received: from localhost ([::1]:38208 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mliCO-0002rt-1H for larch@yhetil.org; Fri, 12 Nov 2021 20:51:20 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60732) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mliC6-0002ri-Jn for guix-patches@gnu.org; Fri, 12 Nov 2021 20:51:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:34741) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mliC6-0000Au-Bx for guix-patches@gnu.org; Fri, 12 Nov 2021 20:51:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mliC6-00050f-Ax for guix-patches@gnu.org; Fri, 12 Nov 2021 20:51:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51795] [PATCH] gnu: Add imppg Resent-From: Vinicius Monego Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 13 Nov 2021 01:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51795 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Sharlatan Hellseher Cc: 51795@debbugs.gnu.org Received: via spool by 51795-submit@debbugs.gnu.org id=B51795.163676820519179 (code B ref 51795); Sat, 13 Nov 2021 01:51:02 +0000 Received: (at 51795) by debbugs.gnu.org; 13 Nov 2021 01:50:05 +0000 Received: from localhost ([127.0.0.1]:46287 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mliBA-0004zH-Gq for submit@debbugs.gnu.org; Fri, 12 Nov 2021 20:50:04 -0500 Received: from mout01.posteo.de ([185.67.36.65]:38493) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mliB7-0004yh-NI for 51795@debbugs.gnu.org; Fri, 12 Nov 2021 20:50:02 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id D840A240026 for <51795@debbugs.gnu.org>; Sat, 13 Nov 2021 02:49:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1636768195; bh=lzrAHgIlbhCu9mfcTIYTj2Y9mnyaVxpUJVnHxTzHFjc=; h=Subject:From:To:Cc:Date:From; b=FFt4jPcn4twPzgqwrFZcIEsDICo063/NZ1WQ38MzuY6ZVNJby2lcZdAsdWIqj1U0w uWNT5rYyncfr8YJiQJ4rL1EUlO6+m2DQC4o35YGpvlfMl7DTEDUxXhcTn76jYInZKW mL8Hu32G39HhiXRE+3AVUacknqo6NdtQKSkuTeydNKbuW7zPLajgcjKgA/4sZYz7Vu Tz6s6HmkOrRjw7oKa1Gqhys1+gYaz+6YPv6RNA2reuSr84tPWzry3n6YZPQEpU4AR5 z8Y3998U9Im+ujRa52n1IVxXBUrbMFe6c9t6tl7wNmeimMyyf+7Eei1aZlEE18pOZZ stgtc43bysEEg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4HrdgP73gFz6tm4; Sat, 13 Nov 2021 02:49:53 +0100 (CET) Message-ID: <787ad36ea96bc67fae2a016ffbb3e0d5670a1c14.camel@posteo.net> From: Vinicius Monego Date: Sat, 13 Nov 2021 01:49:44 +0000 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1636768281; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=yqz/gLGjV1LscABwpJCO2rQDjS+ZDCwB8P/rJIzn0EY=; b=TtUzdacUkpI8eZaliHKSPaDK5jRMXWQExCfodA2PzMnNLoUQyjIuwDSbDZouocddoujEy5 AOiD1Jvv53g6vjlynaXSq0H1hgcTMy9xgzJyDkjV1pXQFH7DeO2u5pXsy/3pZkDIAnmuIj npegIiZIvNPe0ofQLQOulZUgr+QKfGDOSRPpxAJS0cwNR+PyDg83KulgehnVCcNOpGO3oS 7oz5RPsrAW3p+BONU9TfTsfyDhjeErCbhlujkzfj/PQlraMKMrkj0pKAJjePnoIJrLb9Pc SNJSdPJAbuR6oiRptWCx0Wh8hZS1nuqZ3v/ZfgF/KJ3jzDNM/Idv5CnR/qNeLQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1636768281; a=rsa-sha256; cv=none; b=EqtVhQY5xEEmyJ2MW1bKc6rsXXxPnI830bECtGh/JaCa7WyM9dRULnRDi1nMMFfCyZZJpx qbNT0eH8lxtqFmtNpExyLZOou/nLPtKycoOKMvEiGEbCTVLs2I5RK+o1senfKAx3Ulg5q1 RwAqnsR1CQ9XPPzwK6JXwuxOeqPIufjHZ8WG77qw0BEB6DHPRwYUZWoctoMhI92OYw9N2r 0LJ9hDbUYP2zHFzzMpkXhqPkoB7hsaGJ8i5gYB9SF/xsGRRTP5Lghy5Ymq3KLmFQViC9qj ABidrAbNJa9umAXzIPbF9+qPiK56D5kquEDjP9XOj3MoPBUg8qLsKkRdM+9ewA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=FFt4jPcn; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.93 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=FFt4jPcn; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: C7C7913981 X-Spam-Score: -1.93 X-Migadu-Scanner: scn1.migadu.com X-TUID: qI8hrnwFBWLL Hi Sharlatan, Em sex, 2021-11-12 às 21:21 +0000, Sharlatan Hellseher escreveu: > * gnu/packages/astronomy.scm: (imppg): New variable. > --- >  gnu/packages/astronomy.scm | 53 > ++++++++++++++++++++++++++++++++++++++ >  1 file changed, 53 insertions(+) > > diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm > index fc8959faad..57f62dc24d 100644 > --- a/gnu/packages/astronomy.scm > +++ b/gnu/packages/astronomy.scm > @@ -32,6 +32,7 @@ (define-module (gnu packages astronomy) >    #:use-module (gnu packages) >    #:use-module (gnu packages algebra) >    #:use-module (gnu packages autotools) > +  #:use-module (gnu packages boost) >    #:use-module (gnu packages check) >    #:use-module (gnu packages compression) >    #:use-module (gnu packages curl) > @@ -56,6 +57,7 @@ (define-module (gnu packages astronomy) >    #:use-module (gnu packages qt) >    #:use-module (gnu packages version-control) >    #:use-module (gnu packages video) > +  #:use-module (gnu packages wxwidgets) >    #:use-module (gnu packages xiph) >    #:use-module (gnu packages xml) >    #:use-module (gnu packages xorg) > @@ -986,6 +988,57 @@ (define-public sgp4 >  It can be used to calculate the trajectory of satellites.") >        (license license:asl2.0)))) >   > +(define-public imppg > +  (package > +    (name "imppg") > +    (version "0.6.4") > +    (source > +     (origin > +       (method git-fetch) > +       (uri (git-reference > +             (url (string-append > "https://github.com/GreatAttractor/" name)) AFAIK we don't use 'name' in the url anymore, it should be hardcoded. > +             (commit (string-append "v" version)))) > +       (file-name (git-file-name name version)) > +       (sha256 > +        (base32 > "04synbmyz0hkipl1cdc26nr42r57v494yjw8pi4jx0jrxrawgj9h")))) > +    (build-system cmake-build-system) > +    (arguments > +     `(#:tests? #f ; No test provided > +       #:phases > +       (modify-phases %standard-phases > +         (replace 'configure > +           (lambda* (#:key outputs #:allow-other-keys) > +             (mkdir-p "build") > +             (chdir "build") > +             (invoke > +              "cmake" > +              "-G" "Unix Makefiles" > +              "-DCMAKE_BUILD_TYPE=Release" > +              (string-append "-DCMAKE_INSTALL_PREFIX=" (assoc-ref > outputs "out")) > +              "..")))))) This is unusual. Why are we overriding the configure phase? I could build the package just fine with the standard phase. CMAKE_BUILD_TYPE can be set to Release using '#:build-type "Release"'. Other CMake variables can be changed in #:configure-flags. AFAIK Guix also avoids setting CMAKE_BUILD_TYPE to "Release" without a good reason, such as debug symbols being too large. > +    (native-inputs > +     `(("boost" ,boost) > +       ("pkg-config" ,pkg-config))) > +    (inputs > +     `(("cfitsio" ,cfitsio) > +       ("freeimage" ,freeimage) > +       ("glew" ,glew) > +       ("wxwidgets" ,wxwidgets))) > +    (home-page "https://github.com/GreatAttractor/imppg") > +    (synopsis "Astronomical Image Post-Proccessor (ImPPG)") > +    (description > +     "ImPPG performs Lucy-Richardson deconvolution, unsharp masking, > brightness > +normalization and tone curve adjustment.  It can also apply > previously specified > +processing settings to multiple images.  All operations are > performed using > +32-bit floating-point arithmetic. > + > +Supported input formats: FITS, BMP, JPEG, PNG, TIFF (most of bit > depths and > +compression methods), TGA and more.  Images are processed in > grayscale and can be > +saved as: BMP 8-bit; PNG 8-bit; TIFF 8-bit, 16-bit, 32-bit floating- > point (no > +compression, LZW- or ZIP-compressed), FITS 8-bit, 16-bit, 32-bit > +floating-point.") Description exceeded 78 columns in 3 lines. > +     (license license:gpl3+))) > + >  (define-public indi >    (package >      (name "indi") LGTM otherwise!