all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Jonas Møller" <jonas@moller.systems>
To: guix-devel@gnu.org
Subject: Why does Guix duplicate dependency versions from Cargo.toml?
Date: Mon, 21 Aug 2023 19:23:48 +0000	[thread overview]
Message-ID: <77a0c1d6-1a3d-473b-b86d-1ff17cefe9de@moller.systems> (raw)

[-- Attachment #1: Type: text/plain, Size: 716 bytes --]

Hi Guix! Why does cargo-build-system need #:cargo-inputs specified in the package definition? This seems like a big mistake for a couple of reasons.

- It is completely redundant, it should match what is in Cargo.toml. I know `guix import crate` exists to automate this process, but I don't understand the rationale for duplicating this information.
- It is bad practice for Guix to override Cargo.lock if it exists, this means that Guix is building a different binary to the one the developers of the packaged Rust application are seeing on their end, this is a much bigger problem. This can and will cause spurious build failures, or bugs that are unknown to the developers of the Rust programs that Guix packages.

[-- Attachment #2: Type: text/html, Size: 1065 bytes --]

             reply	other threads:[~2023-08-23 10:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-21 19:23 Jonas Møller [this message]
2023-08-24  7:05 ` Why does Guix duplicate dependency versions from Cargo.toml? (
2023-08-24 10:14   ` Jonas Møller
2023-08-24 19:40     ` (
2023-08-25  9:13 ` Zhu Zihao
2023-08-25 14:56   ` (
2023-08-26 14:08     ` Andreas Enge
2023-08-27 11:18 ` Attila Lendvai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=77a0c1d6-1a3d-473b-b86d-1ff17cefe9de@moller.systems \
    --to=jonas@moller.systems \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.