From: Lars Bilke <lars.bilke@ufz.de>
To: ludo@gnu.org
Cc: 67822@debbugs.gnu.org
Subject: [bug#67822] [PATCH v4] gnu: maths: petsc: Reduce closure size.
Date: Tue, 27 Feb 2024 08:49:56 +0100 [thread overview]
Message-ID: <77AE81C2-3C38-4FBC-AA26-E8C1759F480B@ufz.de> (raw)
In-Reply-To: <a2c44dd68bd3b7ce4ebad81cf22c667caebc586e.1704824104.git.lars.bilke@ufz.de>
[-- Attachment #1: Type: text/plain, Size: 2246 bytes --]
Dear Ludo,
may I kindly ask for another review here? I have implemented the suggestions in v4 and would like to benefit from the size reduction as I am preparing some container-based computations on several HPC clusters which do not have Guix installed ( yet ;-) ).
Thanks a lot!
Lars
On 9 Jan 2024, at 19:15, Lars Bilke wrote:
> Reduces closure size by around 350 MB by removing refernces to build
> dependencies (e.g. gcc).
>
> New ion v4:
>
> Used proposed :graph: syntax.
> Also removed gfortran reference.
>
> Change-Id: I2e6900747b2118546f0a39ceb109b3f2f90e6949
> ---
> gnu/packages/maths.scm | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
> index adc7beb655..7dc93ce8ee 100644
> --- a/gnu/packages/maths.scm
> +++ b/gnu/packages/maths.scm
> @@ -3484,8 +3484,21 @@ (define-public petsc
> '("configure.log" "make.log" "gmake.log"
> "test.log" "error.log" "RDict.db"
> "PETScBuildInternal.cmake"
> + "configure-hash"
> ;; Once installed, should uninstall with Guix
> "uninstall.py")))))
> + (add-after 'clean-install 'clear-reference-to-compiler
> + (lambda* (#:key inputs outputs #:allow-other-keys)
> + ;; Do not retain a reference to GCC and other build only inputs.
> + (let ((out (assoc-ref outputs "out")))
> + (substitute* (string-append out "/lib/petsc/conf/petscvariables")
> + (("([[:graph:]]+)/bin/gcc") "gcc")
> + (("([[:graph:]]+)/bin/g\\+\\+") "g++")
> + (("([[:graph:]]+)/bin/make") "make")
> + (("([[:graph:]]+)/bin/diff") "diff")
> + (("([[:graph:]]+)/bin/sed") "sed")
> + (("([[:graph:]]+)/bin/gfortran") "gfortran")
> + ))))
> (add-after 'install 'move-examples
> (lambda* (#:key outputs #:allow-other-keys)
> (let* ((out (assoc-ref outputs "out"))
>
> base-commit: a1a645337a76cf5fb55d20ee694fcb6a52fcf11b
> --
> 2.43.0
[-- Attachment #2: S/MIME digital signature --]
[-- Type: application/pkcs7-signature, Size: 5435 bytes --]
next prev parent reply other threads:[~2024-02-27 7:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 12:56 [bug#67822] [PATCH] gnu: maths: petsc: Reduce closure size Lars Bilke
2023-12-14 14:53 ` [bug#67822] [PATCH v2] " Lars Bilke
2023-12-15 8:55 ` [bug#67822] [PATCH v3] " Lars Bilke
2024-01-05 11:08 ` Ludovic Courtès
2024-01-05 11:52 ` Lars Bilke
2024-01-07 9:09 ` Efraim Flashner
2024-01-08 17:20 ` Ludovic Courtès
2024-01-09 18:15 ` [bug#67822] [PATCH v4] " Lars Bilke
2024-02-27 7:49 ` Lars Bilke [this message]
2024-02-27 9:50 ` bug#67822: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77AE81C2-3C38-4FBC-AA26-E8C1759F480B@ufz.de \
--to=lars.bilke@ufz.de \
--cc=67822@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.