From mboxrd@z Thu Jan 1 00:00:00 1970 From: julien lepiller Subject: Re: The usability of Guix configurations Date: Tue, 07 Nov 2017 14:13:04 +0100 Message-ID: <777f3534955ec61a520ff5f9b7054673@lepiller.eu> References: <868tfjw4is.fsf@gmail.com> <20171106221621.GA2534@jasmine.lan> <86o9oex34v.fsf@gmail.com> <779b1b6f2043e03a2f911981142e7740@lepiller.eu> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=_131fac000e4fda99b3cde0f2372a0d47" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57574) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eC3gm-0001MT-H4 for guix-devel@gnu.org; Tue, 07 Nov 2017 08:13:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eC3gh-0004wd-GV for guix-devel@gnu.org; Tue, 07 Nov 2017 08:13:12 -0500 Received: from lepiller.eu ([2a00:5884:8208::1]:36772) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eC3gh-0004vs-73 for guix-devel@gnu.org; Tue, 07 Nov 2017 08:13:07 -0500 Received: from webmail.lepiller.eu (static-176-182-42-79.ncc.abo.bbox.fr [176.182.42.79]) by lepiller.eu (OpenSMTPD) with ESMTPSA id 9ccfbe3a (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128:NO) for ; Tue, 7 Nov 2017 13:14:54 +0000 (UTC) In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org --=_131fac000e4fda99b3cde0f2372a0d47 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8; format=flowed Le 2017-11-07 13:52, Hartmut Goebel a écrit : > Am 07.11.2017 um 12:05 schrieb julien lepiller: >> Since we encourage users to use use-package-modules etc, I think it's >> better >> to catch this error and explain it to users as soon as it happens. >> It's more >> friendly for users than a troubleshooting section in the manual. > > +1 > Thanks for proposing a patch so quickly! > >> Package module "abc" does not exist. >> ERROR: In procedure scm-error: >> ERROR: check "use-package-modules" line in your configuration. > > For me this looks confusing: The actual error message is not prefixed > by > "ERROR:". Also (nitpicking) the explanation could by a bit more > verbose. > Like this: > > ERROR: In procedure scm-error: > ERROR: Package module "abc" does not exist. > ERROR: Please check the "use-package-modules" line in your > configuration. > > It would even be better is the fist line would not refer to "procedure > scm-error", but to the config actually processed (and even the line in > there). But nevertheless this patch is a big improvement already. This new version outputs something like this : guix system: error: failed to load 'vm-image.tmpl': vm-image.tmpl:6:0: vm-image.tmpl:6:0: Package module "abc" does not exist. Check the "use-package-modules" line in your configuration. Previously I tested in in the REPL, hence no filename. This time I modified vm-image.tmpl to add an "abc" package, and ran "guix system vm vm-image.tmpl". --=_131fac000e4fda99b3cde0f2372a0d47 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0001-Catch-use-modules-errors-in-configuration.patch Content-Disposition: attachment; filename=0001-Catch-use-modules-errors-in-configuration.patch; size=1767 RnJvbSAzMzQ4NTJlNWNkN2Y1MjZjOTNiMmFkNzA2MWJkNTZjMDMyNmQxMzZmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKdWxpZW4gTGVwaWxsZXIgPGp1bGllbkBsZXBpbGxlci5ldT4K RGF0ZTogVHVlLCA3IE5vdiAyMDE3IDExOjQ2OjM0ICswMTAwClN1YmplY3Q6IFtQQVRDSF0gQ2F0 Y2ggdXNlLW1vZHVsZXMgZXJyb3JzIGluIGNvbmZpZ3VyYXRpb24uCgoqIGdudS5zY20gKHVzZS1w YWNrYWdlLW1vZHVsZXMsIHVzZS1zZXJ2aWNlLW1vZHVsZXMsIHVzZS1zeXN0ZW0tbW9kdWxlcyk6 CkNhdGNoIHVzZS1tb2R1bGVzIGVycm9ycyBhbmQgc2hvdyBhIHNtYWxsIGV4cGxhbmF0aW9uIGFi b3V0IGl0LgotLS0KIGdudS5zY20gfCAyNSArKysrKysrKysrKysrKysrKysrKysrLS0tCiAxIGZp bGUgY2hhbmdlZCwgMjIgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg YS9nbnUuc2NtIGIvZ251LnNjbQppbmRleCA5MTNjZTYxNjAuLjNkZTA0ZmQ4YSAxMDA2NDQKLS0t IGEvZ251LnNjbQorKysgYi9nbnUuc2NtCkBAIC01MiwxMyArNTIsMzIgQEAKICAgICAgICAgICAg ICAgICAgIChtb2R1bGUtdXNlISBpIChyZXNvbHZlLWludGVyZmFjZSBtKSkpKQogICAgICAgICAg ICAgICAlcHVibGljLW1vZHVsZXMpKSkKIAorKGRlZmluZSAoaW1wb3J0LWVycm9yIHR5cGUgbW9k dWxlIHN5bnRheCkKKyAgKGVycm9yIChzdHJpbmctYXBwZW5kCisgICAgICAgICAgIHR5cGUgIiBt b2R1bGUgXCIiIG1vZHVsZSAiXCIgZG9lcyBub3QgZXhpc3QuXG4iCisgICAgICAgICAgICJDaGVj ayB0aGUgXCIiIHN5bnRheCAiXCIgbGluZSBpbiB5b3VyIGNvbmZpZ3VyYXRpb24uIikpKQorCiAo ZGVmaW5lLXN5bnRheC1ydWxlICh1c2UtcGFja2FnZS1tb2R1bGVzIG1vZHVsZSAuLi4pCi0gICh1 c2UtbW9kdWxlcyAoZ251IHBhY2thZ2VzIG1vZHVsZSkgLi4uKSkKKyAgKGJlZ2luCisgICAgKGNh dGNoICN0IChsYW1iZGEgKCkgKHVzZS1tb2R1bGVzIChnbnUgcGFja2FnZXMgbW9kdWxlKSkpCisg ICAgICAgICAgIChsYW1iZGEgXworICAgICAgICAgICAgIChpbXBvcnQtZXJyb3IgIlBhY2thZ2Ui IChzeW1ib2wtPnN0cmluZyAnbW9kdWxlKSAidXNlLXBhY2thZ2UtbW9kdWxlcyIpKSkKKyAgICAu Li4pKQogCiAoZGVmaW5lLXN5bnRheC1ydWxlICh1c2Utc2VydmljZS1tb2R1bGVzIG1vZHVsZSAu Li4pCi0gICh1c2UtbW9kdWxlcyAoZ251IHNlcnZpY2VzIG1vZHVsZSkgLi4uKSkKKyAgKGJlZ2lu CisgICAgKGNhdGNoICN0IChsYW1iZGEgKCkgKHVzZS1tb2R1bGVzIChnbnUgc2VydmljZXMgbW9k dWxlKSkpCisgICAgICAgICAgIChsYW1iZGEgXworICAgICAgICAgICAgIChpbXBvcnQtZXJyb3Ig IlNlcnZpY2UiIChzeW1ib2wtPnN0cmluZyAnbW9kdWxlKSAidXNlLXNlcnZpY2UtbW9kdWxlcyIp KSkKKyAgICAuLi4pKQorCiAKIChkZWZpbmUtc3ludGF4LXJ1bGUgKHVzZS1zeXN0ZW0tbW9kdWxl cyBtb2R1bGUgLi4uKQotICAodXNlLW1vZHVsZXMgKGdudSBzeXN0ZW0gbW9kdWxlKSAuLi4pKQor ICAoYmVnaW4KKyAgICAoY2F0Y2ggI3QgKGxhbWJkYSAoKSAodXNlLW1vZHVsZXMgKGdudSBzeXN0 ZW0gbW9kdWxlKSkpCisgICAgICAgICAgIChsYW1iZGEgXworICAgICAgICAgICAgIChpbXBvcnQt ZXJyb3IgIlN5c3RlbSIgKHN5bWJvbC0+c3RyaW5nICdtb2R1bGUpICJ1c2Utc3lzdGVtLW1vZHVs ZXMiKSkpCisgICAgLi4uKSkKKwogCiA7OzsgZ251LnNjbSBlbmRzIGhlcmUKLS0gCjIuMTMuNgoK --=_131fac000e4fda99b3cde0f2372a0d47--