From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id A5WJHWR8xmAjEQAAgWs5BA (envelope-from ) for ; Sun, 13 Jun 2021 23:45:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 1xR+GGR8xmCsIgAAbx9fmQ (envelope-from ) for ; Sun, 13 Jun 2021 21:45:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id ED565E07C for ; Sun, 13 Jun 2021 23:45:07 +0200 (CEST) Received: from localhost ([::1]:59304 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lsXuk-000835-ML for larch@yhetil.org; Sun, 13 Jun 2021 17:45:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36846) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lsXug-00082n-E3 for guix-patches@gnu.org; Sun, 13 Jun 2021 17:45:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:32964) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lsXug-0003Vo-3N for guix-patches@gnu.org; Sun, 13 Jun 2021 17:45:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lsXuf-0003mv-W6 for guix-patches@gnu.org; Sun, 13 Jun 2021 17:45:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48924] Add systemd Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 13 Jun 2021 21:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48924 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Tony O , leo@famulari.name, ludo@gnu.org Cc: 48924@debbugs.gnu.org, efraim@flashner.co.il Received: via spool by 48924-submit@debbugs.gnu.org id=B48924.162362069314531 (code B ref 48924); Sun, 13 Jun 2021 21:45:01 +0000 Received: (at 48924) by debbugs.gnu.org; 13 Jun 2021 21:44:53 +0000 Received: from localhost ([127.0.0.1]:44510 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lsXuX-0003mJ-EZ for submit@debbugs.gnu.org; Sun, 13 Jun 2021 17:44:53 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:10821) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lsXuV-0003mA-MJ for 48924@debbugs.gnu.org; Sun, 13 Jun 2021 17:44:52 -0400 Received: from nijino.local (62-116-34-49.adsl.highway.telekom.at [62.116.34.49]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4G37Qm40LJz1LBRt; Sun, 13 Jun 2021 23:44:48 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4G37Qm40LJz1LBRt DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1623620689; bh=DhUPnP9Dl0/eiI4d52BJ2vzCNS0P9KZ4/ZZtzw4VOfo=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=DO1snV+95pcmmDsqF0rKy6eqCN6IZFGIxW/fuAFqUIGqCUkP3z+MrEpI3eF5COVBi B7KXPIUtXXKt2NLoLvCsWli9wcvrhuuU7Q3sP7ze6wEW30KR4VoY7n1xrnAgdAShEG IPWfvhZ0wIKSgm71DfqgiFR/eU2AmZqOrPcNkUAI= Message-ID: <7519d8b43228f04281990bebda04ca785563b21f.camel@student.tugraz.at> From: Leo Prikler Date: Sun, 13 Jun 2021 23:44:47 +0200 In-Reply-To: References: <8c9f7f3961274fd2fef3b715a0ff8b21026bb283.camel@student.tugraz.at> <87h7i45p9y.fsf@gnu.org> <6bb174687e5520154f4cb0fefe8306158d594c01.camel@student.tugraz.at> <87sg1m2jjl.fsf@gnu.org> <7a89e12d172b71e524498ddfbc8899ab2efe4f0c.camel@student.tugraz.at> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1623620708; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=DhUPnP9Dl0/eiI4d52BJ2vzCNS0P9KZ4/ZZtzw4VOfo=; b=OJ+HE0ViiCV6WT9Iq1TMjTCfnttLxyg2fDQlHaW8ao2/G3UxsaT4iteSGQ/olXP+QJDAGN dLQ5/2+p1kBLImaGgPRh17u0Tz6CdTCmMBm9HdF0Sas6FPzix1cUwndK5YOC+uf2xodC1A 4q5ybEycsEb1wfYIR43Ys9iJeM40XEAkObhSHjxNpcWGrLRxEZ2qWJmLib74hd83WIWL/f 5t6evkWh/SoipD7gUbcvyDDTU2pOChpiAPH6TbfXuoX1I3K1o7omegwHsnwVL9l5uNr/is AlGaA4OtzeVQrJx952lWH/bujIFWaxiaytns/QtkOAotylmIR0SoF7KoLfJ2cg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1623620708; a=rsa-sha256; cv=none; b=R4EWyCegZ0GV02P7BJL0jXGT03WGZiaMwC457gOPFOG89al0FZ1KVKfMSmJ/kcJ6seQ/SC tjLG4Cl02qbCcllEgHJmMGICWam++ViXe3hMw0mov575P1scDMspigHGOfg0x/T4hNuGDA nl9UktGIyIK6r2PTPFhyu32wVlL8PXevI5kFujuRbo7OcCyU0X26vGhD3JifCma0deE2mm 9LsWRUbXOf4qUMtk1QClzovVsyw6xI1eZ4GqQ4YlAdUPuNxMMSFJfn5DBRBJv4KDwqI/kY rDqK0zoW4EHc3BPa2GRGRJRJip6OiEMjT1gU8hY8LW+DK3FG37YzpaNoGGgcLQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=DO1snV+9; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.32 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=DO1snV+9; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: ED565E07C X-Spam-Score: -1.32 X-Migadu-Scanner: scn1.migadu.com X-TUID: JquzIWwiHE8w Am Sonntag, den 13.06.2021, 19:56 +0000 schrieb Tony O: > Okay, I was going by the similarity to the nix package, but if you > require concrete proof then I just built it without the sandbox and > with my kernel supporting cgroups. Exactly 15 test fail, out of > nearly 400. Each of them by best approximation due to binaries not in > scope and/or systemd not being PID1 (as is repeatedly echoed on the > error log). > > If those 15 tests pose a concrete issue to you, I would consider > fixing them, but only with the guarantee that the result end up in > guix. As it stands disposition seems to be to not merge this, so I'll > reserve the effort. 15/400 tests failing sounds somewhat reasonable, especially if we can explain their failure modes (e.g. stuff like not being PID1). Even if we add the other tests, that require cgroups on top, that'd be fine, but we'd have to be able to display all that info in a meaningful fashion like ;; these tests want systemd to be PID1 "foo" "bar" "baz" ;; these tests require cgroups "spam" "ham" "eggs" ;; these are missing libquux "i" "ran" "out" "of" "funny" "variable" "names" However, this is somewhat different from the package description at hand, which lacks those explanations. The reference point is of course the thing that's compiled within the sandbox, not anything without. Having most tests pass when compiling stuff "normally" with Guix is perhaps a good indicator, that at least compiling works, but it's really just that. Finally – and this might be my ignorance of the systemd test suite speaking, so ignore me if I say something stupid – just because we have a test coverage of let's say 90% or even 100%, doesn't mean that the installed binaries will still be able to work. There is a large potential for bugs to sneek in, e.g. through an insufficient wrap phase, so for software like systemd, we should be able to do some trivial tasks, e.g. `systemctl start hello-world` with a systemd, that has not claimed PID1. TL;DR: the plan is to - Get the sandboxed package to match up as closely as you can get to the non-sandboxed one w.r.t. testing. - Document how the remaining disabled tests fail. - Prove, that components of systemd run when invoked directly from the store/from within a suitable environment. It is probably still a somewhat long and bumpy road, but in my personal opinion one that has an end. @lfam, ludo, efraim: WDYT? Regards, Leo