all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: gemmaro <gemmaro.dev@gmail.com>, 72006@debbugs.gnu.org
Cc: Katherine Cox-Buday <cox.katherine.e+guix@gmail.com>,
	Andrew Tropin <andrew@trop.in>
Subject: [bug#72006] [PATCH] gnu: emacs-empv: Update to 4.3.0 revision 2.
Date: Tue, 09 Jul 2024 19:09:43 +0200	[thread overview]
Message-ID: <74b9eff03c9c16af1ee9ccbafd18993be9a9db48.camel@gmail.com> (raw)
In-Reply-To: <78593d86ffd76ef7f1f5fc5f5ab8a6e820acfad4.1720525583.git.gemmaro.dev@gmail.com>

Am Dienstag, dem 09.07.2024 um 20:46 +0900 schrieb gemmaro:
> * gnu/packages/emacs-xyz.scm (emacs-empv): Update to 4.3.0 revision
> 2.
You don't need to bump the revision to update a recipe.
> [arguments]: Add a phase to set default binaries for fd and mpv.
> [inputs]: Add fd and mpv.
> [propagated-inputs]: Add emacs-consult.
> 
> Change-Id: I0e627d3b3ec3e5515ff7da9cd601713840e2a9c7
> ---
>  gnu/packages/emacs-xyz.scm | 13 +++++++++++--
>  1 file changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 45225f2051..d7b25af21c 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -3751,7 +3751,7 @@ (define-public emacs-emprise
>  
>  (define-public emacs-empv
>    (let ((commit "8cc9b0a425b6989d30f91bf90e9b09bd00581f07")
> -        (revision "1"))
> +        (revision "2"))
>      (package
>        (name "emacs-empv")
>        (version (git-version "4.3.0" revision commit))
> @@ -3766,7 +3766,16 @@ (define-public emacs-empv
>            (base32
>            
> "06dphwj9vi39dbpif3kzp6azs80klh13s9l22a6ddz91kmds2myy"))))
>        (build-system emacs-build-system)
> -      (propagated-inputs (list emacs-compat emacs-s))
> +      (arguments
> +       (list
> +        #:phases #~(modify-phases %standard-phases
> +                     (add-after 'unpack 'set-default-binaries
> +                       (lambda* (#:key inputs #:allow-other-keys)
> +                         (emacs-substitute-variables "empv.el"
> +                           ("empv-fd-binary" (search-input-file
> inputs "/bin/fd"))
> +                           ("empv-mpv-binary" (search-input-file
> inputs "/bin/mpv"))))))))
> +      (inputs (list fd mpv))
> +      (propagated-inputs (list emacs-compat emacs-consult emacs-s))
>        (home-page "https://github.com/isamert/empv.el")
>        (synopsis
>         "Emacs multimedia player, media library manager, YouTube
> frontend")
Otherwise LGTM.

      parent reply	other threads:[~2024-07-09 17:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-09 11:46 [bug#72006] [PATCH] gnu: emacs-empv: Update to 4.3.0 revision 2 gemmaro
2024-07-09 13:10 ` bug#72006: " Nicolas Goaziou via Guix-patches via
2024-07-09 17:09 ` Liliana Marie Prikler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74b9eff03c9c16af1ee9ccbafd18993be9a9db48.camel@gmail.com \
    --to=liliana.prikler@gmail.com \
    --cc=72006@debbugs.gnu.org \
    --cc=andrew@trop.in \
    --cc=cox.katherine.e+guix@gmail.com \
    --cc=gemmaro.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.