From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 8PbDHXWlC2O11gAAbAwnHQ (envelope-from ) for ; Sun, 28 Aug 2022 19:27:17 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id +Ae6HXWlC2OloAAAauVa8A (envelope-from ) for ; Sun, 28 Aug 2022 19:27:17 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1BA2C43F20 for ; Sun, 28 Aug 2022 19:27:17 +0200 (CEST) Received: from localhost ([::1]:48272 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oSM43-0003LJ-Jx for larch@yhetil.org; Sun, 28 Aug 2022 13:27:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59426) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oSM3r-0003Kv-Gp for guix-patches@gnu.org; Sun, 28 Aug 2022 13:27:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41598) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oSM3r-0002E5-8e for guix-patches@gnu.org; Sun, 28 Aug 2022 13:27:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oSM3q-00054Z-AZ for guix-patches@gnu.org; Sun, 28 Aug 2022 13:27:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57460] [PATCH 18/20] TEMP REMOVE import: git: Restrict to non-github origins. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 28 Aug 2022 17:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57460 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Hartmut Goebel , 57460@debbugs.gnu.org Received: via spool by 57460-submit@debbugs.gnu.org id=B57460.166170758119449 (code B ref 57460); Sun, 28 Aug 2022 17:27:02 +0000 Received: (at 57460) by debbugs.gnu.org; 28 Aug 2022 17:26:21 +0000 Received: from localhost ([127.0.0.1]:59579 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oSM3B-00053d-7p for submit@debbugs.gnu.org; Sun, 28 Aug 2022 13:26:21 -0400 Received: from mail-ej1-f65.google.com ([209.85.218.65]:36352) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oSM39-00053Q-Cf for 57460@debbugs.gnu.org; Sun, 28 Aug 2022 13:26:19 -0400 Received: by mail-ej1-f65.google.com with SMTP id h5so18675ejb.3 for <57460@debbugs.gnu.org>; Sun, 28 Aug 2022 10:26:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:to:from:subject:message-id:from:to:cc; bh=U33AermzK7/Isdpc3k+TFCaqWsU6f7aDZCmk5slHYBg=; b=j32SDqfFXJGD2ajOp09cJUiQnOL6GAYF0kWUZjxmXPCYLaBQHb7CxI050unkfonDI4 fuOSJcZgof5TbFqIWWSwj6YdqOIBb8wKmqdgiPd9kYxb4/VqiBXoA64rz/629jY4BvC/ AJdD97C4Pk9CYpG1kJQzJ1rVgYVrjzBrQL93c5LqtW2bbOpOExo6/HJOxjPqf4ijKzyJ 4EUOP6ABALzIXCOEfCk+0ps79WA6PX93dH3h6wNTvRrBbh0YuRMCsa9tyKw1HXh4moWc rAZ65re+VVQxTOrZC5jBTneSRcTtrDzT3WRK2EN+mMG1/Cu5B9CV9dp4P+zNhsgQ8Pri s5iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc; bh=U33AermzK7/Isdpc3k+TFCaqWsU6f7aDZCmk5slHYBg=; b=iyyBYhipTUA4XILT5oDivY4tBlRii5/gQRVlWVKAVUAPOLrhxICmNge8bs4kHPhKfP hZdRhLN2pVWVMnsQU/2iyKAuxKl6eBjFMOX6zvrUKND0zRrvky1idI6+qyE+yn+HZePL FE8LiH5b/ODBEwynOVid3vkJloNPDnApyWGCy0/fVRyndC+Q1h8xxbMe2KD4CXAsFXD4 HAltCS9YxHm945bXAdvOH5HC4iJelwlvaahkCl17HCygRpRyaIhftptXmp9mm6CSxmE1 alq+rK0mmiUvI/tVmHZjpDXZB59dmwRHKEB5T1XYkEFCJen3Q1Bw7h/m/+h5ziuaikGM SnGQ== X-Gm-Message-State: ACgBeo0yxJ2F7Nea2iFkG8vnNwEtRt3vlvaxVZ9IdBRCAblBygt0DQle dyuCVsQB9ydog0UCMoFn85Y= X-Google-Smtp-Source: AA6agR7ZgoqcHpcdA1GacZiLMT5UJn0RNYfrqZNukLG+Nh3Cb0f3LtO5kfRqOtcw/Gei2y0Z9I5pWg== X-Received: by 2002:a17:907:6da1:b0:731:6a7a:83c0 with SMTP id sb33-20020a1709076da100b007316a7a83c0mr11335077ejc.473.1661707573286; Sun, 28 Aug 2022 10:26:13 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id b7-20020aa7c907000000b004478e9ab2c5sm4533751edt.69.2022.08.28.10.26.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Aug 2022 10:26:12 -0700 (PDT) Message-ID: <74a0af4d45d36a6b757429ceb181fa8e06392431.camel@gmail.com> From: Liliana Marie Prikler Date: Sun, 28 Aug 2022 19:26:11 +0200 In-Reply-To: <0ba96b5f2dfd841ab080e7a3373b6e335b62fd59.1661691695.git.h.goebel@crazy-compilers.com> References: <0ba96b5f2dfd841ab080e7a3373b6e335b62fd59.1661691695.git.h.goebel@crazy-compilers.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1661707637; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=U33AermzK7/Isdpc3k+TFCaqWsU6f7aDZCmk5slHYBg=; b=SswuWGJMm4slow0P2ZXveMCsGgy1bEDGPxAORkXYHWVlrqDQiEa4N8TRizu8a6GzJk7hZ+ mmYy4eaE8ODuEu0MLdeyvlQUVdErWGbhi+OCjxlIXpqFGx4DX75jN9olu7+OyFTKW3q4LP GVHdNNMcTXrEUMrdaQDk4xfCaVZD5zXr0IWrYRwK1DHLyFR0agosoFDO3Wn6aJKILU55VU aOQ7nWJFp+pji09715t7u9/za+svI6zIzm64qGM81W5hAkc2DK5PEC5U8Hvz14q0hRcgdF ZEarNmXYC3Ub/P4oyuwB9AK+pfYo9G8rcQ/H/QiQde9f2kwRz7nde70a2+NrzA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1661707637; a=rsa-sha256; cv=none; b=Tk6ramOMO/goHC4FgpXTQDH4Ifkv5gkMtiFysAmYFrD9Nl/37ObxxzivBtON5IHS6qes3/ LXs8zFUQUTd/vSTbPYeFqULPhbjS0BJGUiabd2Q3tTev8+f+UhKxDGBHDS2O8hsuu9rf5q 7Z0FA9RyC04qBTraESMZNkrNiMf2rkngUKWHToqaM7cWCdqsGnczf+dHdRD/i2Q6OiQML8 pnn4VH6qJNLs6BCNJN0XyBqYtKWnTRxyPkcLuZGmPATKF1k7x20MAnGYBVsvHTlHMlzS4Z ZP9W10fG735nDTDfu++QpjOp6wJpmpcJtMNkiGiyUg8h2Ma5sTvIL6qyprF0zQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=j32SDqfF; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.20 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=j32SDqfF; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 1BA2C43F20 X-Spam-Score: 6.20 X-Migadu-Scanner: scn1.migadu.com X-TUID: bO//gHblHNwb Am Sonntag, dem 28.08.2022 um 15:18 +0200 schrieb Hartmut Goebel: > Anyhow: Why should the generic-git updater be able to find > a (later) version, if the github updater did not? Because someone at Microsoft could mess up the API in a way that yields empty results while keeping regular git unchanged. I think fallbacks are nice to have, they are already rare enough to find in Guix. > And indeed 'guix refresh --list-updaters' without this change > reported 31.2% for the github updater and 34.9% for the generic-git > updater. With this patch, it's only 3.7% for the generic-git > updater. (Still the sum of the percent-values is 112%, anyhow better > then the 146% prior to this change.) Perhaps instead of generating a lazy sum, we should (via an appropriate option) generate a histogram counting/reporting the packages covered by 0,1,2,... updaters. Cheers