all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Thiago Jung Bauermann via Guix-patches via <guix-patches@gnu.org>
To: Efraim Flashner <efraim@flashner.co.il>, 50091@debbugs.gnu.org
Subject: [bug#50091] [PATCH 20/21] gnu: lz4: Build on riscv64-linux without valgrind.
Date: Tue, 17 Aug 2021 12:26:33 -0300	[thread overview]
Message-ID: <7475923.C8LUpeJmnU@popigai> (raw)
In-Reply-To: <YRuQ927QWYxJq2qw@3900XT>

Hello,

Em terça-feira, 17 de agosto de 2021, às 07:35:35 -03, Efraim Flashner 
escreveu:
> On Tue, Aug 17, 2021 at 01:19:18PM +0300, Efraim Flashner wrote:
> > * gnu/packages/compression.scm (lz4)[native-inputs]: Don't use valgrind
> > when building for riscv64-linux.
> > ---
> > 
> >  gnu/packages/compression.scm | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/gnu/packages/compression.scm
> > b/gnu/packages/compression.scm
> > index 93d517abd5..1803237e6e 100644
> > --- a/gnu/packages/compression.scm
> > +++ b/gnu/packages/compression.scm
> > @@ -819,7 +819,9 @@ decompression of some loosely related file formats
> > used by Microsoft.")> 
> >      (native-inputs
> >      
> >       `(;; For tests.
> >       
> >         ("python" ,python)
> > 
> > -       ("valgrind" ,valgrind)))
> > +       ,@(if (target-riscv?)
> > +           '()
> > +           `(("valgrind" ,valgrind)))))
> > 
> >      (arguments
> >      
> >       `(;; Not designed for parallel testing.
> >       
> >         ;; See
> >         https://github.com/lz4/lz4/issues/957#issuecomment-737419821
> 
> Valgrind added support for riscv64-linux after the last release, but the
> patch isn't easy to backport. I've thought about adding a valgrind-next
> and pulling from a recent commit but I'm not sure it's actually worth
> it.

IMHO, either the commit message or the code would benefit from a note 
mentioning that the current version of Valgrind doesn’t support
riscv64-linux.

-- 
Thanks,
Thiago






  reply	other threads:[~2021-08-17 15:27 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-17 10:10 [bug#50091] [PATCH 00/21] Add riscv64 support Efraim Flashner
2021-08-17 10:18 ` [bug#50091] [PATCH 01/21] utils: Define 'target-riscv?' predicate Efraim Flashner
2021-08-17 10:27   ` Maxime Devos
2021-08-17 10:28     ` Efraim Flashner
2021-08-17 10:30     ` Maxime Devos
2021-08-17 10:19 ` [bug#50091] [PATCH 02/21] gnu: bootstrap: Add support for riscv64-linux Efraim Flashner
2021-08-24 11:53   ` Efraim Flashner
2021-09-23  7:35   ` Efraim Flashner
2021-08-17 10:19 ` [bug#50091] [PATCH 03/21] gnu: gcc-boot0: Use libstdc++-boot0-gcc7 on riscv64-linux Efraim Flashner
2021-08-17 10:19 ` [bug#50091] [PATCH 04/21] gnu: %boot3-inputs: Add missing input Efraim Flashner
2021-08-17 10:29   ` Efraim Flashner
2021-08-17 10:19 ` [bug#50091] [PATCH 05/21] gnu: guile: Fix building on riscv64-linux Efraim Flashner
2021-08-17 10:30   ` Efraim Flashner
2021-08-17 10:44   ` Maxime Devos
2021-08-17 10:56     ` Efraim Flashner
2021-08-17 10:19 ` [bug#50091] [PATCH 06/21] gnu: %final-inputs: Add implied gcc:lib input Efraim Flashner
2021-08-17 10:19 ` [bug#50091] [PATCH 07/21] gnu: bdb: Fix building on riscv64-linux Efraim Flashner
2021-08-17 14:58   ` Thiago Jung Bauermann via Guix-patches via
2021-09-23  7:28     ` Efraim Flashner
2021-09-28  4:01       ` Thiago Jung Bauermann via Guix-patches via
2021-08-17 10:19 ` [bug#50091] [PATCH 08/21] gnu: elfutils: " Efraim Flashner
2021-08-17 10:19 ` [bug#50091] [PATCH 09/21] gnu: pcre: " Efraim Flashner
2021-08-17 10:19 ` [bug#50091] [PATCH 10/21] gnu: openssl: Fix build " Efraim Flashner
2021-08-17 10:19 ` [bug#50091] [PATCH 11/21] gnu: libtool: Fix building " Efraim Flashner
2021-08-17 10:32   ` Efraim Flashner
2021-08-17 10:49   ` Maxime Devos
2021-08-17 10:58     ` Efraim Flashner
2021-08-17 10:19 ` [bug#50091] [PATCH 12/21] gnu: openblas: " Efraim Flashner
2021-08-17 10:19 ` [bug#50091] [PATCH 13/21] gnu: mesa: Add support for riscv64-linux Efraim Flashner
2021-08-17 10:19 ` [bug#50091] [PATCH 14/21] gnu: pcre2: Fix building on riscv64-linux Efraim Flashner
2021-08-17 10:19 ` [bug#50091] [PATCH 15/21] gnu: icu4c: Skip tests " Efraim Flashner
2021-08-17 10:19 ` [bug#50091] [PATCH 16/21] gnu: openblas-ilp64: Add riscv64-linux as a supported architecture Efraim Flashner
2021-08-17 10:19 ` [bug#50091] [PATCH 17/21] gnu: openlibm: Remove riscv64-linux from supported systems Efraim Flashner
2021-08-17 10:19 ` [bug#50091] [PATCH 18/21] gnu: texlive-bin: Fix building on riscv64-linux Efraim Flashner
2021-08-17 10:34   ` Efraim Flashner
2021-08-17 15:15     ` Thiago Jung Bauermann via Guix-patches via
2021-08-17 10:19 ` [bug#50091] [PATCH 19/21] gnu: texlive-updmap.cfg: Update hash Efraim Flashner
2021-08-17 15:23   ` Thiago Jung Bauermann via Guix-patches via
2021-08-18  7:10     ` Efraim Flashner
2021-08-18 10:41       ` Efraim Flashner
2021-08-17 10:19 ` [bug#50091] [PATCH 20/21] gnu: lz4: Build on riscv64-linux without valgrind Efraim Flashner
2021-08-17 10:35   ` Efraim Flashner
2021-08-17 15:26     ` Thiago Jung Bauermann via Guix-patches via [this message]
2021-08-18  9:10       ` Efraim Flashner
2021-08-17 10:19 ` [bug#50091] [PATCH 21/21] gnu: lapack: Fix building on riscv64-linux Efraim Flashner
2021-08-17 19:33 ` [bug#50091] [PATCH 10/21] gnu: openssl: Fix build " Sarah Morgensen
2021-08-18  7:09   ` Efraim Flashner
2021-08-18 10:44     ` Efraim Flashner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7475923.C8LUpeJmnU@popigai \
    --to=guix-patches@gnu.org \
    --cc=50091@debbugs.gnu.org \
    --cc=bauermann@kolabnow.com \
    --cc=efraim@flashner.co.il \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.