Hi,

On Friday, November 18, 2022 8:45:26 AM EST Ludovic Courtès wrote:
> Hi,
> 
> Applied all three patches.  I added trivial tests for
> ‘spdx-string->license’ and changed ‘substring’ to ‘string-drop-right’,
> which I find clearer.
> 

Thanks!

> Philip McGrath <philip@philipmcgrath.com> skribis:
> > +     (and (string-suffix? "+" str)
> > +          ;; We try the form with the + to support deprecated identifiers
> > for +          ;; GNU licenses (see above).  Here, we handle other uses
> > of +. +          (spdx-string->license
> > +           (substring str 0 (- (string-length str) 1)))))))
> 
> I guess we can remove the “+” forms from the alist now?
> 

I think we still want the "+" forms in the alist so that we continue convert 
"GPL-2.0+" as though it were "GPL-2.0-or-later", not "GPL-2.0-only".

Some upstreams probably wrote "GPL-2.0" out of confusion even though they 
intended to allow "any later version" (and maybe even said so in prose), which 
is why the "+" operator was deprecated for GNU licenses.

If upstream wrote "GPL-2.0+", though, that does communicate "or, at your 
option, any later version"; since that's the more compatible case, it seemed 
useful to retain that information when we have it.

Ideally, upstream projects should move away from the deprecated identifiers 
(the Racket tooling I've written will complain), but they still seem to come 
up often enough in the wild to be worth handling as special cases.

-Philip