From: Leo Prikler <leo.prikler@student.tugraz.at>
To: Raghav Gururajan <rg@raghavgururajan.name>, 45889@debbugs.gnu.org
Subject: [bug#45889] Nextcloud Client (v8)
Date: Sat, 13 Feb 2021 22:47:11 +0100 [thread overview]
Message-ID: <73f0495c29ee82c2a16a96cc2825f19bd88b4ab4.camel@student.tugraz.at> (raw)
In-Reply-To: <3c07544c-97fe-88b1-2e80-ec5cfb87d4ec@raghavgururajan.name>
Hi Raghav,
Am Samstag, den 13.02.2021, 15:36 -0500 schrieb Raghav Gururajan:
> Hi Leo!
>
> > Is cmake really needed? I know that meson falls back to cmake if
> > pkg-
> > config fails and also supports output to cmake, but meson/ninja
> > should
> > be the default.
>
> Yes, it is used to generate `.cmake` files inder '[out]/lib/cmake'.
Fair enough.
> > Could you try packaging those for Guix as well?
>
> They don't have dedicated build scripts.
That may be an issue. You might want to check which of those are
perhaps optional, so that you don't need to pull them in. For example
it appears you're also deleting libcrashreporter-qt with no
replacement.
kmessagewidget appears to be a part of KDE core. If anything there is
strictly necessary for building, we should perhaps define a package
variant, that has a slightly patched kmessagewidget. qtlockedfile and
qtsingleapplication appear to be part of [1], a sort of metapackage,
from which you could spawn multiple descriptions. For qtokenizer, I am
really not sure.
> > As with your telegram patch, I personally think the ordering is
> > wrong
> > here.
>
> I changed it in v8.
LGTM.
> > You might want to regexp the middle part in case it is changed.
>
> I could use PKGCONFIG_GETVAR\\(.+\\) but that would conflict with
> other
> PKGCONFIG_GETVAR lines now or in future.
Okay, but you can do something like PKGCONFIG_GETVAR\\(.+
_install_dir\\), assuming that such variables should generally only be
bound once. To be honest, I don't know enough CMake to tell, whether
that is a good idea, however.
> > What does this achieve exactly?
>
> It configures the build-system to install modules in output "out"
> instead of Qt's (input) path.
In that case, the comment should probably read something along the
lines of "Make sure, that <X> is installed under $prefix."
Regards,
Leo
[1] https://github.com/qtproject/qt-solutions
next prev parent reply other threads:[~2021-02-13 21:48 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 10:09 [bug#45889] Nextcloud Desktop Raghav Gururajan
2021-01-16 6:40 ` [bug#45889] Nextcloud Desktop (v2) Raghav Gururajan
2021-01-16 8:33 ` [bug#45889] Nextcloud Desktop (v3) Raghav Gururajan
2021-01-16 10:09 ` [bug#45889] Nextcloud Desktop (v4) Raghav Gururajan
2021-01-16 10:48 ` Nicolò Balzarotti
2021-01-16 14:42 ` Raghav Gururajan
2021-01-16 14:34 ` [bug#45889] Nextcloud Desktop (v5) Raghav Gururajan
2021-01-17 14:44 ` [bug#45889] Nextcloud Client (v6) Raghav Gururajan
2021-01-24 18:45 ` david larsson
2021-02-01 15:07 ` Raghav Gururajan
2021-02-01 15:13 ` [bug#45889] Nextcloud Client (v7) Raghav Gururajan
2021-02-09 10:22 ` Leo Prikler
2021-02-13 20:36 ` [bug#45889] Nextcloud Client (v8) Raghav Gururajan
2021-02-13 21:47 ` Leo Prikler [this message]
2021-02-13 23:54 ` Raghav Gururajan
2021-02-14 0:47 ` [bug#45889] Nextcloud Client (v9) Raghav Gururajan
2021-02-14 10:53 ` [bug#45889] Nextcloud Client (v8) Leo Prikler
2021-02-18 20:23 ` [bug#45889] Nextcloud Client (v10) Raghav Gururajan via Guix-patches via
2021-02-18 22:26 ` Leo Prikler
2021-02-21 17:04 ` Raghav Gururajan via Guix-patches via
2021-02-21 17:45 ` Leo Prikler
2021-02-21 18:09 ` [bug#45889] Nextcloud Client (v11) Raghav Gururajan via Guix-patches via
2021-02-21 18:22 ` Leo Prikler
2021-02-21 18:50 ` [bug#45889] Nextcloud Client (v12) Raghav Gururajan via Guix-patches via
2021-02-21 19:37 ` Leo Prikler
2021-02-22 17:29 ` [bug#45889] Nextcloud Client (v13) Raghav Gururajan via Guix-patches via
2021-02-23 14:27 ` [bug#45889] Nextcloud Client (v14) Raghav Gururajan via Guix-patches via
2021-02-23 17:58 ` Leo Prikler
2021-03-09 6:00 ` [bug#45889] Nextcloud Client (v15) Raghav Gururajan via Guix-patches via
2021-03-09 7:03 ` Leo Prikler
2021-03-09 10:50 ` [bug#45889] Nextcloud Client (v16) Raghav Gururajan via Guix-patches via
2021-03-09 11:39 ` Leo Prikler
2021-03-09 12:29 ` Raghav Gururajan via Guix-patches via
2021-03-09 12:43 ` [bug#45889] Nextcloud Client (v17) Leo Prikler
2021-03-09 15:16 ` [bug#45889] Nextcloud Client (v18) Raghav Gururajan via Guix-patches via
2021-03-09 23:24 ` bug#45889: " Leo Prikler
2021-03-10 3:46 ` [bug#45889] " Raghav Gururajan via Guix-patches via
2021-03-11 6:45 ` Raghav Gururajan via Guix-patches via
2021-03-11 6:49 ` Leo Prikler
2021-03-11 7:44 ` Raghav Gururajan via Guix-patches via
2021-03-12 9:25 ` david larsson
2021-03-12 9:47 ` Raghav Gururajan via Guix-patches via
2021-02-21 18:22 ` [bug#45889] Nextcloud Client (v11) Raghav Gururajan via Guix-patches via
2021-02-09 12:53 ` [bug#45889] Nextcloud Client (v7) Leo Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73f0495c29ee82c2a16a96cc2825f19bd88b4ab4.camel@student.tugraz.at \
--to=leo.prikler@student.tugraz.at \
--cc=45889@debbugs.gnu.org \
--cc=rg@raghavgururajan.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.