From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id iA7wKJuRTGLyaQAAgWs5BA (envelope-from ) for ; Tue, 05 Apr 2022 20:59:39 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id AGagIZuRTGLkgAAAG6o9tA (envelope-from ) for ; Tue, 05 Apr 2022 20:59:39 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2E50DE3DA for ; Tue, 5 Apr 2022 20:59:38 +0200 (CEST) Received: from localhost ([::1]:49336 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nboOu-0000FJ-Oy for larch@yhetil.org; Tue, 05 Apr 2022 14:59:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45444) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nboOM-0000El-Ps for guix-patches@gnu.org; Tue, 05 Apr 2022 14:59:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34082) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nboOM-0001PQ-Gu for guix-patches@gnu.org; Tue, 05 Apr 2022 14:59:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nboOM-0006gu-Fx for guix-patches@gnu.org; Tue, 05 Apr 2022 14:59:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54068] [PATCH] Add xmrig and p2pool Resent-From: Justin Veilleux Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 05 Apr 2022 18:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54068 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch moreinfo To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 54068@debbugs.gnu.org, Maxime Devos Received: via spool by 54068-submit@debbugs.gnu.org id=B54068.164918508725625 (code B ref 54068); Tue, 05 Apr 2022 18:59:02 +0000 Received: (at 54068) by debbugs.gnu.org; 5 Apr 2022 18:58:07 +0000 Received: from localhost ([127.0.0.1]:56212 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nboNT-0006fF-MJ for submit@debbugs.gnu.org; Tue, 05 Apr 2022 14:58:07 -0400 Received: from [37.120.193.124] (port=59656 helo=mail.cock.li) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nboNQ-0006ef-MX for 54068@debbugs.gnu.org; Tue, 05 Apr 2022 14:58:06 -0400 Message-ID: <73ba1436-5434-c771-258d-d3a97f3ff5df@cock.li> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cock.li; s=mail; t=1649185078; bh=yZJ5kjwsvO4lVoMY7qvdtkCHNKC8tBpZXGON5U90mT0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=iXlchcfVP+kx2DeLFKIIpoa24DwrSqMLwB+AIrZoY97RYoXvVqlrn7TRWUAeM4DPz Q2RzFpxYnUe21nqWg9eV6SGCv8Fxckc1jRY6HnH/SfPUfKq+E+DvXUuSGsly1NI8P6 7URRU57ED2wbhrLFnBfO1HSO7UdaT8mqB0xDxtMxFhHP8OO78jcPbE/xa8Da++oVxy yLs5r6+CSwUDr5UJltAt7vmdBIx/vAlWaXDBEDXNqpvnqDN/qLUpV4c2epgFY25BHr qRqvdCm/QHiBM+ZA/19IQXHlOotHL6ZWRL+s7FkmPSdMoUbVLA4kyJaY+9XfLWQ+hV Ds0KOGaR2gCGw== Date: Tue, 5 Apr 2022 14:57:53 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US References: <356b1509-0df9-6579-d440-95bc74c9f2e3@cock.li> <87pmlvmxqq.fsf_-_@gnu.org> From: Justin Veilleux In-Reply-To: <87pmlvmxqq.fsf_-_@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1649185179; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Jra21GtKNelXL0oR4sSrkvka4KY2XKI5T0wLtU9Yy/o=; b=pUUd4+WOgk6spCOkZBsNWgISTcsOWXhNPwLt7jjiAqUJ3qpQR5jhwmtqNC1yKgtJdu2zaq Y1VOJkvupv8UWosatRoBZ5yJqXBCBHJbefGaUlUpBZR8bNeO7kYKziv0H7OV5tbcyMH1CQ 6PCwMCPyoCOwjOiPQtkdtwmh4ovn9uGvUnm46vDdb0A2gCNg3/tkyZJDjxDJz84Dqr+Xpe bp0jMaj8INw1LcCNkbVcg7IoWad1rKkWLfT+ZZD+vRt6nFczImGda4iHnRGecBHL+n9Dri 4MhdyV8SfcHWsVFcjZw3a/GXfpym0uH8QzLwjLRGambapJgw5Ymouv3qWUKbzQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1649185179; a=rsa-sha256; cv=none; b=g1pHG97HZhqnRWGOMOJnMrQ4G22Aff4pSNqp1S/EcBFxccV2ejQRu4VREBnabzDVf73Jfd A0W4do477uZvrT0k/y57SBaZovQNLJKiaPfwu6zOnks1/rpzIIdh7CLTMth3qSsTQQF4zC EYGDNt1/TwyVRaD2znTerzD7ep4iB/SCfxWqxGhaDhhRyv6HCzOc/9irzGNJPEX7NnMGWd Tq4BuVy3WPJBHTUIb8DNBdFuwsvckqBzadNFxXdlVtwYo7gaUuxBS+TStTJZx6SFgvPCgi 7Kfpz0shc3NOSSA82FkLNPn+w8junHijxctjWjsBdMS+jMBtr/cj/c0j5yCf4g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=cock.li header.s=mail header.b=iXlchcfV; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 0.63 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=cock.li header.s=mail header.b=iXlchcfV; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 2E50DE3DA X-Spam-Score: 0.63 X-Migadu-Scanner: scn0.migadu.com X-TUID: pVdNn8FfFiis Hi. Most issues Maxime raised I can solve easily. The bundling part, however, I am unfamiliar with. Regarding the high consumption of energy, I think, having read thread, I think everyone would agree that a warning in the description would be beneficial. Finally, since I submitted the patch, I discovered that xmrig, in it's default state, will donate 1% of it's runtime to the developpers' pool. I don't know what is guix's policy on this matter, but I will assume we want it disabled. I'm going to fix the issues raised and send an updated patch. Cheers, Justin.