From: Maxime Devos <maximedevos@telenet.be>
To: Zhu Zihao <all_but_last@163.com>
Cc: 53648@debbugs.gnu.org
Subject: [bug#53648] [PATCH] gnu: fcitx5-gtk: Add GTK 4 support.
Date: Wed, 09 Feb 2022 12:05:20 +0100 [thread overview]
Message-ID: <7352ac1f2762ffe4f24f22427a5ab1d56ba9237b.camel@telenet.be> (raw)
In-Reply-To: <86wni4yeg9.fsf@163.com>
[-- Attachment #1: Type: text/plain, Size: 777 bytes --]
Zhu Zihao schreef op wo 09-02-2022 om 10:12 [+0800]:
> + (lambda* (#:key outputs #:allow-other-keys)
Since you're doing #$output:FOO instead of (assoc-ref outputs "foo")
below now, 'outputs' is now unused, so this can be simplified to
(lambda _ ; <-- no (#:key outputs #:allow-other-keys) argument list needed
;; Take care of [...]
(define (split-immodule gtk-version output)
[...])
[...])
> + (description "Fcitx5-gtk provides following functionality in corresponding
As previously mentioned, a few definite articles would seem to be in place:
‘Fcitx5-gtk provides _the_ following functionality in _the_ corresponding
output:’ (emphasis mine).
Otherwise, LGTM, although I didn't test it.
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2022-02-09 11:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-31 6:53 [bug#53648] [PATCH] gnu: fcitx5-gtk: Add GTK 4 support Zhu Zihao
2022-02-06 12:47 ` Zhu Zihao
2022-02-06 15:48 ` Maxime Devos
2022-02-06 16:02 ` Zhu Zihao
2022-02-06 17:03 ` Maxime Devos
2022-02-07 4:25 ` Zhu Zihao
2022-02-07 8:42 ` Maxime Devos
2022-02-08 4:19 ` Zhu Zihao
2022-02-08 10:02 ` Maxime Devos
2022-02-09 2:12 ` Zhu Zihao
2022-02-09 11:05 ` Maxime Devos [this message]
2022-02-09 15:54 ` Zhu Zihao
2022-02-09 20:33 ` Maxime Devos
2022-02-09 23:23 ` Zhu Zihao
2022-02-11 17:42 ` Zhu Zihao
2022-02-14 13:36 ` Ludovic Courtès
2022-02-16 13:25 ` Zhu Zihao
2022-02-07 5:58 ` Zhu Zihao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7352ac1f2762ffe4f24f22427a5ab1d56ba9237b.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=53648@debbugs.gnu.org \
--cc=all_but_last@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.