From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id oG5wAws9DGDPYAAA0tVLHw (envelope-from ) for ; Sat, 23 Jan 2021 15:13:15 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id WFnhOgo9DGCvEQAAB5/wlQ (envelope-from ) for ; Sat, 23 Jan 2021 15:13:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 54E5B9402B1 for ; Sat, 23 Jan 2021 15:13:14 +0000 (UTC) Received: from localhost ([::1]:58262 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l3KbB-0001Cw-8C for larch@yhetil.org; Sat, 23 Jan 2021 10:13:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44328) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3Kb0-0001CX-5h for guix-patches@gnu.org; Sat, 23 Jan 2021 10:13:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:51600) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l3Kaz-0007Wn-VH for guix-patches@gnu.org; Sat, 23 Jan 2021 10:13:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l3Kaz-0007FX-Qo for guix-patches@gnu.org; Sat, 23 Jan 2021 10:13:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#46043] [PATCH] Allow booting with custom shepherd package (fixed) Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 23 Jan 2021 15:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46043 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Prikler , 46043@debbugs.gnu.org Received: via spool by 46043-submit@debbugs.gnu.org id=B46043.161141472327788 (code B ref 46043); Sat, 23 Jan 2021 15:13:01 +0000 Received: (at 46043) by debbugs.gnu.org; 23 Jan 2021 15:12:03 +0000 Received: from localhost ([127.0.0.1]:34913 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l3Ka3-0007E8-6N for submit@debbugs.gnu.org; Sat, 23 Jan 2021 10:12:03 -0500 Received: from xavier.telenet-ops.be ([195.130.132.52]:52566) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l3Ka1-0007Df-Ic for 46043@debbugs.gnu.org; Sat, 23 Jan 2021 10:12:02 -0500 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by xavier.telenet-ops.be with bizsmtp id LFBz240040mfAB401FBzUo; Sat, 23 Jan 2021 16:11:59 +0100 Message-ID: <733adeb431a34b153e580172ae865836966d789b.camel@telenet.be> From: Maxime Devos Date: Sat, 23 Jan 2021 16:11:52 +0100 In-Reply-To: References: <874kj8bv8w.fsf@telenet.be> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-dwMuLQKK3Cw8Xsdez1+r" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1611414719; bh=f6RSebEMYAgvhjD72Ad1zQJfq1nY1u009QFEbqMp6jg=; h=Subject:From:Reply-To:To:Date:In-Reply-To:References; b=ptwMtgcIAZ88KMDQQkviFYW1ObO7UxuMkKo9CwMTnAZNu5ryktt/Bf2jj5h6N++cc o4uLaTdNytmHSZvC/QKS+bUKraga+ekjFolKaPxk1dxgTyBxxPLtko82QfJZ5sYymN I/Me+7RAWFPOop4IBSKx0ewXhdKMerrXn2fF57+r2qP6zi7O6k0Bv5JBnFSt3tQoTS Bp59KsqpPr1GLWiczUGC2JM52ibrAGKwV7YYXH3H7NGSBiwNMO5h1wd14ztZQpak5z x3Grbqt990jgfzaJTIQuTqTH0qdqGHJY5WsKXvJbKiYKMTjNSDSHS/tIt5hf4N0iWe Zol7QBJQZfCAA== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: 46043@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -3.35 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=ptwMtgcI; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 54E5B9402B1 X-Spam-Score: -3.35 X-Migadu-Scanner: scn0.migadu.com X-TUID: acJkGH6/fC8w --=-dwMuLQKK3Cw8Xsdez1+r Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Leo, On Sat, 2021-01-23 at 09:25 +0100, Leo Prikler wrote: > Hi Maxime, >=20 > Am Freitag, den 22.01.2021, 20:57 +0100 schrieb Maxime Devos: > > (compose concatenate) > > - (extend append) > > + (extend (lambda (config extra-services) > > + (shepherd-configuration > > + (inherit config) > > + (services (append (shepherd-configuration-services > > config) > > + extra-services))))) > I think you should also patch compose or drop it. I sadly don't know, > what impact that would have, but IIUC you should only spawn one > shepherd-root-service anyway. Only one shepherd-root-service-type should be spawned, correct. In practice, this means you'll need to use a construct like this (if I didn't make any errors): (modify-services %base-services (shepherd-root-service-type c =3D> (shepherd-configuration (inherit c) (shepherd a-custom-shepherd)))) For clarification: shepherd services should be added via the service-extension mechanism, not by manually changing the 'services' field (though the latter is a possibility now). About compose and concatenate: I think it is correct as-is. If compose is dropped, then shepherd-root-service-type wouldn't be extensible anymore. I don't see how it could be patched in a way that makes sense. Compare with udev-service-type as described in the manual, which follows the same structure. Regards, Maxime --=20 Maxime Devos PGP Key: C1F3 3EE2 0C52 8FDB 7DD7 011F 49E3 EE22 1917 25EE Freenode handle: mdevos --=-dwMuLQKK3Cw8Xsdez1+r Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYIADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYAw8uBccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7tUUAQC/8NnsnyIc6xAhGOmiRYOdw+Op OromQNsx9rotYZtUTwEApZ1cFR1F2Z5hkNr8QPGWgy8M/9sGS6fHz5GhYV48FA8= =9YA5 -----END PGP SIGNATURE----- --=-dwMuLQKK3Cw8Xsdez1+r--