From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id wHmEBR0nzl8EEQAA0tVLHw (envelope-from ) for ; Mon, 07 Dec 2020 12:59:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id sNoyAR0nzl8SDQAAbx9fmQ (envelope-from ) for ; Mon, 07 Dec 2020 12:59:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B87C2940418 for ; Mon, 7 Dec 2020 12:59:08 +0000 (UTC) Received: from localhost ([::1]:36278 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmG6d-0004bi-0q for larch@yhetil.org; Mon, 07 Dec 2020 07:59:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49098) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmFL8-0002ji-To for guix-patches@gnu.org; Mon, 07 Dec 2020 07:10:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:41227) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kmFL8-0008B5-LE for guix-patches@gnu.org; Mon, 07 Dec 2020 07:10:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kmFL8-0002hL-EO for guix-patches@gnu.org; Mon, 07 Dec 2020 07:10:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45064] [PATCH 0/2] Set environment variables for GTK+ input methods via profile startup files Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 07 Dec 2020 12:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45064 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: iyzsong@outlook.com, 45064@debbugs.gnu.org Cc: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= Received: via spool by 45064-submit@debbugs.gnu.org id=B45064.160734295410295 (code B ref 45064); Mon, 07 Dec 2020 12:10:02 +0000 Received: (at 45064) by debbugs.gnu.org; 7 Dec 2020 12:09:14 +0000 Received: from localhost ([127.0.0.1]:52771 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmFKM-0002fz-Dp for submit@debbugs.gnu.org; Mon, 07 Dec 2020 07:09:14 -0500 Received: from mailrelay.tugraz.at ([129.27.2.202]:9007) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmFKJ-0002fm-IN for 45064@debbugs.gnu.org; Mon, 07 Dec 2020 07:09:12 -0500 Received: from nijino.local (217-149-166-73.nat.highway.telekom.at [217.149.166.73]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4CqMYH0QNjz1LLyW; Mon, 7 Dec 2020 13:09:07 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4CqMYH0QNjz1LLyW DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1607342947; bh=rNnz8Ll8uWHG84nU3O4r4LAPDyxYhu0/z4ve9ngPVnw=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=Do0SL4R4DE83hLLuJI84flY4LXdS84lkgnv1rhNYvk4SgS/YZjXDmBU90aA28uzhb kQj8I39RoqE7KknK+sgx04/FouBSCg+gNmwBEcXfApnA7qFr5Vl2VZhBsp5hRGmkkC F8RETY/+SE9DWWZvv0GhK5iv5WQ/uUXduyPlV2dY= Message-ID: <72dca2daaef417e9fef63e43f16eb76fe215f066.camel@student.tugraz.at> From: Leo Prikler Date: Mon, 07 Dec 2020 13:09:05 +0100 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.20 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=tugraz.at header.s=mailrelay header.b=Do0SL4R4; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: B87C2940418 X-Spam-Score: -1.20 X-Migadu-Scanner: ns3122888.ip-94-23-21.eu X-TUID: IsD5+CrPAWFg Hello, 宋文武! As the author of [1] I might be a bit biased, but I have a few questions regarding this patch set: 1. Will it correctly pick up IM_MODULE_FILEs at system level if you also happen to have GTK+ applications installed at user level? a. What about multi-profile setups, where more than one profile contains GTK+ applications? b. What about `guix environment`? 2. Which purpose would sourcing those files offer other than setting environment variables? What would be permissible actions? Remember, that those would be executed whenever the user spawns a shell, so while you could put stuff like `fc-cache -r` in there, I personally think you ought not to. I believe a proper fix for GTK would be to allow setting multiple IM_MODULE_FILEs instead of a single one and using search paths. [1] was merely meant to have a reasonable default when installing ibus system-wide, it can not (and will not) help you if you also happen to have stuff in another profile. Regards, Leo Am Sonntag, den 06.12.2020, 13:40 +0800 schrieb iyzsong@outlook.com: > From: 宋文武 > > Hello, Guix! > > To use GTK+ input methods, currently we need set > ‘GUIX_GTK2_IM_MODULE_FILE’ and ‘GUIX_GTK3_IM_MODULE_FILE’ manually in > .xsession or .bash_profile, we also having a patch [1] that set them > for gnome via ‘gnome-desktop-service-type’. But I think the right > place to set them is the ‘gtk-im-modules’ profile hook, so the first > patch make ‘etc/profile’ source files in ‘etc/profile.d/*.sh’, and > the > second patch add ‘etc/profile.d/gtk2-im-modules.sh’ and > ‘etc/profile.d/gtk3-im-modules.sh’. The first patch is also useful > for packages that provide profile startup files (eg: nix). > > Thanks! > > [1] > > Sou Bunnbu (宋文武) (2): > profiles: Load application specific startup files. > profiles: gtk-im-modules: Set environment variables for input > methods. > > guix/build/profiles.scm | 13 ++++++++++++- > guix/profiles.scm | 12 ++++++++++-- > 2 files changed, 22 insertions(+), 3 deletions(-) >