all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Jonathan Brielmaier <jonathan.brielmaier@web.de>
To: Ekaitz Zarraga <ekaitz@elenq.tech>, 41297@debbugs.gnu.org
Subject: [bug#41297] [PATCH] gnu: openctm: Correct inputs vs native-inputs
Date: Sat, 16 May 2020 01:35:09 +0200	[thread overview]
Message-ID: <7299b00f-d6af-89f5-16ea-a71101e9049c@web.de> (raw)
In-Reply-To: <zNBmy4CTl_peMQ-9S7lElZFjofYW1DVtSTtDOyq9Rk7zWkYaJxkZYJmN7FUV0sqdkrWugMehtMlO-gwglkTXx_biL9ZyvdIf1TI-CdNKJ2Q=@elenq.tech>

On 16.05.20 00:57, Ekaitz Zarraga wrote:
> From 417f64adc854e5d717351fec68872ed19a9ac3df Mon Sep 17 00:00:00 2001
> From: Ekaitz Zarraga <ekaitz@elenq.tech>
> Date: Sat, 16 May 2020 00:49:53 +0200
> Subject: [PATCH] gnu: openctm: Correct inputs vs native-inputs

Please add a dot add the end of sentences.

>     * gnu/packages/engineering.scm (openctm): Change inputs

Maybe rephrase it to: Move pkg-config to native-inputs.

> ---
>  gnu/packages/engineering.scm | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
> index aec692174a..aab414bf0e 100644
> --- a/gnu/packages/engineering.scm
> +++ b/gnu/packages/engineering.scm
> @@ -2557,11 +2557,12 @@ official SDK.")
>            (base32 "01wb70m48xh5gwhv60a5brv4sxl0i0rh038w32cgnlxn5x86s9f1"))))
>        (build-system gnu-build-system)
>        (native-inputs
> +       `(("pkg-config" ,pkg-config)))
> +      (inputs
>         `(("mesa" ,mesa)
>           ("glu" ,glu)
>           ("glut" ,freeglut)
> -         ("gtk" ,gtk+-2)
> -         ("pkg-config" ,pkg-config)))
> +         ("gtk" ,gtk+-2)))
>        (arguments
>         `(#:tests? #f                              ;no tests
>           #:phases
> --

Otherwise it looks good.




  reply	other threads:[~2020-05-15 23:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-15 22:57 [bug#41297] [PATCH] gnu: openctm: Correct inputs vs native-inputs Ekaitz Zarraga
2020-05-15 23:35 ` Jonathan Brielmaier [this message]
2020-05-16  9:57   ` Ekaitz Zarraga
2020-05-16 10:06     ` Jonathan Brielmaier
2020-05-16 10:24       ` Ekaitz Zarraga
2020-05-16 17:24         ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7299b00f-d6af-89f5-16ea-a71101e9049c@web.de \
    --to=jonathan.brielmaier@web.de \
    --cc=41297@debbugs.gnu.org \
    --cc=ekaitz@elenq.tech \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.