From: Alexandros Theodotou <alex@zrythm.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: 46680@debbugs.gnu.org
Subject: [bug#46680] [PATCH] gnu: Add midicomp.
Date: Tue, 23 Feb 2021 18:56:13 +0000 [thread overview]
Message-ID: <721dc0ef8b515ad8f62deecb7a8549868183fcff.camel@zrythm.org> (raw)
In-Reply-To: <87im6iy8va.fsf@nicolasgoaziou.fr>
[-- Attachment #1: Type: text/plain, Size: 411 bytes --]
Hi,
Thanks for the feedback, I updated the patch (attached).
I saw the conversation on IRC and I believe we should take the word of
the author if it's explicitly mentioned in the README.
>I think there is an issue here. The repository has no LICENSE file,
> and
> source code files have no license header. The only reference to
> AGPL3.0
> is in the README.md. I'm not sure this is sufficient.
Thanks,
Alex
[-- Attachment #2: 0001-gnu-Add-midicomp.patch --]
[-- Type: text/x-patch, Size: 2004 bytes --]
From 2434b06388935f50bb67c15fc7e1264f0e8bc9f9 Mon Sep 17 00:00:00 2001
From: Alexandros Theodotou <alex@zrythm.org>
Date: Tue, 23 Feb 2021 18:51:05 +0000
Subject: [PATCH] gnu: Add midicomp.
* gnu/packages/audio.scm (midicomp): New variable.
---
gnu/packages/audio.scm | 31 +++++++++++++++++++++++++++++++
1 file changed, 31 insertions(+)
diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 16e0eec418..372c056d16 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -1223,6 +1223,37 @@ object library.")
language and software synthesizer.")
(license license:lgpl2.1+)))
+(define-public midicomp
+ ;; The latest tagged release is 9 years old and there have been
+ ;; unreleased fixes, so we take the last commit.
+ (let ((commit "70f76963cb0cdb3cbe03ec6e7246b1fb885d3c68")
+ (revision "1"))
+ (package
+ (name "midicomp")
+ (version (git-version "0.0.8-" revision commit))
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/markc/midicomp")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "12zh247c6v88ssy4l8v7yirh4bl2jcc1ch7f4gdry79a82kai1gf"))))
+ (build-system cmake-build-system)
+ (arguments
+ `(#:tests? #f)) ; no "check" target
+ (synopsis "Convert SMF MIDI files to and from plain text")
+ (description
+ "midicomp can manipulate SMF (Standard MIDI File) files. It can both
+ read and write SMF files in 0 or format 1 and also read and write its own
+ plain text format. This means a SMF file can be turned into easily
+ parseable text, edited with any text editor or filtered through any script
+ language, and recompiled back into a binary SMF file.")
+ (home-page "https://github.com/markc/midicomp")
+ (license license:agpl3))))
+
(define-public clalsadrv
(package
(name "clalsadrv")
--
2.30.1
next prev parent reply other threads:[~2021-02-23 18:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-21 10:21 [bug#46680] [PATCH] gnu: Add midicomp Alexandros Theodotou
2021-02-23 17:47 ` Nicolas Goaziou
2021-02-23 18:56 ` Alexandros Theodotou [this message]
2021-02-23 19:07 ` bug#46680: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=721dc0ef8b515ad8f62deecb7a8549868183fcff.camel@zrythm.org \
--to=alex@zrythm.org \
--cc=46680@debbugs.gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.