From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id EJftBrzikWMIwAAAbAwnHQ (envelope-from ) for ; Thu, 08 Dec 2022 14:12:28 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id +EfmBrzikWMuuwAA9RJhRA (envelope-from ) for ; Thu, 08 Dec 2022 14:12:28 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B95D03F856 for ; Thu, 8 Dec 2022 14:12:27 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p3Gh1-0008M6-U5; Thu, 08 Dec 2022 08:12:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3Gh0-0008La-Bs for guix-patches@gnu.org; Thu, 08 Dec 2022 08:12:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p3Gh0-0005AP-3L for guix-patches@gnu.org; Thu, 08 Dec 2022 08:12:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p3Ggz-0002oZ-UO for guix-patches@gnu.org; Thu, 08 Dec 2022 08:12:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59866] [PATCH 0/2] services: mpd: Refactor MPD service Resent-From: mirai Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 08 Dec 2022 13:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59866 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler , 59866@debbugs.gnu.org Cc: 54986@debbugs.gnu.org Received: via spool by 59866-submit@debbugs.gnu.org id=B59866.167050509710802 (code B ref 59866); Thu, 08 Dec 2022 13:12:01 +0000 Received: (at 59866) by debbugs.gnu.org; 8 Dec 2022 13:11:37 +0000 Received: from localhost ([127.0.0.1]:56704 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3Ggb-0002o5-B5 for submit@debbugs.gnu.org; Thu, 08 Dec 2022 08:11:37 -0500 Received: from smtpmciv4.myservices.hosting ([185.26.107.240]:48080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3GgZ-0002nu-9L; Thu, 08 Dec 2022 08:11:35 -0500 Received: from mail1.netim.hosting (unknown [185.26.106.172]) by smtpmciv4.myservices.hosting (Postfix) with ESMTP id A58AF20775; Thu, 8 Dec 2022 14:11:33 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id 65C0E80096; Thu, 8 Dec 2022 14:11:33 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-1.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Qm4M4if-MSeb; Thu, 8 Dec 2022 14:11:29 +0100 (CET) Received: from [192.168.1.239] (unknown [10.192.1.83]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id 9CFC980093; Thu, 8 Dec 2022 14:11:29 +0100 (CET) Message-ID: <71f31a0d-cc58-a0e6-4aa4-b5c46513c835@makinata.eu> Date: Thu, 8 Dec 2022 13:11:29 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 From: mirai References: <6e66967984d1bc22d8abf5dd4b07c1a20b4b06ee.camel@gmail.com> Content-Language: en-US In-Reply-To: <6e66967984d1bc22d8abf5dd4b07c1a20b4b06ee.camel@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1670505147; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=RRtRokoKIstGEcd9JmNxskGo8udEniRROKPscxh3nBU=; b=DVOuGMok5/ZlF8Qth97frn5SH6MxK16Tj7HX5Ddgk9oC3oaqwofUFtCmiu6IiGVsg9vTvQ bFuveFmzH4XxcvyKiEuKPUYn5prAuSCY8iVI0ztR45OC5iBtvV/0jq50OVJyZjDS0GIFk1 p3eiUCqcmA5aUPQvUdX9Yedv0fCDauGPy5YobsbTsBfq+lYt9evoCdOqAMpNuxOcw77UBz hTRaIAPdnCiQsvyX724mSMtBfNC4Zlh4Et9kpp5IxtoFgHbOxBZ5Tg3p6j5ewtxXAimfNf BeZcAye+5q5coWnBV8ejXFIfhiEjCj1eGfmO4XaCS3EWBPJxScxsfY/UqU/oLg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1670505147; a=rsa-sha256; cv=none; b=oiylG+ZMEoj6l6z0tEXi/Uvg/xCj7vLBZxqI0P6PUI5L/GU9qS+hcQZd95FvqtecasSa88 1/8rsI2JnJ6c63EFLJvr46JbqNsWAHQvEnGypX7ZF5ZAoNW+izbYrTIenzNHwJKwtvcFmA uzmiQKVte1d77yalt2joDIoKZLP05yqE65KhpCtegiE59D0/gXKx6IRVHrNcjn80KNJl6M EPZ3S6oKrgVbbgl5yfq6UpN8guqQz+wrXYXoBGClXlexg9ztLHDQos4eKKLNHUpsOrTSGR s5cHjHjAeg2oYE7F2uELBVM/iMMJMpXzppOrsNbw/Hx8ITYTFlqRop1zK7t8xw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.96 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: B95D03F856 X-Spam-Score: -3.96 X-Migadu-Scanner: scn0.migadu.com X-TUID: ro5NS6FaqaXx On 2022-12-07 18:27, Liliana Marie Prikler wrote: > Note that there is [1], which attempts to make it so that shepherd > endpoints can be specified in lieu of MPD endpoints. You don't need to > implement this logic – you are free to do so if you want to – but could > you make it so that there is an explicit endpoint abstraction that > would allow for extension later on? > > Cheers > > [1] https://issues.guix.gnu.org/54986 Hi, After reading issue #54986, regarding mpd escaping shepherd management, my guess is that there could be two issues at play here: * mpd.conf was serialized with pid_file [1]. The safest is to actually not serialize any unused directives and let MPD decide based on what's actually present. pid_file should only be set if MPD is to be launched as a "daemon process". [2] * But the service definition for MPD is launched with '--no-daemon' option as seen in [3], which could be triggering a bug in MPD. It's probably worth testing the combinations of having pid_file set and invoking --no-daemon. > but could > you make it so that there is an explicit endpoint abstraction that > would allow for extension later on? If I'm understanding correctly what [1] is about, I think this can be implemented through the 'extend' interface. See how certbot adds a nginx-server-configuration to a nginx-service-type through the 'extend' interface. For MPD, this would amount to appending the 'adresses' field with "adequately formatted" values. [1]: https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/services/audio.scm?id=1b6172d5f6ca22f0fa02cd1335b1b90e9501b731#n116 [2]: https://mpd.readthedocs.io/en/latest/user.html#starting-and-stopping-mpd [3]: https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/services/audio.scm?id=1b6172d5f6ca22f0fa02cd1335b1b90e9501b731#n145