bug#58040: "guix style" puts closing parentheses on the wrong line

bug#58040: "guix style" puts closing parentheses on the wrong line

[Maxime Devos]

[-- Attachment #1.1.1: Type: text/plain, Size: 1293 bytes --]

Hi,

Putting the following definition into a file a.scm (from 
https://issues.guix.gnu.org/57460):

(define (find-latest-release releases)
   (fold (match-lambda*
          (((key . value) result)
           (cond ((even-minor-version? key)
                  (match result
			(#f
			 (cons key value))
			((newest . _)
			 (if (version>? key newest)
                              (cons key value)
                              result))))
                 (else
                  result))))
         #f
         releases))

and running "guix style -f a.scm" on it, it becomes

(define (find-latest-release releases)
   (fold (match-lambda* (((key . value) result)
                         (cond
                           ((even-minor-version? key)
                            (match result
                              (#f (cons key value))
                              ((newest . _) (if (version>? key newest)
                                                (cons key value) result))))
                           (else result)))
           ) #f releases)).

In particular, note the ") #f releases" -- IMO ) should be on the 
previous line, after (else result))), to avoid lonely parentheses and to 
align the arguments of 'fold'.

Greetings,
Maxime.

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

bug#58040: "guix style" puts closing parentheses on the wrong line

[Ludovic Courtès]

Hi,

Maxime Devos <maximedevos@telenet.be> skribis:

> and running "guix style -f a.scm" on it, it becomes
>
> (define (find-latest-release releases)
>   (fold (match-lambda* (((key . value) result)
>                         (cond
>                           ((even-minor-version? key)
>                            (match result
>                              (#f (cons key value))
>                              ((newest . _) (if (version>? key newest)
>                                                (cons key value) result))))
>                           (else result)))
>           ) #f releases)).
>
> In particular, note the ") #f releases" -- IMO ) should be on the
> previous line, after (else result))), to avoid lonely parentheses and
> to align the arguments of 'fold'.

Fixed in 4bd75d79e5ad8bb0f6cdcc0d15b9afb25f54afbd: ‘match-lambda*’ had
an incorrect special form declaration.

Thanks,
Ludo’.