From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id +Lz3NFifB2K81wAAgWs5BA (envelope-from ) for ; Sat, 12 Feb 2022 12:51:52 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id UEOoLVifB2ImaAEAG6o9tA (envelope-from ) for ; Sat, 12 Feb 2022 12:51:52 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2284E10294 for ; Sat, 12 Feb 2022 12:51:52 +0100 (CET) Received: from localhost ([::1]:56562 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nIqwQ-0001CO-P6 for larch@yhetil.org; Sat, 12 Feb 2022 06:51:50 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33870) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nIqh9-0006wy-Cv for guix-patches@gnu.org; Sat, 12 Feb 2022 06:36:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:39718) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nIqh8-0005ms-CU for guix-patches@gnu.org; Sat, 12 Feb 2022 06:36:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nIqh8-0001eD-AG for guix-patches@gnu.org; Sat, 12 Feb 2022 06:36:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53704] Bump Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 12 Feb 2022 11:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53704 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Charles , Julien Lepiller Cc: "53704@debbugs.gnu.org" <53704@debbugs.gnu.org> Received: via spool by 53704-submit@debbugs.gnu.org id=B53704.16446657516315 (code B ref 53704); Sat, 12 Feb 2022 11:36:02 +0000 Received: (at 53704) by debbugs.gnu.org; 12 Feb 2022 11:35:51 +0000 Received: from localhost ([127.0.0.1]:33615 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nIqgw-0001dn-SW for submit@debbugs.gnu.org; Sat, 12 Feb 2022 06:35:51 -0500 Received: from albert.telenet-ops.be ([195.130.137.90]:37788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nIqgu-0001dd-77 for 53704@debbugs.gnu.org; Sat, 12 Feb 2022 06:35:49 -0500 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by albert.telenet-ops.be with bizsmtp id uBbl2600A4UW6Th06BblgD; Sat, 12 Feb 2022 12:35:45 +0100 Message-ID: <708d9f2b29e09f3906d36ecefc8c273bb589d1b4.camel@telenet.be> From: Maxime Devos Date: Sat, 12 Feb 2022 12:35:29 +0100 In-Reply-To: <3c9dxjEeXYXD76uUQgjwTlqZOtOb7IFb8FX50AHQoH9bc-bapcr6kxnaouHjVYd3CaIPjKPiuUwZ6tx6VW-YRPKUMri5i_mLx4du5ux81a8=@protonmail.com> References: <_jHX_rdAkHOB9IqHIQfXfggyuZwAL-8cC92ZuWnlLfjZtXdqUHY5XBLRjD32CGrxNx7uBzHJgAtN_YdHoifX1Y4Vhaayg_gWJX6wqPZDhx4=@protonmail.com> <33CA9DF7-1E9D-410D-9775-61825B56A0DF@lepiller.eu> <3c9dxjEeXYXD76uUQgjwTlqZOtOb7IFb8FX50AHQoH9bc-bapcr6kxnaouHjVYd3CaIPjKPiuUwZ6tx6VW-YRPKUMri5i_mLx4du5ux81a8=@protonmail.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-aJC50TRWa8C5pAYHb0Ci" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1644665745; bh=cK5XiyhR/i8Am0JFLoLhqFA5s9RbaPh40V9g2Xs+FQc=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=ODKQNTbgEe6Z3gLVjuFaXPJzWRSWwpgvqqTZGJMsLjs9YQ4Grtd+yKnlxVgTMtlww jSb/SZXYb7bk07BQueLWVnXrA0EOIFUNgONufTk/cg7j4krJ3ujcmCP4s2RRkwrvU4 3wffnAcYXqiT9GQwKzpUJCj1kEOdqHQ+cIw/9lKDYs8iIqLAw3Qs3r2NKzHvfhyhep THYTelnpudFPlWqJU3KXC9cuT3Gd0rbmPEBDFeOB5RuxXq09A44sOq4TvQtGH82akv IaNnjV+QafLSlZPEAQ6u1ySxbdeHRW/F4GH8bTZCPHo1wIklpVx6Xlaoz1gdjkdpAu ARFtq/fwv5I1Q== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1644666712; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=cK5XiyhR/i8Am0JFLoLhqFA5s9RbaPh40V9g2Xs+FQc=; b=FJUCc1AGArab4L9pPQwpNxkX4jbFimu/b/VeGP8FnU2Rgq7uNGjPd71So+UeUzhb0FKbFY IaOYo7M7EjwfCBBB8eebFBRJGIn0KcyrozmkqI4VnMyYderwhEK6zbZZDBLm40rQ1SCnkS ju3Ld+yrOgOu1Tde73xTJLEdxeeUJnpPEjugVHUua0LXE8WmH1lGW6PviaDk+eT8JmoVYg IqIEo/a927FdqqX1qB6SWurPhuXIx1d4zBzafgJp7nZRjxbhVCHIz8xaEHlT6hQtSJ+gvp QYkhAsYAncbOUwmjoTi+ejHFoFR3W28jC0144Sd5Fihd6MaHBqeuchJtQpcOBA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1644666712; a=rsa-sha256; cv=none; b=eAhFSKifKRTsFcfFTbM4Frsid96yo+Ji7fN7V2hLLrUq7pRFR6MZ2ywL9IUzavweZuhxs0 KVG/sOk3eW/5c6VTMQk2mlTzDrFC0VJKeextiOb/AGkJbntGLVVvaPy5Rif+HVz12Yi0ZR aKDLGKPXtn33euiPkD5RRLqXYYGu7rLmcmG7bS2BEaCBzEj0OjgiWyKKVUT9pckd4tP081 I7NP7vUKJkSJf3y0Tcn7Nlay6KUuKGXYJLzilOZTc7hEbEYv0QXzXpw6QsCSjKShoyrGq1 dZ+6lBStF5FtO1gTFQfRDq8uUELTaK5mwqtmWsOsRWFiNSquU6sfu84UqpNGtg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=ODKQNTbg; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.23 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=ODKQNTbg; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 2284E10294 X-Spam-Score: -4.23 X-Migadu-Scanner: scn1.migadu.com X-TUID: dIINazd0jfB9 --=-aJC50TRWa8C5pAYHb0Ci Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Charles via Guix-patches via schreef op za 12-02-2022 om 00:30 [+0000]: > +=C2=A0=C2=A0=C2=A0 (source > +=C2=A0=C2=A0=C2=A0=C2=A0 (origin > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (method git-fetch) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (uri (git-reference > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= (url > "https://github.com/visualboyadvance-m/visualboyadvance-m/") > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= (commit (string-append "v" version)))) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (file-name (git-file-name name vers= ion)) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (sha256 > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (base32 > "1kgpbvng3c12ws0dy92zc0azd94h0i3j4vm7b67zc8mi3pqsppdg")) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (patches (search-patches "visualboy= advance-m-fix- > rpath.patch")))) The iniparser package is bundled in src/common/iniparser.c and src/common/iniparser.h. A part of a variant of zlib is in src/common/memgzio.c and src/common/memgzio.h. I think it's ok in this case, since it appears to be modified for use in visualboyadvance-m. However, the license of zlib needs to be respected: /* gzio.c -- IO on .gz files * Copyright (C) 1995-2002 Jean-loup Gailly. * For conditions of distribution and use, see copyright notice in zlib.h * * Compile this file with -DNO_DEFLATE to avoid the compression code. */ I don't see zlib.h anywhere and the zlib license requires preserving the license notice: 3. This notice may not be removed or altered from any source distribution. There is another problem: the version in visualboyadvance-m is old (2002, according to the copyright line) while there have been quite a few bugfixes since then (https://www.zlib.net/ChangeLog.txt). Another bundled library: src/common/dictionary.c and src/common/dictionary.h. There is also src/filters/bilinear.cpp which is extracted from Exult (GPL2+ licensed), but it appears that the copyright+license header was not preserved, while preserving that is a requirement of the GPL IIUC? The files in src/filters/xBRZ are GPL3 licensed, so 'license:gpl2+' in the package definition seems inaccurate. It is unclear of GPL3-only or GPL3-or-later was meant. The file src/gba/debugger-expr-lex.cpp and src/gba/debugger-expr- yacc.cpp are generated by flex and Bison, can they be generated during the build? libretro is bundled in src/libretro, can it be unbundled? src/expr.cpp and src/expr.cpp.h are generated files, not source code. A part of glibc is bundled in src/sdl/getopt1.c, src/sdl/getopt.c and src/sdl/getopt.h. wxwidgets is bundled in src/wx. Greetings, Maxime. --=-aJC50TRWa8C5pAYHb0Ci Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYgebgRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7tHpAQCKgtKKvBQG9CBrdLxI7aRrHqoo aLloZIOJcmSVu6jDmgD+OJf4DwnKvov9aOiYhgWvlZKkP9ero/Tl7cpwLXhzlQU= =E/i8 -----END PGP SIGNATURE----- --=-aJC50TRWa8C5pAYHb0Ci--