From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <guix-patches-bounces+larch=yhetil.org@gnu.org>
Received: from mp1.migadu.com ([2001:41d0:403:4876::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by ms13.migadu.com with LMTPS
	id eOypN3dNK2emuwAA62LTzQ:P1
	(envelope-from <guix-patches-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Wed, 06 Nov 2024 11:05:28 +0000
Received: from aspmx1.migadu.com ([2001:41d0:403:4876::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by mp1.migadu.com with LMTPS
	id eOypN3dNK2emuwAA62LTzQ
	(envelope-from <guix-patches-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Wed, 06 Nov 2024 12:05:28 +0100
X-Envelope-To: larch@yhetil.org
Authentication-Results: aspmx1.migadu.com;
	dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=ccaLTowU;
	dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b="LpTUtv/Q";
	dmarc=fail reason="SPF not aligned (strict), DKIM not aligned (strict)" header.from=posteo.net (policy=none);
	spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"
ARC-Seal: i=1; s=key1; d=yhetil.org; t=1730891127; a=rsa-sha256; cv=none;
	b=XdAgUXbzFK9ZwKD16Hl6ayP+HCZwn7tgvaI0GlxDxVXyfjDKE3k2PMRNU4KueQbXYzmxBx
	kPDLHT206A1jMqmEqQIhYcjEOxhrNndfSNf+SogBfm1npu5HbcS5SP5H6+KMps90p0TphG
	ECaL3EqllvG4n9SDmu3grmSsXM5IH7DfCeUr8ToZbYxNoCodHGqdUATLt71ydhoVqi7VeO
	yJc/oo3gC82LHnLKCkTj/9eZdQjTxSOV2TTfTY6TRpoanRdPSBBT6Up5vs0h8LmeGIyBPI
	/jsyAAL5uAN8iU2BwCGLeJKYs9/sfESM9OLlw/nG/jA4zvKXvcXYgtgnDuUvYg==
ARC-Authentication-Results: i=1;
	aspmx1.migadu.com;
	dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=ccaLTowU;
	dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b="LpTUtv/Q";
	dmarc=fail reason="SPF not aligned (strict), DKIM not aligned (strict)" header.from=posteo.net (policy=none);
	spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org;
	s=key1; t=1730891127;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:cc:mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:resent-cc:
	 resent-from:resent-sender:resent-message-id:list-id:list-help:
	 list-unsubscribe:list-subscribe:list-post:dkim-signature;
	bh=0Po3pIUmPxkCEJGAFHRVRL+3DxlUrWMlKVyqjhSNN3E=;
	b=dYgzkWLUEOaHzpoHX+t/y2HuL0KpYBqsVsgzB+OEgkeX0dmkiMn9vI983YFldlhPXArasm
	/vWd5qEc1Q/3Z0EIr95TlcCBDyUrMj9Bo+JAcVMqjQT3vlJX1lIYTqiBc0tsvlGhoKySnN
	nJtH5bxQQ0FbnO+TJ1NCfzPRFvJ1MTwNUoM9MvLWtRYqPMKNd1Vtq74FA7PkzpG1+X6uD6
	oDo55ECBP+8SgkRLrIonHQPGp4VeJMaWCAqZh3Vu5X01U9DioDzj7tJvP9vfhEC66e1bKs
	FTe3sANzjV+JnBddR+S+Yiqcf14C8zja/jgbd+XE6if07JbvnWkEB6enUZJfdg==
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by aspmx1.migadu.com (Postfix) with ESMTPS id 7557B7BAB5
	for <larch@yhetil.org>; Wed, 06 Nov 2024 12:05:27 +0100 (CET)
Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <guix-patches-bounces@gnu.org>)
	id 1t8dqa-0005FB-Uh; Wed, 06 Nov 2024 06:05:13 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1t8dqY-0005DD-LN
 for guix-patches@gnu.org; Wed, 06 Nov 2024 06:05:10 -0500
Received: from debbugs.gnu.org ([2001:470:142:5::43])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1t8dqY-0005Aq-1C; Wed, 06 Nov 2024 06:05:10 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
 d=debbugs.gnu.org; s=debbugs-gnu-org; 
 h=MIME-Version:Date:From:To:Subject;
 bh=0Po3pIUmPxkCEJGAFHRVRL+3DxlUrWMlKVyqjhSNN3E=; 
 b=ccaLTowU/eMMEvb/lo+u2BpDV/4lRU407rPdxRmWxZoBRbl/PRReg8sPSrtosLPiEoc4D7Kmd/zhrAN4m839yVXVOeZam50zkbVNVT0AUoSKqh1qJ7N/MvAta7q9VJHwI2MpKf1tevl2gd/DhqzoVvUmxA75Pt8xTxroaFKlSujsTzNPDR7VsHHwezTs4VMI7sOElL09LU0rY0Pii+p4AgsarmYyCsBsq/HM6QjZClKQCI/AyVGjfTKp88hVuZNTBsaXGVn/lP24u2cmDcOE2IzA89Pm/DK6Nb0A0CTPr9ovEWi7UZc38HK6n0JnbF3QsbmE/KSEeGhaqUmf7w+VTA==;
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1t8dqQ-0001P5-Fh; Wed, 06 Nov 2024 06:05:02 -0500
X-Loop: help-debbugs@gnu.org
Subject: [bug#74225] [PATCH] lint: Check for more types of custom 'check
 phases.
Resent-From: Dariqq <dariqq@posteo.net>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: guix@cbaines.net, dev@jpoiret.xyz, ludo@gnu.org, othacehe@gnu.org,
 zimon.toutoune@gmail.com, me@tobias.gr, guix-patches@gnu.org
Resent-Date: Wed, 06 Nov 2024 11:05:02 +0000
Resent-Message-ID: <handler.74225.B.17308910675344@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: report 74225
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 74225@debbugs.gnu.org
Cc: Dariqq <dariqq@posteo.net>, Christopher Baines <guix@cbaines.net>,
 Josselin Poiret <dev@jpoiret.xyz>,
 Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>,
 Mathieu Othacehe <othacehe@gnu.org>, Simon Tournier <zimon.toutoune@gmail.com>,
 Tobias Geerinckx-Rice <me@tobias.gr>
X-Debbugs-Original-To: guix-patches@gnu.org
X-Debbugs-Original-Xcc: Christopher Baines <guix@cbaines.net>,
 Josselin Poiret <dev@jpoiret.xyz>,
 Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>,
 Mathieu Othacehe <othacehe@gnu.org>, Simon Tournier <zimon.toutoune@gmail.com>,
 Tobias Geerinckx-Rice <me@tobias.gr>
Received: via spool by submit@debbugs.gnu.org id=B.17308910675344
 (code B ref -1); Wed, 06 Nov 2024 11:05:02 +0000
Received: (at submit) by debbugs.gnu.org; 6 Nov 2024 11:04:27 +0000
Received: from localhost ([127.0.0.1]:39827 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1t8dpq-0001O7-Ri
 for submit@debbugs.gnu.org; Wed, 06 Nov 2024 06:04:27 -0500
Received: from lists.gnu.org ([209.51.188.17]:52142)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <dariqq@posteo.net>) id 1t8dpp-0001O0-5l
 for submit@debbugs.gnu.org; Wed, 06 Nov 2024 06:04:25 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <dariqq@posteo.net>) id 1t8dpo-00050K-2a
 for guix-patches@gnu.org; Wed, 06 Nov 2024 06:04:24 -0500
Received: from mout02.posteo.de ([185.67.36.66])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <dariqq@posteo.net>) id 1t8dpl-0003Pv-V9
 for guix-patches@gnu.org; Wed, 06 Nov 2024 06:04:23 -0500
Received: from submission (posteo.de [185.67.36.169]) 
 by mout02.posteo.de (Postfix) with ESMTPS id 5B6BB240101
 for <guix-patches@gnu.org>; Wed,  6 Nov 2024 12:04:18 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
 t=1730891058; bh=MeVpO/FJe0uvlSAVeGsygioCK66q4Tysb/ENi28fL7c=;
 h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:
 Content-Transfer-Encoding:From;
 b=LpTUtv/Qqc5FQW0Sk4ayxWo4KxYYgshMb3e76TASbS2WNi1LCkLlLNP1oDGkgDy7M
 al+V6smaA+8S+5Fexv2ytcMED83sthtEMlfBwDguX3RZlw0QxE5ZC4p/tUbpEfXAYT
 LfxQSaqwCXb6XRagIKwBt4JE0HclhiYWZBE2fpg7hCr6/bzufJO2lnzhNISy6IyPA+
 ytJV3QxBZ/dQzTkbSzNmSuSshekAfIFDXi2TGAAz9oC/qJ+BwKcaF3mk23oNDZ5ysh
 WZQKj5mL68tzJXTpamTmcaFpK/KAiOXv/smLfqISiDrfRaNHvjbnFWG31IGkfSWWHp
 2TAqmez5u6agQ==
Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 4Xk2QT5tf4z9rxQ;
 Wed,  6 Nov 2024 12:04:17 +0100 (CET)
From: Dariqq <dariqq@posteo.net>
Date: Wed,  6 Nov 2024 10:46:48 +0000
Message-ID: <705438b285d013ee05c5ae1d73b1c80aff2aa4fa.1730890007.git.dariqq@posteo.net>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=185.67.36.66; envelope-from=dariqq@posteo.net;
 helo=mout02.posteo.de
X-Spam_score_int: -43
X-Spam_score: -4.4
X-Spam_bar: ----
X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, 
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
X-BeenThere: guix-patches@gnu.org
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org
Sender: guix-patches-bounces+larch=yhetil.org@gnu.org
X-Migadu-Country: US
X-Migadu-Flow: FLOW_IN
X-Migadu-Spam-Score: 2.54
X-Spam-Score: 2.54
X-Migadu-Queue-Id: 7557B7BAB5
X-Migadu-Scanner: mx10.migadu.com
X-TUID: O4SSoBIRHFnS

* guix/lint.scm (check-optional-tests): Also check for add-before and
add-after when adding custom 'check phases.

Change-Id: Idc959f90d7e9aa9d5001f34e00f88b41aa20fb2a
---
Hi,
Stumbled upon a test failure in u-boot-utils today which is not using #:tests? for its custom 'check phase but not being detected by the linter. Reason is that the 'check phase is added after 'install and not just replacing it.

This little patch makes it it possible to detect it and adds 38 more warnings.


 guix/lint.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/guix/lint.scm b/guix/lint.scm
index 8c6c20c723..4ba728da33 100644
--- a/guix/lint.scm
+++ b/guix/lint.scm
@@ -1433,6 +1433,10 @@ (define (check-optional-tests package)
     (match delta
       (`(replace 'check ,expression)
        (check-check-procedure expression))
+      (`(add-after ,_ 'check ,expression)
+       (check-check-procedure expression))
+      (`(add-before ,_ 'check ,expression)
+       (check-check-procedure expression))
       (_ '())))
   (define (check-phases-deltas deltas)
     (append-map check-phases-delta deltas))

base-commit: 0c1a6db8094dc6b20762eceae369daae545fc5e4
-- 
2.46.0