From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 9OaEH885wV6eDQAA0tVLHw (envelope-from ) for ; Sun, 17 May 2020 13:19:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 2ELKGs85wV7VZAAA1q6Kng (envelope-from ) for ; Sun, 17 May 2020 13:19:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C8966940143 for ; Sun, 17 May 2020 13:19:10 +0000 (UTC) Received: from localhost ([::1]:41118 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jaJC9-0006CW-Oo for larch@yhetil.org; Sun, 17 May 2020 09:19:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60776) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jaJC2-0006CK-9w for guix-patches@gnu.org; Sun, 17 May 2020 09:19:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:59301) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jaJC2-0000cx-1L for guix-patches@gnu.org; Sun, 17 May 2020 09:19:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jaJC1-0007RD-TB for guix-patches@gnu.org; Sun, 17 May 2020 09:19:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41181] adds emacs-interleave Resent-From: rdes Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 17 May 2020 13:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41181 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Nicolas Goaziou Cc: 41181@debbugs.gnu.org X-Debbugs-Original-Cc: "41181@debbugs.gnu.org" <41181@debbugs.gnu.org>, rdes via Guix-patches via Received: via spool by submit@debbugs.gnu.org id=B.158972153428572 (code B ref -1); Sun, 17 May 2020 13:19:01 +0000 Received: (at submit) by debbugs.gnu.org; 17 May 2020 13:18:54 +0000 Received: from localhost ([127.0.0.1]:42612 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jaJBm-0007QY-Ph for submit@debbugs.gnu.org; Sun, 17 May 2020 09:18:54 -0400 Received: from lists.gnu.org ([209.51.188.17]:40178) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jaJBe-0007Q3-Q6 for submit@debbugs.gnu.org; Sun, 17 May 2020 09:18:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60764) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jaJBe-0006Bq-Lp for guix-patches@gnu.org; Sun, 17 May 2020 09:18:38 -0400 Received: from mail-40132.protonmail.ch ([185.70.40.132]:45586) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jaJBc-0000bl-Es for guix-patches@gnu.org; Sun, 17 May 2020 09:18:38 -0400 Date: Sun, 17 May 2020 13:18:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1589721512; bh=NMiamffFGWk62jFDyeMAkSlW424OjZWgxB5y71kYAz0=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=NXVZhO6beNiXlxLLJBpMvTCBnp4ooiKVn+JyhzIfU/8/n5d3q9m6H//ZcXHRZHq3L zFangAkKdppO7wxQopyrGJlnbK1XZsdEpTPoio24FQtAJw036arIi3f/jVSX+rNzIw Gr3dM8LaAbSdwel/JrSlvOvJ9ewc7+BEyyqxKHLI= Message-ID: <6rxX0vh7GxY4H7d6jXP10G8cqsh8_bs8V4e2JxatbfkiLwsC685g0wInwQSxzRpwsOfhm5aVovpD5lOd55GcNAXVlNGfXu1CYq4ym84-M5c=@protonmail.com> In-Reply-To: <-nBsa1KQJSwbENQmZILkCluHwqx_QyjF3PQxKtoNHoOeqeFc1FHy95KjjodciPwOSIH5XOxKIhoHv0Hzb87JVOVy3D1fEb1nD9fDidbeMiU=@protonmail.com> References: <875zd3x7z2.fsf@nicolasgoaziou.fr> <-nBsa1KQJSwbENQmZILkCluHwqx_QyjF3PQxKtoNHoOeqeFc1FHy95KjjodciPwOSIH5XOxKIhoHv0Hzb87JVOVy3D1fEb1nD9fDidbeMiU=@protonmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_115a3b853b6d3e04932e04c24b784c9d" Received-SPF: pass client-ip=185.70.40.132; envelope-from=rdes@protonmail.com; helo=mail-40132.protonmail.ch X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/17 09:18:32 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -0.0 (/) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: rdes , rdes via Guix-patches From: rdes via Guix-patches via X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=protonmail.com header.s=protonmail header.b=NXVZhO6b; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: hEhlJoIqX0rG This is a multi-part message in MIME format. --b1_115a3b853b6d3e04932e04c24b784c9d Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hello, Attached is the copyright line that should have been in the previous patch. Ryan Sent with ProtonMail Secure Email. =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original Me= ssage =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 On Friday, May 15, 2020 4:56 PM, rdes wrote: > Hello Nicolas, > > Thanks for the pointers. Attached is an updated patch. > > Ryan > > Sent with ProtonMail Secure Email. > > =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original = Message =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 > On Monday, May 11, 2020 3:10 AM, Nicolas Goaziou mail@nicolasgoaziou.fr w= rote: > > > Hello, > > rdes via Guix-patches via guix-patches@gnu.org writes: > > > > > The attached patch adds the emacs-interleave package. > > > > Thank you! Some comments follow. > > > > > Subject: [PATCH] gnu: Add emacs-interleave > > > > Your commit message should conform to Guix rules. Here, you need to add > > > > - gnu/packages/emacs-xyz.scm (emacs-interleave): New variable. > > > > > +(define-public emacs-interleave > > > +(package > > > > Indentation seems wrong. > > > > > - (name "emacs-interleave") > > > > > > - (version "20191129.958") > > > > > > - (source > > > > > > - (origin > > > > > > - (method url-fetch) > > > > > > > > > - (uri (string-append > > > > > > > > > - "https://melpa.org/packages/interleave-" > > > > > > > > > - version > > > > > > > > > - ".el")) > > > > > > > > > > We do not use MELPA sources. Instead, you could use `git-fetch' and > > extract the latest stable release from here: > > https://github.com/rudolfochrist/interleave/releases > > > > > - (sha256 > > > > > > > > > - (base32 > > > > > > > > > - "0y183ggfmkjjywbcqgyinmr21hsg2vaw4d52bg1gsxbp673za2m8"= )))) > > > > > > > > > > Nitpick: could you move the string on the same line as `base32'? > > > > > - (build-system emacs-build-system) > > > - (home-page > > > - "https://github.com/rudolfochrist/interleave") > > > > Ditto. Could you move the string on the line above? > > > > > - (synopsis "Interleaving text books since 2015") > > > > I think this synopsis needs to be reworded. As it is, it may not be > > useful. > > > > > - (description > > > - "Interleave presents your PDF side by side to an [[http://orgmode= .org][Org Mode]] > > > > Description uses Texinfo syntax, not Org syntax. In this case, however, > > I think "side by side to an Org buffer" is sufficient. > > > > > +buffer with your notes, narrowing down to just those passages that a= re relevant to > > > +the particular page in the document viewer. > > > +") > > > > You don't need to end the description with a final newline. It would be > > nice to expound it a bit. For example, it could be interesting to know > > this is a minor mode. > > Don't forget to add a copyright line with your name at the top of the f= ile. > > Could you send an updated patch? > > Regards, > > > > Nicolas Goaziou --b1_115a3b853b6d3e04932e04c24b784c9d Content-Type: text/x-patch; name="0001-gnu-packages-emacs-xyz.scm-Add-copyright.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-gnu-packages-emacs-xyz.scm-Add-copyright.patch RnJvbSA3Y2M4NTM1ZmI5MmU1ZDM5Mjc2ZWM1Y2RkNWJjMDc4ZDNkOGM1NWI2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSeWFuIERlc2Zvc3NlcyA8cnlhbkBkZXNmby5vcmc+CkRhdGU6 IFN1biwgMTcgTWF5IDIwMjAgMDk6MTU6NDYgLTA0MDAKU3ViamVjdDogW1BBVENIXSAqIGdudS9w YWNrYWdlcy9lbWFjcy14eXouc2NtOiBBZGQgY29weXJpZ2h0LgoKLS0tCiBnbnUvcGFja2FnZXMv ZW1hY3MteHl6LnNjbSB8IDEgKwogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspCgpkaWZm IC0tZ2l0IGEvZ251L3BhY2thZ2VzL2VtYWNzLXh5ei5zY20gYi9nbnUvcGFja2FnZXMvZW1hY3Mt eHl6LnNjbQppbmRleCBiNzBiOWZmZmI4Li41ZDBiZWViMmQ5IDEwMDY0NAotLS0gYS9nbnUvcGFj a2FnZXMvZW1hY3MteHl6LnNjbQorKysgYi9nbnUvcGFja2FnZXMvZW1hY3MteHl6LnNjbQpAQCAt NzAsNiArNzAsNyBAQAogOzs7IENvcHlyaWdodCDCqSAyMDIwIEFsYmVydG8gRWxldXRlcmlvIEZs b3JlcyBHdWVycmVybyA8YmFyYmFuZWdyYStndWl4QHBvc3Rlby5teD4KIDs7OyBDb3B5cmlnaHQg wqkgMjAyMCBNYXJpdXMgQmFra2UgPG1iYWtrZUBmYXN0bWFpbC5jb20+CiA7OzsgQ29weXJpZ2h0 IMKpIDIwMjAgcGlub2FmZmUgPHBpbm9hZmZlQGFpcm1haWwuY2M+Cis7OzsgQ29weXJpZ2h0IMKp IDIwMjAgUnlhbiBEZXNmb3NzZXMgPHJkZXNAcHJvdG9ubWFpbC5jb20+CiA7OzsKIDs7OyBUaGlz IGZpbGUgaXMgcGFydCBvZiBHTlUgR3VpeC4KIDs7OwotLSAKMi4yNi4yCgo= --b1_115a3b853b6d3e04932e04c24b784c9d--