From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id sEKAFLX/x17mYQAA0tVLHw (envelope-from ) for ; Fri, 22 May 2020 16:37:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id GFlMELX/x16FSAAAbx9fmQ (envelope-from ) for ; Fri, 22 May 2020 16:37:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BB6CC9402D6 for ; Fri, 22 May 2020 16:37:08 +0000 (UTC) Received: from localhost ([::1]:45724 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jcAfS-0005o9-Rg for larch@yhetil.org; Fri, 22 May 2020 12:37:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42800) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jcAfO-0005ny-NU for guix-patches@gnu.org; Fri, 22 May 2020 12:37:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48587) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jcAfO-0002Ki-E8 for guix-patches@gnu.org; Fri, 22 May 2020 12:37:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jcAfO-0000ZY-Bk for guix-patches@gnu.org; Fri, 22 May 2020 12:37:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41193] [PATCH 00/13] Update network-manager suite Resent-From: Brice Waegeneire Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 22 May 2020 16:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41193 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Famulari Cc: 41193@debbugs.gnu.org Received: via spool by 41193-submit@debbugs.gnu.org id=B41193.15901653732141 (code B ref 41193); Fri, 22 May 2020 16:37:02 +0000 Received: (at 41193) by debbugs.gnu.org; 22 May 2020 16:36:13 +0000 Received: from localhost ([127.0.0.1]:60133 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcAeQ-0000YH-JB for submit@debbugs.gnu.org; Fri, 22 May 2020 12:36:13 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:55471) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcAeO-0000Xn-Dv for 41193@debbugs.gnu.org; Fri, 22 May 2020 12:36:01 -0400 Received: from webmail.gandi.net (webmail18.sd4.0x35.net [10.200.201.18]) (Authenticated sender: brice@waegenei.re) by relay11.mail.gandi.net (Postfix) with ESMTPA id 28875100002; Fri, 22 May 2020 16:35:52 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 22 May 2020 16:35:52 +0000 From: Brice Waegeneire In-Reply-To: <20200512213613.GC12212@jasmine.lan> References: <20200511185022.23667-1-brice@waegenei.re> <20200511200501.GF15862@jasmine.lan> <64fb5600a78a1bb4e47a2b946ba6f85b@waegenei.re> <20200512213613.GC12212@jasmine.lan> Message-ID: <6fa0c0446ff6f03b87fbb5f67a7c16ed@waegenei.re> X-Sender: brice@waegenei.re User-Agent: Roundcube Webmail/1.3.8 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: EsKNmUdiB3NP Hello Leo, On 2020-05-12 21:36, Leo Famulari wrote: > On Tue, May 12, 2020 at 09:12:33PM +0000, Brice Waegeneire wrote: >> On 2020-05-11 20:05, Leo Famulari wrote: >> > I think there are some Guix system tests that should exercise >> > NetworkManager. Can you check if they still pass? >> >> I can't find the test in question, can you give me a hint were they >> should be? > > The system tests are found in 'gnu/tests'. > > I know that %desktop-services (from 'gnu/services/desktop.scm') uses > NetworkManager, so I grepped in 'gnu/tests' for %desktop-services, and > found that some of the system installation tests use %desktop-services. > > Specifically, I think that the system test > 'gui-installed-desktop-os-encrypted' should exercise NetworkManager: > > `make check-system TESTS=gui-installed-desktop-os-encrypted` > > It's not a hard requirement to run these tests IMO, especially since > you > are already using these patches successfully, but it's at least helpful > to say if you tried or not. I tired running the test but even on master it fails, CI can't built it either. But trying to built it with my patches I manage to find 2 gnome packages that broke because of it: they were looking for libnma in network-manager-applet which isn't included with it anymore. There aren't any other packages directly depending on network-manager-applet so there shouldn't be any other breakage relating to this specific issue. sirmacik tested the patchset too and used the vpnc plugin fine but as me he is not a user of the applet. Should we wait for the test to be fixed, before going forward with this patchset? I'm sending the v2 shortly. Cheers, - Brice