From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id +GBOMEXDNmS48wAASxT56A (envelope-from ) for ; Wed, 12 Apr 2023 16:42:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id oGhjL0XDNmTi9gAAG6o9tA (envelope-from ) for ; Wed, 12 Apr 2023 16:42:13 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6A35520C60 for ; Wed, 12 Apr 2023 16:42:13 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pmbfg-0008RN-Vb; Wed, 12 Apr 2023 10:42:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pmbff-0008Qu-0H for guix-patches@gnu.org; Wed, 12 Apr 2023 10:42:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pmbfe-0003Ok-Na for guix-patches@gnu.org; Wed, 12 Apr 2023 10:42:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pmbfe-0003Ab-Ix for guix-patches@gnu.org; Wed, 12 Apr 2023 10:42:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62753] [PATCH] gnu: Add emacs-eradio. Resent-From: Dominik Delgado Steuter Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 12 Apr 2023 14:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62753 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Goaziou Cc: 62753@debbugs.gnu.org Received: via spool by 62753-submit@debbugs.gnu.org id=B62753.168131047812121 (code B ref 62753); Wed, 12 Apr 2023 14:42:02 +0000 Received: (at 62753) by debbugs.gnu.org; 12 Apr 2023 14:41:18 +0000 Received: from localhost ([127.0.0.1]:40600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pmbev-00039Q-SH for submit@debbugs.gnu.org; Wed, 12 Apr 2023 10:41:18 -0400 Received: from delgado.nrw ([217.160.67.216]:54328) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pmbes-000392-6X for 62753@debbugs.gnu.org; Wed, 12 Apr 2023 10:41:16 -0400 Message-ID: <6ec3c518-1bb5-ef5e-2fa2-659b53b39f9c@delgado.nrw> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=delgado.nrw; s=mail; t=1681310467; bh=fyw8PK1wOZNE+2Gktnr5dceS1phINk/Ks0m+/JTCJLE=; h=Date:From:Subject:To:Cc:References:In-Reply-To:From; b=jik6vLpCM9cbLdUAdSXk4MP/TqG/UuXjTDREcem61F7gwO6yQfA70/MBQEYy74rkB XodnWvpHRGlex2COaZsKrf6iRfHXW5VMCRnxn4bNhvDht2JX1R2tqpNUfJvNyRmb+F 9mA0A+9fu7U+G9U0as1H8KFwctOXR32k6DhOAKrbZ//umkIRNbJ6NJykugqFqiXvuj TXAq1Kis2xsH5VzK2Vp02HMUl5vUQxe2TWdrjpJfelzb7R/g3g0Pc5slYebG4lAe0H fcFS+QkOsa+qvVqOCFpCPV97w85XapogAiHYP82lHTfAlMj/nPVXoJWsnCsQvShGsv /dvUgBddGdyeA== Date: Wed, 12 Apr 2023 16:41:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 References: <20230410084937.12440-1-d@delgado.nrw> <875ya2nsf7.fsf@nicolasgoaziou.fr> Content-Language: en-US In-Reply-To: <875ya2nsf7.fsf@nicolasgoaziou.fr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Dominik Delgado Steuter X-ACL-Warn: , Dominik Delgado Steuter via Guix-patches From: Dominik Delgado Steuter via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1681310533; a=rsa-sha256; cv=none; b=HlrJKyx7SxwxnpfOrUhaHFEw+nzr+5OhwAFfSLim8sj1/k4P0n3/Q33vpq3EW2my+afM/o WwzInpXsOxDJuLEWMEjksXCNpHt00UcitA4DB2SiS/KGxIY27Tq7RiCiVVvBK3TbiLm0wF tvtn2CjPOmRknJgCFcQooCQ5gXPYa1VBXmfDZaagWgYtThOGYFvWCKKWLJZNTM70k+U/RJ SGqQK+De+lcLwnBftT8Tsl9BAWach6oE1T76G9xLZrLP9SPMabk6cOHtaiNMblIYJKspZW pPqaiDpzNJNFVc4FeEm0wZ7RLPUrbPBBaCioxjRAslgB9wNLd2drWbO5JVxQSA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=delgado.nrw header.s=mail header.b=jik6vLpC; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1681310533; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=aDI9N77Q/H3lnHTlZkXeaEQN0JQtTqCiN1qDatKO+7w=; b=mE/ELrFgSH8sUEGJ3Xi40ZUe5DpweprjWV58xjLa4J9pAAbsgrYOfx8zZSrux2Bg9xS1/d FYMgMGtTlxgmitrZittWiM/0Bfc0WMrNEkdQEOKFPjglfNJsuQ1w3FbE9oMv5yFoLTx1AO +U9z6pu5sbtOXbBRUF7zbXz1deHGr46Ln5shVQeERXdGPyWlDwpY6hPyOl5JIRcSCGFc0n Ss/kG7QKQEfRDUhAtoV9gG6MDvQGNunt0ZhpdF1FyHXjv7TMgLLwTNJ2qqBg7CiCSeNECR ulHQ8BQ0lCGwfZl76JiaPEHPm+cArM2ofUOOLDsJ1RJ8v/UQMLyexWDznzCAeQ== X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -3.72 X-Spam-Score: -3.72 X-Migadu-Queue-Id: 6A35520C60 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=delgado.nrw header.s=mail header.b=jik6vLpC; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org X-TUID: Tyn9n48NblT+ Hi, thank you for the review. Am 11.04.23 um 21:13 schrieb Nicolas Goaziou: > I suggest to use GitHub as upstream. I saw that a couple of other Emacs-packages in this file fetched from melpa.org, but you are right, GitHub makes more sense. > I would capitalize "Eradio", but not "internet". Also I suggest to write > "Mpv" and "VLC". I am in favor of "mpv" as that is how the project stylizes itself. Wikipedia also uses that notation. > On this topic, would it make sense to provide VLC as an input, so the > Emacs library works out of the box? In my opinion the user should be encouraged to choose the player themself. I for example only use mpv and would not like my system to be cluttered with another full-blown media player I don't use. > Could you send an updated patch? It comes with the next mail. I also relocated the package definition so that it's not between two packages related to emprise anymore. Regards, Dominik D.S.