From: Christopher Baines <mail@cbaines.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add emacs-es-mode
Date: Thu, 15 Sep 2016 08:11:35 +0100 [thread overview]
Message-ID: <6ec1a3be-64ce-ad37-c625-f1725bbd9ea3@cbaines.net> (raw)
In-Reply-To: <87fup2pmy8.fsf@gnu.org>
[-- Attachment #1.1: Type: text/plain, Size: 1037 bytes --]
On 14/09/16 15:37, Ludovic Courtès wrote:
> Christopher Baines <mail@cbaines.net> skribis:
>
>> * gnu/packages/emacs.scm (emacs-es-mode): New variable.
>
> I made minor changes:
>
>> + (inputs `(("guile" ,guile-2.0)))
>
> I removed it since it’s unused, AFAICS.
>
>> + (propagated-inputs
>> + ; The version of org in Emacs 24.5 is not sufficient, and causes
>> + ; tables to be rendered incorrectly
>
> Use “;;”.
>
>> + (description "es-mode includes highlighting, completion and indentation
>> +support for Elasticsearch queries. Also supported are es-mode blocks in
>> +org-mode, for which the results of queries can be processed through jq, or
>> +in the case of aggregations, can be rendered in to a table. In addition,
>> +there is a es-command-center mode, which displays information about
>> +Elasticsearch clusters")
>
> Used @code where appropriate and added missing period.
>
> Pushed as 8bebe734ca54bf83ceae4db0a91f09a706562882, thanks!
Great, thank you :D
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 955 bytes --]
prev parent reply other threads:[~2016-09-15 7:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 7:06 [PATCH] gnu: Add emacs-es-mode Christopher Baines
2016-09-14 14:37 ` Ludovic Courtès
2016-09-15 7:11 ` Christopher Baines [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ec1a3be-64ce-ad37-c625-f1725bbd9ea3@cbaines.net \
--to=mail@cbaines.net \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.