First patch & hello

[L p R n d n <guix@lprndn.info>]

[-- Attachment #1: Type: text/plain, Size: 927 bytes --]

Hello,

First, thank you very much for all the work done on Guix, it's a
pleasure to use it. And also many thanks to Pierre Neidhardt for his
very nice packaging tutorial, it helped me a lot.

So, I wrote my first package for guix and as I'm no dev and not used to
work with patches so I wanted to get some feedbacks before trying to
submit it.

I tried to package font-manager based on the definition used in Nix. It
seems to work but I have a few questions.

1 . I put the package under fontutils.scm but maybe there's a better
place for a font viewer?
2. I found there is a glib-or-gtk-build-system, I hesitated to use as 
Im̀
not sure what its purpose. Can someone clarify its use?
3. I tried to get a clean patch but it needed some manual work. What
your workflow to produce patches? (I use emacs)

(It's also my first time using a mailing list, I hope I didn't butcher 
anything)

Thanks,
Lprndn

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-font-manager.patch --]
[-- Type: text/x-patch; name=0001-gnu-Add-font-manager.patch, Size: 3039 bytes --]

From 32325ac307438712a3720259edd092c5e4e1e556 Mon Sep 17 00:00:00 2001
From: Lprndn <guix@lprndn.info>
Date: Tue, 13 Nov 2018 13:19:26 +0100
Subject: [PATCH] gnu: Add font-manager.

---
 gnu/packages/fontutils.scm | 54 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 54 insertions(+)

diff --git a/gnu/packages/fontutils.scm b/gnu/packages/fontutils.scm
index 09ba9b7e4..21eb54b29 100644
--- a/gnu/packages/fontutils.scm
+++ b/gnu/packages/fontutils.scm
@@ -43,6 +43,10 @@
   #:use-module (gnu packages xorg)
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages xml)
+  #:use-module (gnu packages file)
+  #:use-module (gnu packages base)
+  #:use-module (gnu packages databases)
+  #:use-module (gnu packages gnome)
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix packages)
   #:use-module (guix download)
@@ -619,6 +623,56 @@ generate bitmaps.")
    (license license:gpl3+)
    (home-page "https://fontforge.github.io/en-US/")))
 
+(define-public font-manager
+  (package
+   (name "font-manager")
+   (version "0.7.3.1")
+   (source (origin
+            (method url-fetch)
+            (uri (string-append "https://github.com/FontManager/master/archive/" version ".tar.gz"))
+            (sha256
+             (base32 "1zq2v299xqznj31brjh8nk1w4hb47qpxsyg4ngp01dh7f2sza146"))))
+   (build-system gnu-build-system)
+   (arguments
+    `(#:configure-flags
+      '("--with-file-roller" "--disable-pycompile")
+      #:phases
+      (modify-phases %standard-phases
+                     (add-after 'unpack 'noconfigure
+                      (lambda _
+                        (setenv "NOCONFIGURE" "true")
+                        #t)))))
+   (native-inputs
+    `(("pkg-config" ,pkg-config)
+      ("automake" ,automake)
+      ("autoconf" ,autoconf)
+      ("libtool" ,libtool)
+      ("file" ,file)
+      ("vala" ,vala)
+      ("yelp-tools" ,yelp-tools)
+      ("gobject-introspection" ,gobject-introspection)))
+   (inputs
+    `(("file-roller" ,file-roller)
+      ("libxml2" ,libxml2)
+      ("json-glib" ,json-glib)
+      ("sqlite" ,sqlite)
+      ("itstool" ,itstool)
+      ("librsvg" ,librsvg)
+      ("gtk+" ,gtk+)
+      ("glib" ,glib "bin")
+      ("intltool" ,intltool)
+      ("gucharmap" ,gucharmap)
+      ("libgee" ,libgee)))
+   (home-page "https://fontmanager.github.io/")
+   (synopsis "Simple font management for GTK+ desktop environments.")
+   (description "Font Manager is intended to provide a way for average users to
+      easily manage desktop fonts, without having to resort to command
+      line tools or editing configuration files by hand. While designed
+      primarily with the Gnome Desktop Environment in mind, it should
+      work well with other Gtk+ desktop environments.
+      Font Manager is NOT a professional-grade font management solution.")
+   (license license:gpl3)))
+
 (define-public python2-ufolib
   (package
     (name "python2-ufolib")
-- 
2.19.1