From d2d739db1dc72907df43df156d19f8fefae0c4db Mon Sep 17 00:00:00 2001 From: Maxime Devos Date: Thu, 8 Jul 2021 17:07:42 +0200 Subject: [PATCH 1/7] gnu: python-pymediainfo: Respect "--without-tests". * gnu/packages/python-xyz.scm (python-pymediainfo)[arguments]<#:phases>{check}: Respect #:tests?. Don't bother returning #t as it isn't required anymore. --- gnu/packages/python-xyz.scm | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm index ec4209108f..d42119fd3c 100644 --- a/gnu/packages/python-xyz.scm +++ b/gnu/packages/python-xyz.scm @@ -100,6 +100,7 @@ ;;; Copyright © 2021 Ellis Kenyő ;;; Copyright © 2021 LibreMiami ;;; Copyright © 2021 Xinglu Chen +;;; Copyright © 2021 Maxime Devos ;;; ;;; This file is part of GNU Guix. ;;; @@ -745,14 +746,14 @@ to CommonMark.") "/lib/libmediainfo.so.0"))) #t)) (replace 'check - (lambda _ - ;; Extend PYTHONPATH so the built package will be found. - (setenv "PYTHONPATH" - (string-append (getcwd) "/build/lib:" - (getenv "PYTHONPATH"))) - ;; Skip the only failing test "test_parse_url" - (invoke "pytest" "-vv" "-k" "not test_parse_url") - #t))))) + (lambda* (#:key tests? #:allow-other-keys) + (when tests? + ;; Extend PYTHONPATH so the built package will be found. + (setenv "PYTHONPATH" + (string-append (getcwd) "/build/lib:" + (getenv "PYTHONPATH"))) + ;; Skip the only failing test "test_parse_url" + (invoke "pytest" "-vv" "-k" "not test_parse_url"))))))) (home-page "https://github.com/sbraz/pymediainfo") (synopsis -- 2.32.0