[bug#50724] [PATCH 1/3] gnu: Add python-charset-normalizer.

[bug#50724] [PATCH 1/3] gnu: Add python-charset-normalizer.

[Hartmut Goebel]

* gnu/packages/python-xyz.scm (python-charset-normalizer): New variable.
---
 gnu/packages/python-xyz.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 88c89ed201..7239fa1584 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -11819,6 +11819,27 @@ automatically detect a wide range of file encodings.")
 (define-public python2-chardet
   (package-with-python2 python-chardet))
 
+(define-public python-charset-normalizer
+  (package
+    (name "python-charset-normalizer")
+    (version "2.0.5")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "charset-normalizer" version))
+       (sha256
+        (base32 "0rr3iv2xw4rz5ijnfqk229fw85cq6p6rhqqsilm0ldzncblfg63h"))))
+    (build-system python-build-system)
+    (native-inputs
+     `(("python-pytest" ,python-pytest)))
+    (home-page "https://github.com/ousret/charset_normalizer")
+    (synopsis "Universal Charset Detector, alternative to Chardet")
+    (description "This library helps you read text from an unknown charset
+encoding.  Motivated by @code{chardet}, it tries to resolve the issue by
+taking a new approach.  All IANA character set names for which the Python core
+library provides codecs are supported.")
+    (license license:expat)))
+
 (define-public python-docopt
   (package
     (name "python-docopt")
-- 
2.30.2

[bug#50724] [PATCH 2/3] gnu: Add python-platformdirs.

[Hartmut Goebel]

* gnu/packages/python-xyz.scm (python-platformdirs): New variable.
---
 gnu/packages/python-xyz.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 7239fa1584..908e9dbff6 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -26799,3 +26799,29 @@ services' API.  It includes a pre-defined set of classes for API resources
 that initialize themselves dynamically from API responses which makes it
 compatible with a wide range of versions of the Stripe API.")
     (license license:expat)))
+
+(define-public python-platformdirs
+  (package
+    (name "python-platformdirs")
+    (version "2.2.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "platformdirs" version))
+       (sha256
+        (base32 "07hq5qrp7pqj63iczg01wbf5ii6f0ncd0dq5mzkdhsslmg9slbb3"))))
+    (build-system python-build-system)
+    (native-inputs
+     `(("python-appdirs" ,python-appdirs)
+       ("python-pytest" ,python-pytest)
+       ("python-pytest-cov" ,python-pytest-cov)
+       ("python-pytest-mock" ,python-pytest-mock)))
+    (home-page "https://github.com/platformdirs/platformdirs")
+    (synopsis "Determine the appropriate platform-specific dirs, e.g. \"user
+data dir\"")
+    (description "When writing applications, finding the right location to
+store user data and configuration varies per platform.  Even for
+single-platform apps, there may by plenty of nuances in figuring out the right
+location.  This small Python module determines the appropriate
+platform-specific directories, e.g. the \"user data dir\".")
+    (license license:expat)))
-- 
2.30.2

[bug#50724] [PATCH 2/3] gnu: Add python-platformdirs.

[Xinglu Chen]

[-- Attachment #1: Type: text/plain, Size: 2184 bytes --]

On Tue, Sep 21 2021, Hartmut Goebel wrote:

> * gnu/packages/python-xyz.scm (python-platformdirs): New variable.
> ---
>  gnu/packages/python-xyz.scm | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> index 7239fa1584..908e9dbff6 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -26799,3 +26799,29 @@ services' API.  It includes a pre-defined set of classes for API resources
>  that initialize themselves dynamically from API responses which makes it
>  compatible with a wide range of versions of the Stripe API.")
>      (license license:expat)))
> +
> +(define-public python-platformdirs
> +  (package
> +    (name "python-platformdirs")
> +    (version "2.2.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "platformdirs" version))
> +       (sha256
> +        (base32 "07hq5qrp7pqj63iczg01wbf5ii6f0ncd0dq5mzkdhsslmg9slbb3"))))
> +    (build-system python-build-system)
> +    (native-inputs
> +     `(("python-appdirs" ,python-appdirs)
> +       ("python-pytest" ,python-pytest)
> +       ("python-pytest-cov" ,python-pytest-cov)
> +       ("python-pytest-mock" ,python-pytest-mock)))
> +    (home-page "https://github.com/platformdirs/platformdirs")
> +    (synopsis "Determine the appropriate platform-specific dirs, e.g. \"user
> +data dir\"")

The example is also mentioned in the description, so I would drop the
“e.g. ...” part.  Also, I would write “directories” instead of “dirs”,
just for the sake of clarity.

> +    (description "When writing applications, finding the right location to
> +store user data and configuration varies per platform.  Even for
> +single-platform apps, there may by plenty of nuances in figuring out the right
> +location.  This small Python module determines the appropriate
> +platform-specific directories, e.g. the \"user data dir\".")

Use ``'' instead of "", see the Texinfo manual on quote characters.

  <https://www.gnu.org/software/texinfo/manual/texinfo/texinfo.html#Inserting-Quote-Characters>



[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

[bug#50724] [PATCH 2/3] gnu: Add python-platformdirs.

[Hartmut Goebel]

Hi Xinglu,

thanks for the fast review.

I adjusted python-platformdirs as you recommended and pushed both 
python-charset-normalizer and python-platformdirs as 
a24ae17e230d8d1f8b036c298e68fdcb08edff62

The python-zeep I withdrew.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          |h.goebel@crazy-compilers.com                |
|www.crazy-compilers.com  | compilers which you thought are impossible |

[bug#50724] [PATCH 3/3] gnu: Add python-zeep.

[Hartmut Goebel]

* gnu/packages/python-web.scm (python-zeep): New variable.
---
 gnu/packages/python-web.scm | 42 +++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index 302e5d6459..10507240e1 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -6234,3 +6234,45 @@ communicate with Microsoft Azure Storage services.")
 or tags from HTML snippets, extract base url from HTML snippets, translate entites
 on HTML strings, among other things.")
     (license license:bsd-3)))
+
+(define-public python-zeep
+  (package
+    (name "python-zeep")
+    (version "4.1.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "zeep" version))
+       (sha256
+        (base32 "1ranr4hkjd2kbbhxa3is1qlgkankj3sml5gla6bqs0kbvpmg4rsq"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("python-attrs" ,python-attrs)
+       ("python-cached-property" ,python-cached-property)
+       ("python-isodate" ,python-isodate)
+       ("python-lxml" ,python-lxml)
+       ("python-platformdirs" ,python-platformdirs)
+       ("python-pytz" ,python-pytz)
+       ("python-requests" ,python-requests)
+       ("python-requests-file" ,python-requests-file)
+       ("python-requests-toolbelt" ,python-requests-toolbelt)))
+    (native-inputs
+     `(("python-coverage" ,python-coverage)
+       ;;("python-flake8" ,python-flake8)
+       ;; ("python-flake8-blind-except" ,python-flake8-blind-except)
+       ;; ("python-flake8-debugger" ,python-flake8-debugger)
+       ;; ("python-flake8-imports" ,python-flake8-imports)
+       ("python-freezegun" ,python-freezegun)
+       ;;("python-isort" ,python-isort)
+       ("python-mock" ,python-mock)
+       ("python-pretend" ,python-pretend)
+       ("python-pytest" ,python-pytest)
+       ("python-pytest-asyncio" ,python-pytest-asyncio)
+       ("python-pytest-cov" ,python-pytest-cov)
+       ("python-pytest-httpx" ,python-pytest-httpx)
+       ("python-requests-mock" ,python-requests-mock)))
+    (home-page "http://docs.python-zeep.org")
+    (synopsis "Fast and modern Python SOAP client")
+    (description "This package provides a fast and modern Python SOAP client
+based on lxml and requests.")
+    (license license:expat)))
-- 
2.30.2

[bug#50724] [PATCH 3/3] gnu: Add python-zeep.

[Xinglu Chen]

[-- Attachment #1: Type: text/plain, Size: 2985 bytes --]

On Tue, Sep 21 2021, Hartmut Goebel wrote:

> * gnu/packages/python-web.scm (python-zeep): New variable.
> ---
>  gnu/packages/python-web.scm | 42 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 42 insertions(+)
>
> diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
> index 302e5d6459..10507240e1 100644
> --- a/gnu/packages/python-web.scm
> +++ b/gnu/packages/python-web.scm
> @@ -6234,3 +6234,45 @@ communicate with Microsoft Azure Storage services.")
>  or tags from HTML snippets, extract base url from HTML snippets, translate entites
>  on HTML strings, among other things.")
>      (license license:bsd-3)))
> +
> +(define-public python-zeep
> +  (package
> +    (name "python-zeep")
> +    (version "4.1.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "zeep" version))
> +       (sha256
> +        (base32 "1ranr4hkjd2kbbhxa3is1qlgkankj3sml5gla6bqs0kbvpmg4rsq"))))
> +    (build-system python-build-system)
> +    (propagated-inputs
> +     `(("python-attrs" ,python-attrs)
> +       ("python-cached-property" ,python-cached-property)
> +       ("python-isodate" ,python-isodate)
> +       ("python-lxml" ,python-lxml)
> +       ("python-platformdirs" ,python-platformdirs)
> +       ("python-pytz" ,python-pytz)
> +       ("python-requests" ,python-requests)
> +       ("python-requests-file" ,python-requests-file)
> +       ("python-requests-toolbelt" ,python-requests-toolbelt)))
> +    (native-inputs
> +     `(("python-coverage" ,python-coverage)
> +       ;;("python-flake8" ,python-flake8)
> +       ;; ("python-flake8-blind-except" ,python-flake8-blind-except)
> +       ;; ("python-flake8-debugger" ,python-flake8-debugger)
> +       ;; ("python-flake8-imports" ,python-flake8-imports)
> +       ("python-freezegun" ,python-freezegun)
> +       ;;("python-isort" ,python-isort)

Why are some of these inputs commented out?

> +       ("python-mock" ,python-mock)
> +       ("python-pretend" ,python-pretend)
> +       ("python-pytest" ,python-pytest)
> +       ("python-pytest-asyncio" ,python-pytest-asyncio)
> +       ("python-pytest-cov" ,python-pytest-cov)
> +       ("python-pytest-httpx" ,python-pytest-httpx)

‘python-pytest-httpx’ doesn’t seem to exist; which commit are you basing
these patches off of?  My checkout is based off of commit
5966d48d1c9e48b7098845193469f5b5fe07d540.

This is why people should be using the ‘--base’ flag when invoking ‘git
format-patch’.  :-)

> +       ("python-requests-mock" ,python-requests-mock)))
> +    (home-page "http://docs.python-zeep.org")

Why not HTTPS?

> +    (synopsis "Fast and modern Python SOAP client")
> +    (description "This package provides a fast and modern Python SOAP client
> +based on lxml and requests.")

I would use @code{python-lxml} and @code{python-requests} to make it
clear that these are packages and not just regular words.



[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

[bug#50724] [PATCH 3/3] gnu: Add python-zeep.

[Hartmut Goebel]

Hi Xinglu,
> ‘python-pytest-httpx’ doesn’t seem to exist; which commit are you basing

Ups, Sorry for wasting your time by submitting an incomplete patch. I 
withdrew the patch.

I cherry-picked this patch from another pile of patches, which contains 
python-pytest-httpx. Anyhow packaging python-pytest-httpx ended up in 
updating many other packages, updating which is to touchy for me.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |