From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id GAqKNX5AzGAlsQAAgWs5BA (envelope-from ) for ; Fri, 18 Jun 2021 08:43:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id CN0lMX5AzGD7RgAAB5/wlQ (envelope-from ) for ; Fri, 18 Jun 2021 06:43:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9C0911180D for ; Fri, 18 Jun 2021 08:43:09 +0200 (CEST) Received: from localhost ([::1]:54722 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lu8Db-0001nZ-Oz for larch@yhetil.org; Fri, 18 Jun 2021 02:43:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50984) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lu8DW-0001nP-RJ for guix-patches@gnu.org; Fri, 18 Jun 2021 02:43:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:43944) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lu8DW-0004AA-JI for guix-patches@gnu.org; Fri, 18 Jun 2021 02:43:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lu8DW-0005cS-7C for guix-patches@gnu.org; Fri, 18 Jun 2021 02:43:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48729] [PATCH v2 05/47] gnu: Add go-github-com-keybase-go-ps. Resent-From: Raghav Gururajan Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 18 Jun 2021 06:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48729 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Maxime Devos , 48729@debbugs.gnu.org Cc: jgart@disroot.org Received: via spool by 48729-submit@debbugs.gnu.org id=B48729.162399856821580 (code B ref 48729); Fri, 18 Jun 2021 06:43:02 +0000 Received: (at 48729) by debbugs.gnu.org; 18 Jun 2021 06:42:48 +0000 Received: from localhost ([127.0.0.1]:55490 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lu8DH-0005c0-M8 for submit@debbugs.gnu.org; Fri, 18 Jun 2021 02:42:47 -0400 Received: from out1.migadu.com ([91.121.223.63]:35294) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lu8DD-0005bp-Du for 48729@debbugs.gnu.org; Fri, 18 Jun 2021 02:42:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raghavgururajan.name; s=key1; t=1623998561; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yNYBonL/cQ0lIFhNM9jEJ0zw9hAVNw9bwP5x5jkK2pQ=; b=l5a/OZWdlkj9Z6Mk5j8Bx/bMuiXaPuOWy042JTfA3s7J686dTVTM9AovNmYIIPyIpVD4aB 5r1dALiy9st19Cc2XadlCuYDzSJvVmLJiY/aiSp+V88biAuZXclhxvzrm7bjdkxVP9Lknc Z3oiMW+bTF0Y0mM7F1zazDlPEAtC2gG9TebvCrAQXDsTn+WTmfzvo4ToaUZbVY7s/4OKsv Yj12KzhKFRsGvm2p8tuSZ4r3T5czsRWT8VS2ow5aQMkpvVMvl1s4TKwEF0Y4+ZXTQO0my3 qpfT8Bht1E9YK8Eui6TWboQ/ha9mtQfx078x46GKeVi+ejlt5Mc1v7jGzJ2Brw== References: <20210603095814.21158-1-rg@raghavgururajan.name> <20210603095814.21158-5-rg@raghavgururajan.name> <4247c42748d39d1009c1493ec953a89106ea7800.camel@telenet.be> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. Message-ID: <6de82bae-5ed0-ac01-3ffa-59d14d3f54ff@raghavgururajan.name> Date: Fri, 18 Jun 2021 02:42:37 -0400 MIME-Version: 1.0 In-Reply-To: <4247c42748d39d1009c1493ec953a89106ea7800.camel@telenet.be> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="KVvC80sn2ez5kF3vU6UUf71cxLjertBfP" X-Migadu-Auth-User: rg@raghavgururajan.name X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Raghav Gururajan X-ACL-Warn: , Raghav Gururajan via Guix-patches From: Raghav Gururajan via Guix-patches via X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1623998590; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=yNYBonL/cQ0lIFhNM9jEJ0zw9hAVNw9bwP5x5jkK2pQ=; b=Z6e/7eLTWTi9jp2qLDyzd8aXjddAod31Op7p8xSqxgTfs8kqUCJH3rjwpF5qGIvW4BXYoS x9CE4gGBxJA/7k3syCWDaBaFnVyxD0hsWB2b6EugBNEfn/9fInLbXPqiwr566gwtuAGfOR jJJTG1xbb3NvevjTq3f7fW/E+hJB9J11UJ5raERU1QtpcSdkLtyXoPJrFuM4RpJqS59cEc 5VrNKZB4RliHD2BUBaNEaJOOr86CNkpOCqZKkqBTBH6Xq2Fj9Q3kGdE5+Jt2OCPBSDwkBb M4oE6AtF3FCOLgFiq2ohADriFAxJY1wKlsZyqlhGnuO7yeoIXcIv/kkuPdJQRw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1623998590; a=rsa-sha256; cv=none; b=JbCKVzLcWuecsw0z9cgIbk6YlhmjKzrUW/lfrJNp5FPSNkGadU7gzRkH0Zt1XO/CYGef9X 9K29Mn7Dfsxq8dfLsu91HeiIIbZue12lx8nG9PszMfZHU8LLD5M/OTff/n8mXjgBEwcLKp /SY2AMuzq3envGefWZ+FJqcdBJD0PL2bPWQvHlzwK3wZLoy7nV3iaEXj0DrIk8eUKNl2bL 4jIOjezS2zUDbWlePwcMarXixHHAn9ho/5WMEBbX2srOQ8CU6bfYMu8T207eJdZaz9cnbK zLfhzfCtjAf+qB9lCxscITGDoO7oHkiCLkX0d/bWC1Gr8tyYYLrhnu5dL8fzOg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=raghavgururajan.name header.s=key1 header.b="l5a/OZWd"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -5.03 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=raghavgururajan.name header.s=key1 header.b="l5a/OZWd"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 9C0911180D X-Spam-Score: -5.03 X-Migadu-Scanner: scn1.migadu.com X-TUID: 4e/r1SLS9YY7 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --KVvC80sn2ez5kF3vU6UUf71cxLjertBfP Content-Type: multipart/mixed; boundary="fQe3V7tsAI1regRBZE5v6ykJieuAmKgOU"; protected-headers="v1" From: Raghav Gururajan To: Maxime Devos , 48729@debbugs.gnu.org Cc: jgart@disroot.org Message-ID: <6de82bae-5ed0-ac01-3ffa-59d14d3f54ff@raghavgururajan.name> Subject: Re: [bug#48729] [PATCH v2 05/47] gnu: Add go-github-com-keybase-go-ps. References: <20210603095814.21158-1-rg@raghavgururajan.name> <20210603095814.21158-5-rg@raghavgururajan.name> <4247c42748d39d1009c1493ec953a89106ea7800.camel@telenet.be> In-Reply-To: <4247c42748d39d1009c1493ec953a89106ea7800.camel@telenet.be> --fQe3V7tsAI1regRBZE5v6ykJieuAmKgOU Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-CA Content-Transfer-Encoding: quoted-printable Hi Maxime! >> I am confused. It is used only during check phase (which is build-time= ), >> so when cross-compiling, the arch for build machine is used for >> native-inputs right? >=20 > The Go build system doesn't support cross-compilation currently. > So, for explanation, let's assume gnu-build-system instead. >=20 > The issue is that, when cross-compiling, 'inputs' consists solely > of the packages listed in the 'inputs' field of the package definition > (When compiling natively, 'native-inputs' is merged into 'inputs'.) >=20 > As "coreutils" is not in "inputs", it follows that that (assoc-ref inpu= ts "coreutils") > returns #f. Thus, when (string-append (assoc-ref inputs "coreutils") "/= bin/sleep") > is executed, it raises an exception, as string-append expects strings o= nly. > Now, about: >=20 >> I am confused. It is used only during check phase (which is build-time= ), >> so when cross-compiling, [...] >=20 > The [...]/bin/sleep binary is only used during the check phase (and the= refore > ignored when cross-compiling), yes, but the (string-append [...]) is _a= lways_ > executed! >=20 >> so when cross-compiling, the arch for build machine is used for native= -inputs, >> right? >=20 > Yes. >=20 >> I wonder how other native-inputs like gettext etc doesn't give this er= ror. >=20 > There's very little code doing (assoc-ref inputs "gettext"), > (assoc-ref native-inputs "gettext") or (assoc-ref native-inputs "gettex= t") > in Guix. The only case I found: >=20 > # cargo-build-system > (when (assoc-ref inputs "gettext") > (setenv "GETTEXT_SYSTEM" (assoc-ref inputs "gettext"))) >=20 > So, I'm not sure what you're referring to. >=20 > Simply including gettext in native-inputs doesn't cause an error. >=20 > It it trying to (string-append (assoc-ref inputs "gettext") "stuff") th= at > raises an error when 'gettext' is not in 'inputs' or 'native-inputs' wh= en compiling natively, > or when 'gettext' is not in 'inputs' when cross-compiling, > as in these cases, (assoc-ref inputs "gettext") returns #f. Thanks so much for the explanation. I understood it now. :) I have added your suggestion in v5. Regards, RG. --fQe3V7tsAI1regRBZE5v6ykJieuAmKgOU-- --KVvC80sn2ez5kF3vU6UUf71cxLjertBfP Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQTNLV6qqYzLN9qR1rBfWBZkf4vlUQUCYMxAXgUDAAAAAAAKCRBfWBZkf4vlUaQo AP0Y+e62VLmV0Ng04Q8hoqxvrO1ibIT9CcsYH7kbrfEC0AEAntJTIjaljhePQP4OBGrr0NyPrdhQ GX1w2bMhvjo6gQE= =K+WV -----END PGP SIGNATURE----- --KVvC80sn2ez5kF3vU6UUf71cxLjertBfP--